Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
translations translations
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  Save downscaled album art in database as cache
« previous next »
  • Print
Pages: 1 [2]

Author Topic: Save downscaled album art in database as cache  (Read 1970 times)

Offline Yakov5776

  • Member
  • *
  • Posts: 9
Re: Save downscaled album art in database as cache
« Reply #15 on: January 01, 2025, 02:27:25 PM »
Of course, but I’d like to focus on implementing this in the most ideal way, as getting it working isn’t the only objective.
Logged

Offline bahus

  • Member
  • *
  • Posts: 208
Re: Save downscaled album art in database as cache
« Reply #16 on: February 08, 2025, 07:10:44 AM »
Quote from: Yakov5776 on January 01, 2025, 02:27:25 PM
Of course, but I’d like to focus on implementing this in the most ideal way, as getting it working isn’t the only objective.

It seems you sent me a personal email some time ago with the following request:
Quote
if it's possible if I can load music tracks with album art enabled w/o waiting for the art to actually load so the audio starts right away even if it takes some extra time for the art to decode

Please use the forum for your requests unless it's a business proposal. At a quick glance, I think the image processing needs to be moved to a separate thread to work smoothly. Currently, it's done in the audio thread, so even if we delay loading album art, the user interface won't be responsive to your actions (volume/pause/next/...) when we come back to processing large album art (though audio playback should be OK as it's done in a different codec thread). I'm not really interested in this functionality to look any deeper.

Here's a quick workaround that simply skips loading large album arts (>2MB, can be adjusted in MAX_AA_SIZE). Maybe it will work for you:
https://github.com/bahusoid/rockbox/commit/612bca1aab1fc41e56316fb9d01bc59afec70eab

If you need a patch file just add .patch to the link above.
Logged

  • Print
Pages: 1 [2]
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Feature Ideas
| | |-+  Save downscaled album art in database as cache
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.084 seconds with 21 queries.