Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
translations translations
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Third Party
| |-+  Unsupported Builds
| | |-+  Sansa Clip+: whiskers75/rockbox
« previous next »
  • Print
Pages: [1]

Author Topic: Sansa Clip+: whiskers75/rockbox  (Read 7953 times)

Offline whiskers75

  • Member
  • *
  • Posts: 100
  • github.com/whiskers75
    • whiskers75
Sansa Clip+: whiskers75/rockbox
« on: December 31, 2012, 10:19:27 AM »
whiskers75/rockbox       
Fork of Rockbox main repo, with a few additions for the clip+ and feature requests from around the forum.
Link: https://github.com/whiskers75/rockbox   
Build Status: https://travis-ci.org/whiskers75/rockbox

I take NO liability for anything that happens using these builds.

Releases
  • devrel-1 https://github.com/whiskers75/rockbox/tree/devrel-1


Current major changes:
[/font]
  • Commit f65fddacdbabead7b37e0578acc3b1ab5fa09bd3: The plugin boomshine's Total Score counter does not fit on the clip+, removed. Amended with [master d8d206d] This should only disable level points on targets with LCD_WIDTH lower than 64

Day/Night cycle status:   
Work in progress! Check back later. :)
(from thread http://forums.rockbox.org/index.php/topic,42314.0.html)
« Last Edit: February 01, 2013, 02:00:09 PM by whiskers75 »
Logged
whiskers75/rockbox - Custom Build  
http://forums.rockbox.org/index.php/topic,42527.0.html
Devices: Sansa Clip+

Offline bluebrother

  • Developer
  • Member
  • *
  • Posts: 3555
  • creature
Re: Sansa Clip+: whiskers75/rockbox
« Reply #1 on: January 01, 2013, 10:39:21 AM »
Quote from: whiskers75 on December 31, 2012, 10:19:27 AM
(Apologies for the litter of Travis commits, Travis is being very uncooperative) >:(

I don't know about this Travis thing, but having more descriptive commit messages than simply "Travis" would be really helpful for people to understand what you did. You could also squash those commits before pushing to github ...
Logged

Offline whiskers75

  • Member
  • *
  • Posts: 100
  • github.com/whiskers75
    • whiskers75
Re: Sansa Clip+: whiskers75/rockbox
« Reply #2 on: January 01, 2013, 12:27:32 PM »
Github needs a way to squash a ton of commits into one.
Logged
whiskers75/rockbox - Custom Build  
http://forums.rockbox.org/index.php/topic,42527.0.html
Devices: Sansa Clip+

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1661
  • Hayden Pearce
    • Google+
Re: Sansa Clip+: whiskers75/rockbox
« Reply #3 on: January 01, 2013, 07:00:29 PM »
Quote from: whiskers75 on January 01, 2013, 12:27:32 PM
Github needs a way to squash a ton of commits into one.

No, it doesn't.

That isn't GitHub's job. GitHub hosts what you put there, nothing more. If you want to squash several commits, do it before you push.


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline [Saint]

  • Rockbox Expert
  • Member
  • *
  • Posts: 1661
  • Hayden Pearce
    • Google+
Re: Sansa Clip+: whiskers75/rockbox
« Reply #4 on: January 01, 2013, 07:13:21 PM »
Another reply for a seperate issue...

I notice you doing some "weird sh*t (TM)" in your repo. Which is fine, it's your repo...it doesn't need to make any sense I guess.

One example, is your commit: "Boomshine total score doesnt work on a clip+"

The "fix" for this, is apparently, to disable total scores for *every* target...which seems a little odd to me since checking if the player is a "Clip" type is trivial (If it fails on Clip+, it'll fail on the others too {resolution, I'm guessing}). I'm also not entirely sure that disabling it altogether is the best option, it's your score...without this, playing the game doesn't seem particularly fun. The simpler option would be to simply alternate the level/total points on players where we know we can't display all this info at once.

There's more, but, it's your repo. I'm not going to say you should do X, Y or Z without knowing whether or not your care about breaking other targets for the sake of one or not.


[Saint]
Logged
Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline whiskers75

  • Member
  • *
  • Posts: 100
  • github.com/whiskers75
    • whiskers75
Re: Sansa Clip+: whiskers75/rockbox
« Reply #5 on: January 02, 2013, 04:00:23 AM »
Quote from: [Saint] on January 01, 2013, 07:13:21 PM
Another reply for a seperate issue...

I notice you doing some "weird sh*t (TM)" in your repo. Which is fine, it's your repo...it doesn't need to make any sense I guess.

One example, is your commit: "Boomshine total score doesnt work on a clip+"

The "fix" for this, is apparently, to disable total scores for *every* target...which seems a little odd to me since checking if the player is a "Clip" type is trivial (If it fails on Clip+, it'll fail on the others too {resolution, I'm guessing}). I'm also not entirely sure that disabling it altogether is the best option, it's your score...without this, playing the game doesn't seem particularly fun. The simpler option would be to simply alternate the level/total points on players where we know we can't display all this info at once.

There's more, but, it's your repo. I'm not going to say you should do X, Y or Z without knowing whether or not your care about breaking other targets for the sake of one or not.


[Saint]

I'll fix that. (This is a clip+ build, but it's a good idea to keep it compatible with the others)
« Last Edit: January 02, 2013, 04:05:55 AM by whiskers75 »
Logged
whiskers75/rockbox - Custom Build  
http://forums.rockbox.org/index.php/topic,42527.0.html
Devices: Sansa Clip+

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Third Party
| |-+  Unsupported Builds
| | |-+  Sansa Clip+: whiskers75/rockbox
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.111 seconds with 21 queries.