Conditionals with timings

[ew]

Is there a problem with conditionals and timings in the latest build.

The following snippet

%?mp<|%pb(0,0,-,-,linebarpb.bmp)|%pb(0,0,-,-,linebarpb.bmp)|%pb(0,0,-,-,linebarpb.bmp)|||%pb(0,0,-,-,linebarpb.bmp)|%pb(0,0,-,-,linebarpb.bmp)>

used to skip (display for 0 seconds) any blank values.  The recent build (27847 using the Sansa e200 simulator) seems to display all of the blank values.

Also, another observation using the recent change to the skin parser.  I used to have viewports that called other viewports.  For example:

%Vd(a)
......
%Vl(a,bla,bla....)
Display this text and the next viewport
%Vd(b)
......
%Vl(b,bla,bla....)
Display text
Display image

With the new skin parser, stuff in the secondary viewport are not cleared when they are no longer called by the primary viewport.  The old skin parser used to clear the sub viewports.  I did not know if that was something that was intended or unintended - I just though I would ask.

Thanks,

EW

[JdGordon]

apparently there is, it shuold have been fixed during the week,,, I'll have another look tomorow maybe

[ew]

Have you had a chance to look into this?  Unless I am doing something wrong - and, I realized that I must have posted the wrong snippet from my wps.

The snippet (conditional timing that is not working for me) is:

%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

Thanks,

[JdGordon]

how is it not working for you?

[[Saint]]

Code: [Select]


%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>

%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>



Is working as expected for me...I had to add the newline in the middle as the themeeditor seems to think its one line without doing so.

Code: [Select]

%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>
%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

Appears as:

Composer:Current Composer;Alb Artist:Current Album Artist; Trk Artist:Current Track Artist

As opposed to:

Composer:
Current Composer
;
Alb Artist:
Current Album Artist
;
Trk Artist:
Current Track Artist

* ";" signifies an alternation.


Something definitely isn't right in Alternating-Subline Town.



[St.]

[ew]

Perhaps I should have clarified what my issue is.

There are 3 alternating displays (the info for each is divided into 2 lines):

• Composer
• Track Artist
• Album Artist

On top of that is a conditional.  The conditional says that if the tag value is blank, skip (or display for time=zero) that display.

For example if the composer tag = "abc", and there are no Track Artist or Album Artist tags, the display will be:

Composer
ABC

and there would be no alternating text (because of the conditional.

What is happening for me is that the blanks are displaying alternatively.  It is as if the %t(0) tag is being displayed for a short time instead of no time at all.

I hope this explanation is a bit clearer.

[JdGordon]

interesting experiment... can you add ;%t(0) at least 25 times to your line and see if there is a difference in the time it takes to get back to displaying the composer text?
I think I see the bug and if you do notice an extra delay then it would be confirmed.. or alternativly, can you build your own builds?

[ew]

What I did is added ;%t(0) - 25 times at the end of one of the two lines.  The two lines have always been in sync (same conditions, same timings, just different text being displayed.

The two lines were out of sync - which means to me that the ;%t(0) did add some time.

Just to be clear - what I tested is the following:

1st line

%?ic<%s%al%t(6)Composer:|%t(0)>;%?iA<%s%al%t(6)Alb Artist:|%t(0)>;%?ia<%s%al%t(6)Trk Artist:|%t(0)>;%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0);%t(0)

2nd line

%?ic<%s%al%t(6)%ic|%t(0)>;%?iA<%s%al%t(6)%iA|%t(0)>;%?ia<%s%al%t(6)%ia|%t(0)>

I hope this helps...

Thanks for looking at this.

[JdGordon]

yep, OK, then I see what the problem is.

[JdGordon]

should be fixed in  r27956, so once that finishes building (3 min or so) please try it and let me know

[JdGordon]

woops, no that is almost certainly wrong

[JdGordon]

Yeah, this is a non-trivial fix. the issue is that we dont know which subline we want to draw based on the timeout untill we pick one and then calculate the conditionals so find the timeout.

So this is not fixed, ew, can you file a bug (I don't think there is one for this yet) although because it isnt trivial it probably wont be fixed any time soon.)

[audio-i]

Is this problem related or similar to FS#11542?

[JdGordon]

unrelated. that one is the timeout tag was being ignored, this one is that the subline chooser mechanism isnt smart enough to see that the line currently being displayed has been set to %t(0).

I'm not sure how to go about fixing this. I really dont want to conditionally check each subline for a %t buried inside conditionals.

[ew]

I will file a bug, but it will be a bit later today.  Thanks for looking into this.