Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Thank You for your continued support and contributions!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  How to upload bugfixes to an existing wps
« previous next »
  • Print
Pages: [1]

Author Topic: How to upload bugfixes to an existing wps  (Read 3671 times)

Offline heinrichh

  • Member
  • *
  • Posts: 16
How to upload bugfixes to an existing wps
« on: January 13, 2010, 01:26:06 AM »
This is my first post in this forum so let me first thank all the developers for this excellent program! Haven't ever seen a player whose operating system has these great properties. Crossfeed and the ability to change the speed while holding the pitch constant are outstanding features.

Recently I uploaded a corrected version of the classical_dark theme now compatible with Rockbox 3.4. Now I found an additional error in the wps (battery symbolizing) which I fixed. How can I upload the fixed parts of the wps to the wps gallery - or do I have to upload all again choosing a different name for the theme?

TIA

Heinrich
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: How to upload bugfixes to an existing wps
« Reply #1 on: January 13, 2010, 01:35:24 AM »
I tihnk you upload it with the same name, you might have to get one of the theme site admins to manually fix it though, I'm not sure.
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline BlastTyrant

  • Member
  • *
  • Posts: 14
Re: How to upload bugfixes to an existing wps
« Reply #2 on: January 13, 2010, 10:11:11 AM »
Get your updated theme ready for upload.

After that, when you submit your theme use the same information that you used previously for:
  • Theme name
  • Target device
  • Your real name
  • Your email address

After you hit the submit button it will bring you back to the theme upload page with a checkbox for replacing the old theme with the new one. Check the box and then add the zip file and screenshots again and re-submit it.

When that's completed you'll just have to do the email verification and the old theme will be replaced with the updated one.
Logged
2GB Fuze v1 + 8GB Transcend Class 6 microSD
1GB c240 v1 + 8GB Transcend Class 6 microSD

Offline heinrichh

  • Member
  • *
  • Posts: 16
Re: How to upload bugfixes to an existing wps
« Reply #3 on: January 14, 2010, 12:15:48 AM »
OK, I uploaded it with the same name (Classical_Dark for Ipod video), and it is now there, replaced the old one. The download count and voting results are reset however. Not shure if this is a feature or a bug.

While doing the email-verification I got the following error on top on the page:

Code: [Select]
Warning: rename(../private/themes/320x240/classical_dark/Classical_Dark.zip,/home/themes/www//themes/320x240/classical_dark/Classical_Dark.zip) [function.rename]: No such file or directory in /home/themes/private/themesite.class.php on line 380
Hope this may be of any help to the maintainers.

Thanks to all answerers!
Logged

Offline Domonoky

  • Developer
  • Member
  • *
  • Posts: 205
Re: How to upload bugfixes to an existing wps
« Reply #4 on: January 14, 2010, 01:28:44 PM »

The resetting of the download count and the votes is not a real bug. Technically your updated theme is treated as a new theme, and the old one is just hidden ( So we could restore it, if something goes wrong in the update process). Someday in the future i might have enough free time to change it, so download counters etc are copied on a update.

Thank you for telling me about the error message. Hopefully i just fixed that.  If there are any problems left, please tell me.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: How to upload bugfixes to an existing wps
« Reply #5 on: January 14, 2010, 02:22:13 PM »
If I voted for a theme, I wouldn't want my vote to continue to be counted after the theme updated - updates could include new features that have been implemented in Rockbox that change how I feel about the theme.

I'd rather just have to re-vote if the theme changes; I'll be downloading it again anyway if I want the changes to it and if I don't want or need the changes to it, I haven't voted for those unwanted changes. Suits me just fine.
Logged

Offline froggyman

  • Member
  • *
  • Posts: 214
Re: How to upload bugfixes to an existing wps
« Reply #6 on: January 14, 2010, 04:08:04 PM »
Quote from: Llorean on January 14, 2010, 02:22:13 PM
updates could include new features that have been implemented in Rockbox that change how I feel about the theme.


Should there maybe be a back-up/archive of the old themes, so they can still be downloaded if there is a change that someone doesn't like (maybe like a Custom status bar)?
Logged
iPod Video 5.5G 30GB - Now Dead :(
Sansa Fuzev2 4GB

"To prevent this day from getting worse, I'll just read ERROR as GOOD THING"

Offline GodEater

  • Member
  • *
  • Posts: 2829
Re: How to upload bugfixes to an existing wps
« Reply #7 on: January 14, 2010, 04:37:08 PM »
I take it you didn't read this bit of Domonoky's post then?

Quote from: Domonoky on January 14, 2010, 01:28:44 PM
Technically your updated theme is treated as a new theme, and the old one is just hidden ( So we could restore it, if something goes wrong in the update process).
Logged

Read The Manual Please

Offline froggyman

  • Member
  • *
  • Posts: 214
Re: How to upload bugfixes to an existing wps
« Reply #8 on: January 14, 2010, 04:46:47 PM »
Quote from: GodEater on January 14, 2010, 04:37:08 PM
I take it you didn't read this bit of Domonoky's post then?

Quote from: Domonoky on January 14, 2010, 01:28:44 PM
Technically your updated theme is treated as a new theme, and the old one is just hidden ( So we could restore it, if something goes wrong in the update process).

Whoops, overlooked that last part of his post, my bad. Also, I meant more of something along the lines of having a little "revision" button for the theme so an end user could easily use an older version of it if they choose to. Maybe right under the voting and rating stuff?
Logged
iPod Video 5.5G 30GB - Now Dead :(
Sansa Fuzev2 4GB

"To prevent this day from getting worse, I'll just read ERROR as GOOD THING"

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  How to upload bugfixes to an existing wps
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.116 seconds with 21 queries.