How to upload bugfixes to an existing wps

[heinrichh]

This is my first post in this forum so let me first thank all the developers for this excellent program! Haven't ever seen a player whose operating system has these great properties. Crossfeed and the ability to change the speed while holding the pitch constant are outstanding features.

Recently I uploaded a corrected version of the classical_dark theme now compatible with Rockbox 3.4. Now I found an additional error in the wps (battery symbolizing) which I fixed. How can I upload the fixed parts of the wps to the wps gallery - or do I have to upload all again choosing a different name for the theme?

TIA

Heinrich

[JdGordon]

I tihnk you upload it with the same name, you might have to get one of the theme site admins to manually fix it though, I'm not sure.

[BlastTyrant]

Get your updated theme ready for upload.

After that, when you submit your theme use the same information that you used previously for:

• Theme name
• Target device
• Your real name
• Your email address

After you hit the submit button it will bring you back to the theme upload page with a checkbox for replacing the old theme with the new one. Check the box and then add the zip file and screenshots again and re-submit it.

When that's completed you'll just have to do the email verification and the old theme will be replaced with the updated one.

[heinrichh]

OK, I uploaded it with the same name (Classical_Dark for Ipod video), and it is now there, replaced the old one. The download count and voting results are reset however. Not shure if this is a feature or a bug.

While doing the email-verification I got the following error on top on the page:

Code: [Select]

Warning: rename(../private/themes/320x240/classical_dark/Classical_Dark.zip,/home/themes/www//themes/320x240/classical_dark/Classical_Dark.zip) [function.rename]: No such file or directory in /home/themes/private/themesite.class.php on line 380
Hope this may be of any help to the maintainers.

Thanks to all answerers!

[Domonoky]

The resetting of the download count and the votes is not a real bug. Technically your updated theme is treated as a new theme, and the old one is just hidden ( So we could restore it, if something goes wrong in the update process). Someday in the future i might have enough free time to change it, so download counters etc are copied on a update.

Thank you for telling me about the error message. Hopefully i just fixed that.  If there are any problems left, please tell me.

[Llorean]

If I voted for a theme, I wouldn't want my vote to continue to be counted after the theme updated - updates could include new features that have been implemented in Rockbox that change how I feel about the theme.

I'd rather just have to re-vote if the theme changes; I'll be downloading it again anyway if I want the changes to it and if I don't want or need the changes to it, I haven't voted for those unwanted changes. Suits me just fine.

[froggyman]

updates could include new features that have been implemented in Rockbox that change how I feel about the theme.

Should there maybe be a back-up/archive of the old themes, so they can still be downloaded if there is a change that someone doesn't like (maybe like a Custom status bar)?

[GodEater]

I take it you didn't read this bit of Domonoky's post then?

Technically your updated theme is treated as a new theme, and the old one is just hidden ( So we could restore it, if something goes wrong in the update process).

[froggyman]

I take it you didn't read this bit of Domonoky's post then?

Technically your updated theme is treated as a new theme, and the old one is just hidden ( So we could restore it, if something goes wrong in the update process).

Whoops, overlooked that last part of his post, my bad. Also, I meant more of something along the lines of having a little "revision" button for the theme so an end user could easily use an older version of it if they choose to. Maybe right under the voting and rating stuff?