Ergonomics change for mpegplayer

[Vchat20]

So this has been sort of a minor nag to me and thought I'd bring it up as a proposal for a patch here.

Owning an e200 and having the videos default to landscape mode, the layout of the buttons (up=FFW, down=RW, left=play/pause) is just a tad out of whack. And I am sure a number of other players are the same way that have portrait oriented screens.

Even Microsoft's Zune player corrects this during video playback.

A patch would be pretty simple and something I could whip up in short order. But comes down to if it would be a welcome addition by the masses? I know having the 'new' button usage would probably confuse newbies a bit especially with labelled buttons on the players, but it would otherwise be more 'ergonomic' if you can call it that.

Lemme know your thoughts.

[MajiKool Dragonâ„¢]

i think this would be a great idea.
this has bugged me for the longest time and i would love it if someone would fix it.

[Chronon]

Yes, please do submit a patch. I don't use my Sansa for video but such a change certainly sounds sensible.

[Hillshum]

One doesn't need to know C to change a keymap really. You need to be able to compile rockbox though. There's a few plugin keymaps that really bug me so I might post a patch soon.

Are plugin keymaps open for change?

[AlexP]

Are plugin keymaps open for change?

They are open to discussion   In the MPEGPlayer case I don't think there would be much of a discussion needed - it seems like a good idea to me.

[Vchat20]

Sorry for the delayed response. I apparently don't have email notifications set up. x.x

In any case, I have already made the modification on my player and it's working fine and much less ugly than the stock control config. On a positive point, the structure of mpegplayer has the controls for the menu and playback separate so the controls can be 'rotated' while playing a video and return to normal when going to the menu to change the plugin's settings.

I have posted the current patch I have here: http://www.rockbox.org/tracker/task/10210 It's for the Sansa e200v1 only and has no menu toggle so the change is permanent. The menu toggle (if anyone actually wants the feature. I don't care. The change is much better. ) would have to be added by someone with more programming skills than I. And the addition of more players can be freely added by anyone who owns them or just offer up a detailed explanation of the playback orientation of your player and how the controls are set up so I can patch them accordingly as well (of course, if those players need the change. Seems to be targets with portrait oriented LCDs here.).

[Chronon]

Thanks!  I think it's appropriate that it's for e200v1 only right now.  The Gigabeat (the only other target with a portrait oriented LCD right now) already makes this adjustment.  The Gigabeat has no menu toggle either, so your change seems consistent with that.

I'll give it a play when I have some time, but I would think this will get accepted without much delay.