320x240 (ipod video) fixed some broken themes

[ASNO]

let me know if youre interested







more tomorrow...

[JdGordon]

the wiki is free for all to edit... why not just upload your fixed versions?

[yceberko]

thanks your greatly appreciated!!!
I use mainly phk1 and oher phk's it would be ex helpful if you could fix those

[Slim]

Can someone tell me what the pb values in the OLD format represent? For example here:

 %pb|11|2|318|

.. what do the numbers mean? I'd rather work out the new values from the old than by trial and error

Cheers
Slim

[ASNO]

Can someone tell me what the pb values in the OLD format represent?

the old seems to be "|height|x|width|y|" but i'm not 100% sure. i tweak it form there if its not right.

the wiki is free for all to edit... why not just upload your fixed versions?

if someone wants to give me write privileges...

[jswetzen]

The old format was:
%pb|height|left-position|right-position|y-position(optional)|

and the new one is:
%pb|filename.bmp|x|y|width|height|

which means that:
x = left-position
y = y-position
width = right-position - left-position
height = height

Unfortunately in your case there is no y-position so you will have to experiment on that one.

[pixelma]

Unfortunately in your case there is no y-position so you will have to experiment on that one.

The y-position was given by the line the %pb tag was on, if you didn't specify a number. This is still the case in the new format but you can not just skip it as you did before but have to use a - instead (at least I know that it works with a plain progressbar that doesn't use a bitmap but should work there too). Also look out for the %P tag which listed the filename of the progressbar bitmap before (between the | ) and which is now merged into the one %pb tag.

[Slim]

Thanks for the help, everyone - tres useful

[Chronon]

if someone wants to give me write privileges...

If you haven't gotten it yet you can either post your WikiName here or come into the IRC channel and ask there.

[ASNO]

If you haven't gotten it yet you can either post your WikiName here or come into the IRC channel and ask there.

KarlMarx

here are some more i fixed:

I use mainly phk1 and oher phk's it would be ex helpful if you could fix those

i tried.... they were too complex

[soap]

I deleted the post which offered a modified version of a PHK wps, as it (said WPS) is copyright All Rights Reserved (this means no shared modifications).

This may not be the ideal intended by PHK, but it is the law.  He has no license expressly mentioned in his themes. 

This is a perfect example of why all WPS authors need to be explicit about the license they release their works under.

Feel free to discuss how to fix any specific WPS, but no more sharing of WPS files you do not have rights to.

[BdN3504]

how to fix any specific WPS

phk1:
you need to delete the %P line in and replace it with this: %pb|pb.bmp|2|113|316|13|. but you will need to replace the line which contained the old %pb with a free line, too or the wps looks weird.
Just replace the old %pb line with this one %pb|pb.bmp|2|113|316|13| and delete the %P line.
Also, with phk's themes it's best to put the %X and %pb on the very end of the code, because he doesn't use Viewports. phk uses a now outdated font, so you may want to change that in the .cfg file to "nimbus-14.fnt"

phk2:
same as phk1.

phkamp:
pretty much the same as phk1 except for %pb|pb.bmp|13|172|294|10|

i will now only post the needed %pb tags because the same procedure applies to every wps:

phkguitar:
%pb|pb.bmp|92|59|162|6|

phkosc:
%pb|pb.bmp|7|55|308|25|
Additionally, there is a typo in the %xl tags. change batplug.bmp to battplug.bmp

phkosctah:
%pb|pb.bmp|7|55|308|25|
Additionally, there is a typo in the %xl tags. change batplug.bmp to battplug.bmp

phkTape_standard
phktapea_std, phktapeb_std phktapec_std:
%pb|pb.bmp|97|63|71|25|
On this one, you also might want to edit the pb.bmp yourself, because the original is too long. if you use the tag i've provided, it shall work anyway but it's nicer to have smaller files and cleaner programming, if you create files that you actually use 100% and just 75% or so. the original pb.bmp is (114x25)px you need a bmp which has the following dimensions: (71x25)px.


phktv:
%pb|pb.bmp|23|209|232|13|
Similar to tape: The pb.bmp provided is 320px in width, you only need 232px width.

phkVH:
%pb|pb.bmp|2|210|316|13|
If you can use photoshop a little, open the pb.bmp and free transform it so it's 13px high, instead of 12px.

that's all folks, you should now all be able to fix phks complicated themes yourself. good luck!

[pixelma]

...
you need to delete the %P line in and replace it with this: %pb|pb.bmp|2|113|316|13|. but you will need to replace the line which contained the old %pb with a free line, too or the wps looks weird.

Why not replace the old %pb line with the new %pb line? Then you only need to delete the %P tag line and you are done.

[BdN3504]

errrrm, yes you could also go the less complicated way... 
thanks

[soap]

Thank you BdN3504. 
I wasn't trying to be a jerk, but Rockbox needs to honour copyright.