Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  New changes affected WPS themes?
« previous next »
  • Print
Pages: [1]

Author Topic: New changes affected WPS themes?  (Read 6263 times)

Offline PHK Brasil

  • Artist
  • Member
  • *
  • Posts: 132
  • phkTAPE theme
    • Comunidade Rockbox iPod no Orkut
New changes affected WPS themes?
« on: May 09, 2007, 05:41:53 PM »
♪
I noticed that now, the way the volume dB scale acts with the WPS theme is different than before.

Now, the maximum volume bitmap is showed from 0dB ~ +6dB. While before, it was showed just at +6dB.

I'm not shure, but I think that the relation with the battery bmps also changed. Anyone could say? I hope not, but if is true, it needs some fix in the battery bmps code on some WPS themes.:(
♪
« Last Edit: May 09, 2007, 10:41:57 PM by PHK Brasil »
Logged
SORRY ABOUT MY ENGLISH

COMUNIDADE ROCKBOX IPOD no ORKUT http://www.orkut.com/Community.aspx?cmm=24876869
 TUTORIAL ILUSTRADO ROCKBOX EM PORTUGUÊS: http://tinyurl.com/37u8jf

Offline NicolasP

  • Developer
  • Member
  • *
  • Posts: 195
Re: New changes affected WPS themes?
« Reply #1 on: May 10, 2007, 03:49:41 PM »
This isn't a bug, it's a choice. It needs to be discussed because not everyone feels the need for a specific "full" enum case.
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: New changes affected WPS themes?
« Reply #2 on: May 10, 2007, 04:50:57 PM »
In my personal opinion, there needs to be one image for 0dB, and one for anything over 0dB. Then divide up the area below 0dB as you see fit, down to "Mute" which again needs its own image.

On graphical volume displays a user should be able to see when they're going to be clipping.
Logged

Offline PHK Brasil

  • Artist
  • Member
  • *
  • Posts: 132
  • phkTAPE theme
    • Comunidade Rockbox iPod no Orkut
Re: New changes affected WPS themes?
« Reply #3 on: May 10, 2007, 05:04:54 PM »
♪
I really think the old way was better to work. They had more flexibility. I made themes that display a specific bmp just at +6dB, and now they don't have the same effect anymore.

Also, the old way allows to work exactly like the new way, too. Simply repeating the same bitmap on the WPS code, will display the same last image from xdB ~ +6dB. So, why change?  

I vote for the old way.

PS: The battery relation also changed too. :(  
♪

[EDIT]
Quote from: Llorean on May 10, 2007, 04:50:57 PM
In my personal opinion, there needs to be one image for 0dB, and one for anything over 0dB. Then divide up the area below 0dB as you see fit, down to "Mute" which again needs its own image.

On graphical volume displays a user should be able to see when they're going to be clipping.

To get a point of bitmap change exactly at 0dB, needs to have an specific WPS Volume section. It will depends of the amount of the Volume bitmaps the theme was created.

On the new builds the 0dB got this point, and must have 10 bmps for the Volume. If you have 9 bmps for the Volume, the point becames to -1dB.
« Last Edit: May 11, 2007, 12:19:11 AM by PHK Brasil »
Logged
SORRY ABOUT MY ENGLISH

COMUNIDADE ROCKBOX IPOD no ORKUT http://www.orkut.com/Community.aspx?cmm=24876869
 TUTORIAL ILUSTRADO ROCKBOX EM PORTUGUÊS: http://tinyurl.com/37u8jf

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: New changes affected WPS themes?
« Reply #4 on: May 10, 2007, 08:35:34 PM »
Yes, and in my opinion the current way needs to be improved to the way I suggest.

0dB is a very important volume level, as anything over it can clip. So there needs to be an image specifically for 0dB, and probably at least one image for above it, as a warning that you may experience clipping.

0dB is also line level, important for those players that do not have a separate line output, or that do but do not lock to line level (h100)
Logged

Offline PHK Brasil

  • Artist
  • Member
  • *
  • Posts: 132
  • phkTAPE theme
    • Comunidade Rockbox iPod no Orkut
Re: New changes affected WPS themes?
« Reply #5 on: May 11, 2007, 01:29:56 AM »
♪
OK, I had an idea. And I think the current way must be keeped the way it is. Definitively, please. ;)

Is more easy to improve accuracy to the themes in their codes itself. So, I will can display a specific bitmap wherever I want.

I will just recode my WPS the following way:


VOLUME code will be divided in 65 degrees (-58dB ~ +6dB = 65 "degrees")

BATTERY code will be divided in 101 degrees (0% ~ 100% = 101 "degrees")


Of course, I'm not saying that I'll make one bitmap for each degree. I'll just keep the same bitmaps, repeating them on the codes. And wherever I want to change the bitmap, I can.

For example, in Volume code:

%?pv<%xda|%xda|%xda|%xda|%xda|%xda|%xdb|%xdb|%xdb|%xdb|%xdb|%xdb|%xdc|%xdc| %xdc|%xdc|%xdc|%xdc|%xdd|%xdd|%xdd|%xdd|%xdd|%xdd|%xde|%xde|%xde|%xde|%xde| %xde|%xdf|%xdf|%xdf|%xdf|%xdf|%xdf|%xdf|%xdg|%xdg|%xdg|%xdg|%xdg|%xdg|%xdg| %xdh|%xdh|%xdh|%xdh|%xdh|%xdh|%xdh|%xdi|%xdi|%xdi|%xdi|%xdi|%xdi|%xdi|%xdZ| %xdj|%xdj|%xdj|%xdj|%xdj|%xdY>

(edit by NicolasP: I allowed myself to add a few spaces to make that line wrap)

%xdZ is exactly the 0dB position.

%xdY is exactly the +6dB position.


Just one important question for the developers:

The way I wrote the code will increase battery comsumption? I know that the bitmap will not change at every dB, but the code will send a command at each dB step, repeating the same bitmap.
 
So ? ? ? ?


 
« Last Edit: May 13, 2007, 11:23:43 AM by NicolasP »
Logged
SORRY ABOUT MY ENGLISH

COMUNIDADE ROCKBOX IPOD no ORKUT http://www.orkut.com/Community.aspx?cmm=24876869
 TUTORIAL ILUSTRADO ROCKBOX EM PORTUGUÊS: http://tinyurl.com/37u8jf

Offline NicolasP

  • Developer
  • Member
  • *
  • Posts: 195
Re: New changes affected WPS themes?
« Reply #6 on: May 13, 2007, 11:27:57 AM »
I think Llorean's idea could be quite simple to implement. I'll try to have a go at it.

EDIT: OK it's done: FS#7164.


Quote from: PHK Brasil on May 11, 2007, 01:29:56 AM
Just one important question for the developers:

The way I wrote the code will increase battery comsumption? I know that the bitmap will not change at every dB, but the code will send a command at each dB step, repeating the same bitmap.
 
So ? ? ? ?
Writing it that way shouldn't cause any more noticeable battery consumption, but it could cause problems with the maximum number of tokens in a complex WPS.
« Last Edit: May 13, 2007, 12:14:03 PM by NicolasP »
Logged

Offline NicolasP

  • Developer
  • Member
  • *
  • Posts: 195
Re: New changes affected WPS themes?
« Reply #7 on: May 14, 2007, 12:36:08 PM »
I committed the patch implementing Llorean's request. Please tell me how you like it ! :)
Logged

  • Print
Pages: [1]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  Theming and Appearance Customization
| | |-+  New changes affected WPS themes?
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.093 seconds with 21 queries.