Rockbox Technical Forums

Support and General Use => User Interface and Voice => Topic started by: Dwyloc on August 22, 2006, 05:47:14 AM

Title: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 05:47:14 AM
The following change now makes makes rockbox virtually unusable for listening to audio books "directory navigation in wps works as before (short then long next/prev)" as I can no longer seek backwards and forwards looking for the part of the book I wish to listen to without changing directory and loosing my place all together.  It also tends to result in skipping to the different directory if I bump the controls on my iRiver while it’s clipped to my belt.

Would it be possible to revert to the previous much more usable key mapping that prevents accidental directory skipping or have a menu option to disable directory skipping please?
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Llorean on August 22, 2006, 05:54:46 AM
I would suggest filing this as a bug report (call the part where short + long while trying to seek more than once causes directory skips a bug).
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: LinusN on August 22, 2006, 05:59:09 AM
I just tried to quickly seek back and forward in a file, and I can't make it change directory by mistake.

BTW, how did you manage before we accidentally removed the feature a few days ago?
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 06:40:31 AM
I think the problem is that I am seeking backwards and forwards in 8 hour or longer mp3’s and it is quite easy to change directory when you are trying to find the exact part of the book you want.

I used to always try and create bookmarks before every few minuets as that way when I lost place when I shipped directory by accident I could at least find the right general part of the book without searching for to long.

I am quite happy to admit that it may just be me who is being clumsy and as such will just have to learn to live with it.
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: JdGordon on August 22, 2006, 07:01:34 AM
hmm... this is odd. ive just tested it on my h300 and i can ffwd/rewind in a track with no problems but it seems to freeze up when i try changing directories...
Linus: you sure dir change works fine on the x5? it might just be a keymap problem if it does...

Also, you shold use hold if its on your beltclip...

edit: no now its working fine... i guess its a bit tempremental
edit 2: ok, all i can guess is that it will crash if dircache isnt finished initing yet, or something... it works fine after about 30s.. before that and it will crash
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 07:20:55 AM
hmm... this is odd. ive just tested it on my h300 and i can ffwd/rewind in a track with no problems but it seems to freeze up when i try changing directories...

Could my problems be related to the fact that I have changed the ff/RW Min step to 30 seconds?

Also, you shold use hold if its on your beltclip...

Sadly hold is off no use to me as it dose not allow me to pause and play again without switching hold off again.  I use my player at work when I am installing computers and moving servers around to listen to audio books but I have to be able to pause whatever I am listening to quickly so I can answers peoples questions or answer the phone without losing my place.

For me at least the hold button is only of use to stop my players from switching on in my pocket or bag.  The problem is that flicking the hold is just toa hard to do one handed without looking while your player is clipped to your belt (I have the same problem with both my nano and my h140).
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: JdGordon on August 22, 2006, 07:32:05 AM
Could my problems be related to the fact that I have changed the ff/RW Min step to 30 seconds?
no, i just checked this.. works fine here
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 11:10:12 AM
no, i just checked this.. works fine here

I guess I am just far to clumsy to use rockbox I can’t seem to work the controls if I try to skip back a track then fast forward to the bit I wish to listen too I always now seem to skip out of the directory. I then need to skip back in to the directory and skip through between 10 and 50 tracks then fast forward to the part of the mp3 I wish to listen to without skipping directory again in the process.  :'(

On the positive side I don’t seem to be the only person who find it hard to predict what will happen when I try this as a few other people in the office here have tried it and agree that it is quite hard to use the controls as they are now.   ???

The general consensus (here at least) seem to be that the previous method of holding down play and pressing left or right was a lot easer to use.  Plus it’s just as easy to work the player with one hand buy holding play with your first finger and controlling the joystick with your thumb. 

As such I can’t see any point in over loading the joystick with so many key combo’s it feels like trying to achieve the right joypad tap combo to pull off a special move in a 16 bit games consol beat'em up game from the 90’s  :)
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: LinusN on August 22, 2006, 11:50:40 AM
I guess I am just far to clumsy to use rockbox I can’t seem to work the controls if I try to skip back a track then fast forward to the bit I wish to listen too I always now seem to skip out of the directory.
Now we are getting somewhere. All of a sudden you mention that you actually skipped tracks as well. You didn't tell us anything about skipping in your first post.

The fact that you managed to skip a directory when doing a short-left and long-right must be a bug. I'll try to do that on my player.

Quote
On the positive side I don’t seem to be the only person who find it hard to predict what will happen when I try this as a few other people in the office here have tried it and agree that it is quite hard to use the controls as they are now.   ???

...and as they have been for months and months until a week ago. Why haven't you complained about this until now?

Quote
The general consensus (here at least) seem to be that the previous method of holding down play and pressing left or right was a lot easer to use.  Plus it’s just as easy to work the player with one hand buy holding play with your first finger and controlling the joystick with your thumb.
...if you are left handed.

Quote

As such I can’t see any point in over loading the joystick with so many key combo’s it feels like trying to achieve the right joypad tap combo to pull off a special move in a 16 bit games consol beat'em up game from the 90’s  :)
I think we should avoid two-button combinations, as they are hard to use with one hand.

Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 12:18:58 PM
The fact that you managed to skip a directory when doing a short-left and long-right must be a bug. I'll try to do that on my player.

I think it may just be the combination of my player getting a bit old and the standard iRiver h140 case getting in the way of the joypad.

...if you are left handed.

I am right handed and am holding the player in my palm of my right hand with my thumb on the joypad and using my first finger to press the controls buttons right hand side of the player.
 
As such I can’t see any point in over loading the joystick with so many key combo’s it feels like trying to achieve the right joypad tap combo to pull off a special move in a 16 bit games consol beat'em up game from the 90’s  :)
I think we should avoid two-button combinations, as they are hard to use with one hand.

For me at least it is a lot harder to deal with multi press combos that rely on timing then just hold down play and press the joypad in a direction.
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: LinusN on August 22, 2006, 12:32:33 PM
I think it may just be the combination of my player getting a bit old and the standard iRiver h140 case getting in the way of the joypad.
Strange...

Quote
I am right handed and am holding the player in my palm of my right hand with my thumb on the joypad and using my first finger to press the controls buttons right hand side of the player.
Hehe, when I hold it in my palm, I can't bend my index finger enough to reach any of those buttons. Did you really mean you have it in your *palm*?

Quote
For me at least it is a lot harder to deal with multi press combos that rely on timing then just hold down play and press the joypad in a direction.
Fair enough. I repeat my question: how come you haven't discovered this problem until now? We've had this joystick combination since the beginning of this year. There must be something different about it now, like different timing or something like that.
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Jillorious on August 22, 2006, 02:00:02 PM
I am right handed and am holding the player in my palm of my right hand with my thumb on the joypad and using my first finger to press the controls buttons right hand side of the player.
Hehe, when I hold it in my palm, I can't bend my index finger enough to reach any of those buttons. Did you really mean you have it in your *palm*?
What he probably ment was that he's holding it ON his last 3 fingers, and he placed his index finger on the right side of the device [at least, thats the way I used to do it back then when I had a H140 (now I own a H340)] - give it a try, it shouldn't be that difficult.
But if you feel that your player isn't safe enough this way, you might try this way (which is more complicated, but gives you a better grip): keep the player in your palm with your thumb ON THE PLAY BUTTON, and control the joypad with your midle finger - which should be rapped around the player from the bottom (might be VERY difficult with small hands).
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Mikerman on August 22, 2006, 03:58:31 PM
Quote
The general consensus (here at least) seem to be that the previous method of holding down play and pressing left or right was a lot easer to use.  Plus it’s just as easy to work the player with one hand buy holding play with your first finger and controlling the joystick with your thumb.

I find the 2-key combinations harder to use.  If my player is in front of me on my desk or in the car, or on my belt, it is much harder, or dangerous, to do a 2-button manuever such as that here than a simple short + long click left/right.
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: snowgoon on August 22, 2006, 05:23:42 PM

I believe seeking backwards is broken in long files since 31/07.  Try this, play a long file until buffer wraps (twice to be sure), then seek backwards to a point that is no longer in the buffer.  This broke for me with flac, mp3 and mpc (seek to start).  I have written a patch and will submit it asap, eg. tomorrow.
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 06:14:29 PM
Fair enough. I repeat my question: how come you haven't discovered this problem until now? We've had this joystick combination since the beginning of this year. There must be something different about it now, like different timing or something like that.


For me until very recently the new playback code had a tendance to lockup if I did too much seeking or skipping around a lot but thanks to all the hard work everyone did during the feature freeze that problem is now fixed. 

So I tended to use an old build with the old playback code when ever I wanted to listen to audio books and do quite a lot of seeking.  I guess if was just luck on my part that the builds with the new play back code also happened to have a feature I always wanted to disable broken.
 
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 06:22:19 PM
Yes you description of how I hold the player is better than my own.

I have quite small hands but only the bottom right hand corner of my h140 player is sitting in sitting against the palm of my hand but as my smallest finger and next two fingers are gripping my player I don’t feel in any danger of dropping my player.
Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 06:34:25 PM
Quote
The general consensus (here at least) seem to be that the previous method of holding down play and pressing left or right was a lot easer to use.  Plus it’s just as easy to work the player with one hand buy holding play with your first finger and controlling the joystick with your thumb.

I find the 2-key combinations harder to use.  If my player is in front of me on my desk or in the car, or on my belt, it is much harder, or dangerous, to do a 2-button manuever such as that here than a simple short + long click left/right.


I guess in my case the real issue is that I never want to change directories then playing back audio books, as when this happens when I am driving I have to pull the car over to safely fix the problem.

But I do want to be able to change directories when listening to music ever now and again but I tend to do this from the directory screen not the while playing screen.


Title: Re: Short then long next/prev dir skip "feature" making current builds unusable.
Post by: Dwyloc on August 22, 2006, 06:54:42 PM

I believe seeking backwards is broken in long files since 31/07.  Try this, play a long file until buffer wraps (twice to be sure), then seek backwards to a point that is no longer in the buffer.  This broke for me with flac, mp3 and mpc (seek to start).  I have written a patch and will submit it asap, eg. tomorrow.

After reading your bug description if sounds like I am seeing two different problems and assuming they are both the same thing.

Firstly I experienced the bug you describe and then secondly I think I have been having problems with the key mapping issue then I tried to recreate the problem thanks everyone for helping me to get a better idea of what the real problem is.

I will wait for your fix see how much it helps.

I think I will also see about making a request for some sort of configurable study mode as well, a bit like the part mode but with the following configurable features.

-   Switching off the key tapping directory change feature.
-   Using the short long key press combo to set and cancel A – B seeks points and the record button to start playback from you’re A – B repeat point.
-   Switching on hold disables all key presses with the exception of pause so you can still pause and resume playback if you switch on.
-   Rewinding past the beginning of the current file returns to the previous file and continues seeking backwards from the end of the previous file.
-   Audio playback while seeking.