Rockbox Technical Forums

Support and General Use => User Interface and Voice => Topic started by: JdGordon on June 16, 2009, 01:44:43 AM

Title: how do you feel about splashes which you can dismiss?
Post by: JdGordon on June 16, 2009, 01:44:43 AM
note to self... dont get into arguments when overtired...
Title: Re: how do you feel about splashes which you can dismiss?
Post by: Llorean on June 16, 2009, 01:49:35 AM
Just a note - 4 is unlikely to lead to accidental button presses unless you're in the habit of pressing a button several times when you meant to only press it once.

2 and 3, on the other hand, will lead to people trying to dismiss splashes, only to have them disappear right before they tried to press the button, which will lead to accidental button presses. I think you got that footnote mixed up.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: gevaerts on June 16, 2009, 03:52:16 AM
I mostly like the way splashes behave now.

* I don't want to have to press buttons to make them go away in a reasonable time
* I don't think 3s or 4s is a reasonable time to wait for "normal" splashes
* Allowing variable-length splashes to be dismissed is going to lead to accidental button presses

Also, insulting people who disagree with isn't going to make you many friends.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: pixelma on June 16, 2009, 04:46:05 AM
I'm with gevaerts on all points.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: nls on June 16, 2009, 06:44:39 AM
I like the idea of being able to dismiss splashes but maybe we should couple the timeout with some kind of visual indication. Or y'know just make it configurable ;) maybe the following options?
* timeout after X seconds (no dsimissal)
* timeout after X seconds (early dismissal possible)
* don't timeout, wait for user to dismiss (with helpful "press <button> to close" of course)

X could be settable too...
Title: Re: how do you feel about splashes which you can dismiss?
Post by: linuxstb on June 16, 2009, 10:39:29 AM
Just my "+1" to add to gevaerts and pixelma.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: rasher on June 16, 2009, 10:46:02 AM
I'm basically with gevaerts, but a visual indication on splashes wouldn't hurt, I guess. Make the bottom line be 3px high, which then gets removed to being 1px high, during the lifetime of the splash.

That's just eyecandy though, and I don't really like the idea of dismissable splashes.

I also don't like getting insulted.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: AlexP on June 16, 2009, 03:24:34 PM

So if you're not a brain dead monkey you probably find the splashes throughout rockbox to be annoying to some degree....
here are the options:
1) do nothing, leave it how it is and keep being annoyed

This is just bloody stupid.  Why do you feel the need to insult people that don't agree with you?  Ridiculous.

As for the splashes, I agree with gevaerts and all - although a fixed length for splashes would be good.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: Llorean on June 16, 2009, 04:03:46 PM
I think a fixed length is a somewhat bad idea. Some splashes have more text than others - this generally means they need to stay up longer for voicing (and to give people the ability to read them).

Having single-word splashes need to be displayed the same amount of time as the longest splash is probably unnecessary.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: AlexP on June 16, 2009, 04:37:38 PM
I think a fixed length is a somewhat bad idea. Some splashes have more text than others - this generally means they need to stay up longer for voicing (and to give people the ability to read them).

Having single-word splashes need to be displayed the same amount of time as the longest splash is probably unnecessary.

Yes, this is a good point.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: JdGordon on June 16, 2009, 04:52:35 PM
My argument against varying splash timeouts is that currentlys there is no way blind users will know when the splash has gone, if there is a consistant time they are at least more likely to guess when its gone.
Also, the timeouts are completely arbitrary... they rang from .5s to 5s, and its entirely up to whoever added it to choose a number (which may or may not be enough to read/voice the splash).

Also, just because its a single short word in english, doesn't mean it is in all languages... shuffle in german is the usual example... 15 syllables*(maybe exaggerated).

the other point is, splash placement again is completly arbitrary.... *someone* thought it would be a good idea, and they usually are the first time you come across them, but they are not needed after a while.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: gevaerts on June 16, 2009, 05:29:12 PM
My argument against varying splash timeouts is that currentlys there is no way blind users will know when the splash has gone, if there is a consistant time they are at least more likely to guess when its gone.

I think that if a splash is spoken, it should probably last exactly as long as the spoken text.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: JdGordon on June 16, 2009, 05:30:49 PM
which leads to fun problems when playback is paused. Also, I dont  even know if its possible to know when a voice smaple is finished talking
Title: Re: how do you feel about splashes which you can dismiss?
Post by: Llorean on June 16, 2009, 05:40:53 PM
Well, if you wanted to get complex, you could assign each string a value to carry the number of syllables (with spaces possibly counting as one syllable each as well) then just compute the amount of time to display a splash at runtime based on the number of syllables in the string times a set amount of time picked as an average syllable pronunciation time.\

Of course this flies in the exact opposite direction of "reducing complexity."
Title: Re: how do you feel about splashes which you can dismiss?
Post by: GodEater on June 17, 2009, 02:29:25 AM
+1 to gevaerts, pixelma et al.
Title: Re: how do you feel about splashes which you can dismiss?
Post by: pondlife on June 17, 2009, 02:45:45 AM
I think that all splashes should be dismissable with any button, but that the button press should not be "eaten" - i.e. the user can just carry on regardless of the splash being displayed/voiced. 

Yes - they might "ignore" the splash, but they're quite able to do that anyway now...

pondlife
Title: Re: how do you feel about splashes which you can dismiss?
Post by: Llorean on June 17, 2009, 02:58:30 AM
So, basically, if the "Cancelled" splash comes up when you exit a menu, you can just press "Play" and resume playback AND dismiss the splash with a single button press?

Seems reasonable to me, people may accidentally dismiss splashes but since they were going somewhere specific anyway they probably didn't care much about the splash in the first place (if they were even still looking at the screen by this point).
Title: Re: how do you feel about splashes which you can dismiss?
Post by: pondlife on June 17, 2009, 06:33:47 AM
A patch to do this is up now at http://www.rockbox.org/tracker/task/10322 - see dismiss_splash_090617a.patch.

it might be too sensitive for scrollwheel users, but I'll await feedback before proceeding.

pondlife