Rockbox Technical Forums

Support and General Use => Theming and Appearance Customization => Topic started by: FuzzplugJones on November 19, 2007, 11:15:07 AM

Title: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: FuzzplugJones on November 19, 2007, 11:15:07 AM
After about six months without my H10 (the battery died, finally was able to replace it), I loaded Saturday's daily build of RB on the thing and was happily surprised at all the new stuff!  However, most of the themes in the WPS Gallery don't seem to work anymore.  I'd like to finally use one that supports Album Art, as I see that's now included in the newest builds (thank you), but when I select a WPS that has AA support, my WPS changes back to the RB default screen (the plain text and the meters).

The wording in the gallery is confusing... first the themes say "Get the required build," which takes me to a page with a build from last year.  Then they say "IMPORTANT: Requires updates with latest builds!  See the Album Art page" on the wiki.  The wiki page seems to have information for developers.  Does it mean I have to "fix" these WPSes myself?  And why would I have to do that?

I have tried the themes: ZenPod Vision M, ZenPod V4 Color WPS Themes, ZenPod V5, and Clix Theme for X5.  I know I'm not supposed to run "patched" versions anymore but how come none of the AA-enabled themes work?

Thanks
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: LambdaCalculus on November 19, 2007, 11:23:17 AM
Most of the themes that support Album Art have to be fixed up to properly comply with the new Album Art and Margins support. Those themes were made for unsupported builds.

If you're feeling daring, maybe you may want to have a go at modifying a couple of them. Here's some instructions:

http://www.rockbox.org/twiki/bin/view/Main/MoreRecentChanges?topic=CustomWPS

Just grab your favorite text editor and go for it.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: FuzzplugJones on November 19, 2007, 11:29:36 AM
I'm just wondering why this falls to me.  Somebody should fix them properly and re-upload them.  Maybe the developers of the WPSs?
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: GodEater on November 19, 2007, 11:46:19 AM
How do you propose to tell them they need fixing ?
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: FuzzplugJones on November 19, 2007, 12:18:11 PM
Well there's no need to be snarky, I didn't jump to the conclusion we had drive-by skinners, that's all.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: Chronon on November 19, 2007, 12:42:10 PM
I don't think that was snarky.  Regarding "drive-by skinners" it's just not wise to count on the creator of a given theme to make the desired changes on any particular time frame.  There is a whole list of reasons that may delay or prevent the creator of a given theme from making the changes that you want.

You say that "somebody" should fix them.  That somebody could very well be you.  This is a community effort and anyone who wants to help is wholeheartedly welcome to do so.  Pointing at something that you feel needs to be done and just saying "someone else should take care of that" could be seen by some as expressing some feeling of entitlement.  

I'm sure that the themes will be updated.  But it will take time.  We can all speed this up by updating the wiki with updated WPS code.  I have seen some users already in the process of updating themes for their respective players.

The recent changes in WPS related code include the inclusion of Album Art and new scrolling margins tags.  I have found that it's mostly the scrolling-margins related tags that have caused problems in my themes due to a change in syntax from the original scrolling-margins patch.  Themes that only required the Album Art tags seem to mostly work (except for those with dynamic tags on the same line as the album art).  I have edited some of the (Gigabeat) themes with (scrolling) margins to work with the new syntax and I will update these when I have the time.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: FuzzplugJones on November 19, 2007, 12:49:10 PM
Definitely was snarky, as I said I assumed WPS developers were here and active; your gallery clearly states that I cannot upload someone else's stuff and so clearly I/you/anyone cannot fix these things for the benefit of the community.  Please don't be like so many open source projects where the answer to everything is "fix it yourself" when someone might be coming in here wondering if it's already somebody's job and the desire is not to reinvent the wheel.  I'm inside a WPS right now in a text editor and adding %Cl and %C with the proper options doesn't fix it either, rockboxui --debugwps doesn't output anything, and I'm basically lost.  I also assumed mistakenly that there were already working WPSs with AA support since it had been coded into RB and theoretically somebody had to test it.  I incorrectly assumed that I could take advantage of the new code without becoming a developer myself.

So I'll see if I can fix this but as I said, not even the development tools are working properly.  I don't know C so sadly someone else WILL have to fix that.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: Chronon on November 19, 2007, 01:06:29 PM
I could also call your "drive-by skinners" comment snarky, but that doesn't get us anywhere useful, does it?

Many of the themes are published with open licenses and can be modified by anyone.  If the license is not known then modification would be a violation of the creator's copyright.  Don't take someone else's theme and publish it.  That's a copyright violation.  But a theme published under an open license may certainly be updated or modified under the terms of the license.  Someone correct me if I am misinterpreting somehow.

Core developers sign themselves up for certain things.  But themes are not even really a part of Rockbox.  They are user contributed add-ons.  As such there's no formal concurrent versioning or anything of that sort for them.  If you make some changes then contribute them back, if allowed.  And really, modifying a couple of tags isn't that much work.  I have never actually used --debugwps in rockboxui, so I don't have any comment on that.  The developers might be interested in that.

Now, as I said in my post, it's most likely not the album art tags at all that are causing you problems as the syntax for those tags has not changed between the old patch and what is now in SVN.  The syntax for the scrolling margins tags has changed a bit, so themes that used the old scrolling-margins patch will not work currently without updating the syntax to comply with the currently supported tags (search your WPS code for %s and %m).  That has been my experience with getting many themes to display properly on my Gigabeat.

Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: FuzzplugJones on November 19, 2007, 01:10:50 PM
In this particular one, it seems to be the %e tag that's causing the skin to fail.  Trying to research that, however this forum doesn't let me search for "%e," it instead returns every forum post with at least one "e" in it.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: Chronon on November 19, 2007, 01:15:19 PM
That tag is not supported in SVN.  You still need a patched build for that.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: FuzzplugJones on November 19, 2007, 01:16:27 PM
I'm aware of that, however I don't know what it does and cannot therefore do not know how to remedy it (if I comment out all the lines with an %e I get a blank screen with a progress bar).
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: Chronon on November 19, 2007, 01:22:58 PM
Hmm.. sorry, I don't really have any knowledge of that tag.  Look up the patch on the patch tracker and it will give you the usage.  It could potentially be difficult to disentangle it from the WPS code.  Also, if there's a discussion thread for the theme in question you should post there.  We don't provide support for patches in the forums.

To make use of the new funtionality in SVN you should look for themes that only require album art and scrolling (left) margins.
Title: Re: Themes using Album Art don't work in RB on iRiver H10 20GB
Post by: PaulPosition on November 19, 2007, 02:29:30 PM
Okay.. %e is a very specific token that applies to *very* patched builds (ie, its patch depends on another patch which depends on ...) and thus it will only work in some custom builds.

So you either :
- Choose another simpler theme.
- Head over to the 'unsupported builds' forum to find an unsupported build that'll work.
- Try to go look elsewhere (like misticriver.com which is a iRiver specific site) for such a build.