Rockbox Technical Forums

Support and General Use => Audio Playback, Database and Playlists => Topic started by: philden on September 25, 2021, 06:22:00 PM

Title: Bug in recent versions for scrolling ant-aliased text
Post by: philden on September 25, 2021, 06:22:00 PM
Hi. I'm using a 2TB iFlash iPod classic 7th Gen, and recently updated from the standard release as a precaution against SD card storage issues. I also recently made new versions of my themes with anti-aliased fonts. These are poppetaa and teppopaa.

Everything seemed OK, until I played a track with title/artist/album text that was long enough to overflow the screen and should then scroll. I found that the text did not appear on screen at all, just an empty line for that entry. Changing theme to the old versions, poppet and teppop, makes the standard font text scroll OK.

This failed with build 4ba323147-210905, so I updated today to 412e76b487-210921, and the problem remains.

Reverting to 3.15, however, makes the text scroll as expected with the anti-aliased fonts.
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Bilgus on October 01, 2021, 12:14:19 AM
does making your viewport properly sized for the font help?
poppetta,wps line 36
%V(0,18,320,16,3) => %V(0,18,320,19,3)
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Frankenpod on October 01, 2021, 03:19:32 PM
Is that, nonetheless, new behaviour?

'Cos I think I've occasionally used viewports slightly too short for the font they use, if I know it will only be displaying numerals, so no descenders.  It didn't seem to have that effect (i.e. the text not appearing at all), it would IIRC, just cut off any descenders if any alphabetical characters were in the viewport, so if it was just numeric characters (e.g. track playing time) it would work fine.

Seems that sometimes changes to the code means small 'errors' like that in WPS scripts are not 'forgiven' the way they used to be, thus breaking existing themes.

Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Bilgus on October 01, 2021, 07:31:45 PM
Sure its different but its also not a bug
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Bilgus on October 02, 2021, 12:34:31 AM
Sorry ment to add that I was looking into allowing clipping (depending if it breaks other things) but ill have to get back to that
this goes back to the scroll engine so your short vp don't have scrolling they wouldn't get cut off
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Frankenpod on October 02, 2021, 02:40:38 AM
Yeah, not saying one could call it a 'bug'.  Just wondering if it is a change if it would affect other existing themes.  I suspect in most cases clipped viewports are not scrolling ones, though, so that might be why I never noticed this behavior before, maybe it's not even new?
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Frankenpod on October 02, 2021, 03:00:47 AM
Incidentally, I think both poppetaa and teppopaa might benefit from having a line in the .cfg file to clear any existing backdrop, i.e.

Code: [Select]
backdrop: -
I thought for a moment they had a bug, but it was just that when you switch to them you keep the backdrop from the previous theme, which can make them look a bit 'wrong'.
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Bilgus on October 02, 2021, 03:35:48 AM
I originally added the code to stop corruption outside viewports

that being said this should still do so and appears to have no adverse effect

https://gerrit.rockbox.org/r/c/rockbox/+/3857

Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: Bilgus on October 02, 2021, 10:32:03 AM
its fixed in todays dev build
Title: Re: Bug in recent versions for scrolling ant-aliased text
Post by: philden on October 02, 2021, 01:50:52 PM
Thanks for the help with this, Bilgus and Frankenpod, I'll work on my themes this weekend.