Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: Zardoz on September 15, 2008, 06:43:25 PM

Title: re FS#4988, backlight on when plugins are running
Post by: Zardoz on September 15, 2008, 06:43:25 PM
The patch to allow, optionally, keeping the backlight on when using a plugin was originally committed and then reverted due to "bin size cost". I just wondered what was the cost and how it impacted on Rockbox generally, as it seems like a useful idea?
Title: Re: re FS#4988, backlight on when plugins are running
Post by: saratoga on September 15, 2008, 06:47:21 PM
Since its ancient, I doubt anyone remembers off hand.  Why not check the IRC logs or else apply it yourself and see how much the bin size increases?
Title: Re: re FS#4988, backlight on when plugins are running
Post by: Zardoz on September 15, 2008, 06:52:17 PM
Ok good idea I guess.  ;)  Just asked as it had popped up in recent feature requests/...discussion

EDIT: 'ancient' being a relative term
Title: Re: re FS#4988, backlight on when plugins are running
Post by: Llorean on September 17, 2008, 08:30:35 AM
Mpegplayer can currently override backlight settings. This can be added to other plugins without additional bincost I'm sure.
Title: Re: re FS#4988, backlight on when plugins are running
Post by: Zardoz on September 20, 2008, 04:44:14 PM
Is the code common to all plugins? I mean is it the same code? (sorry if this question is stupd but i don't understand any code let alone C)
Title: Re: re FS#4988, backlight on when plugins are running
Post by: GodEater on September 22, 2008, 08:20:13 AM
No, it's only in mpegplayer.
Title: Re: re FS#4988, backlight on when plugins are running
Post by: Zardoz on September 22, 2008, 07:19:49 PM
Quote
I mean is it the same code?

That should have read 'Would it be the same code?' i.e for other plugins
Title: Re: re FS#4988, backlight on when plugins are running
Post by: saratoga on September 22, 2008, 07:20:53 PM
I don't know how mpegplayer does it, but if it works in one plugin it should work in all.
Title: Re: re FS#4988, backlight on when plugins are running
Post by: JdGordon on September 22, 2008, 11:15:54 PM
That should have read 'Would it be the same code?' i.e for other plugins

I think its in the plugin library, so its as simple as adding 2 lines of code to each plugin.
Title: Re: re FS#4988, backlight on when plugins are running
Post by: Zardoz on September 25, 2008, 08:29:21 PM
ok cool. thanks for the replies

big up Rockbox developer people, for 3.0!

x