Rockbox Technical Forums

Rockbox Development => Starting Development and Compiling => Topic started by: Paula on January 24, 2010, 07:55:24 AM

Title: Adding a new plugin with svn
Post by: Paula on January 24, 2010, 07:55:24 AM
Hi,

I've written my first plugin now and I would like to upload it to this site.
I've found the svn-description "Adding a new file" but I'm not sure about the parameter of the command
svn pset svn:keywords "Author Date Id Revision" <filename>

I think that "revision" means the rockbox version, but I don't know, what "Id" means.

I would be very glad about some help,
Paula



Title: Re: Adding a new plugin with svn
Post by: yapper on January 24, 2010, 10:20:02 AM
See this: http://www.rockbox.org/wiki/DevelopmentGuide which explains the process of submitting a patch.
Title: Re: Adding a new plugin with svn
Post by: bluebrother on January 24, 2010, 11:06:00 AM
svn pset svn:keywords "Author Date Id Revision" <filename>

This sets a property (pset) for svn. Keywords are strings that are replaced by subversion, and the strings you set are recognized -- subversion knows about a couple of keywords, and you usually want only some of them (or even none) to get used. I.e. with that line you tell subversion to replace the keywords "Author", "Date", "Id", and "Revision". The most frequent used keyword is Id, which you find in the standard Rockbox header as "$Id: <something>$" This line will get replaced on every checkout or update of your working copy. Please check the subversion documentation on how keywords work.

For submitting a patch for a new plugin there isn't a need to set the keywords prior to generating the patch -- while svn itself adds information about the keywords to the diff file the patch program simply can't handle that and ignores it.
Title: Re: Adding a new plugin with svn
Post by: AlexP on January 24, 2010, 12:48:54 PM
Yep, don't worry about the keywords and that - the developer that commits it will sort that out.
Title: Re: Adding a new plugin with svn
Post by: bluebrother on January 24, 2010, 03:07:23 PM
Yep, don't worry about the keywords and that - the developer that commits it will sort that out.

And even developers forget about keywords sometimes (including me :)). It doesn't hurt at all, they don't serve any functional purpose (and some version control systems like git (http://kerneltrap.org/mailarchive/git/2006/10/9/223932) don't even have or at least strongly disencourage using them.
Title: Re: Adding a new plugin with svn
Post by: Paula on January 25, 2010, 04:24:54 AM
Thanks for your help, but I think I was on the wrong way with svn at all, because I'm new and I don't have any rights.
Now I've posted my plugin by flyspray (10932 ).