Rockbox Technical Forums

Rockbox Development => Feature Ideas => Topic started by: JohnMorris on February 10, 2011, 10:44:27 PM

Title: Car-adapter mode: rewind on un-pause
Post by: JohnMorris on February 10, 2011, 10:44:27 PM
I listen to audiobooks while driving. Similar to the existing "rewind on resume" feature, a "rewind on un-pause" when in car-adapter mode helps remind where the story left off after making a brief stop.

I have already implemented this for myself, but with a fixed rewind duration (10 seconds). To do it properly would need a new menu entry. I'd be very willing to implement this if there is wider interest.

Thoughts?



Title: Re: Car-adapter mode: rewind on un-pause
Post by: sideral on February 11, 2011, 02:12:05 AM
I'd love to have this as well. There's already a patch on the tracker, FS#9448 [1], that does this and already has a configurable rewind amount, but it works only when fade on pause is enabled. In my view, rewind on resume should depend on neither car-adapter mode nor fading.

Perhaps you could merge that patch and yours to a more general rewind-on-resume feature?

In any case, if you already have a patch, you should have it tracked in our patch tracker as well.

[1] http://www.rockbox.org/tracker/task/9448 (http://www.rockbox.org/tracker/task/9448)
Title: Re: Car-adapter mode: rewind on un-pause
Post by: JohnMorris on February 11, 2011, 10:15:48 PM
Thanks, I've looked at that thread and will take a look at the code itself soon.

Should this become a more generalized general feature, with its own sub-menu - rewind on <x>, where <x> is a user-selectable set of events?

My current change is actually a bit backwards: it does the rewind when the car power goes off, rather than when it comes back on - after looking at the implementation of rewind on resume that looked a bit simpler. But I not wedded to that method.

Err - I'm in the wrong forum for getting into technical discussions, aren't I?

Title: Re: Car-adapter mode: rewind on un-pause
Post by: JohnMorris on February 13, 2011, 12:10:13 AM
Initial patch as I have it submitted.

http://www.rockbox.org/tracker/task/11931