Rockbox Technical Forums

Support and General Use => User Interface and Voice => Topic started by: bascule on January 04, 2007, 05:32:21 AM

Title: DataBase not reading year tag in .ogg files
Post by: bascule on January 04, 2007, 05:32:21 AM
I've just initiated this bug in the Tracker: http://www.rockbox.org/tracker/task/6501

Quote
I noticed (using a custom_tagnavi file selecting by year) that I had a lot of tracks listed with a year of "0". As all my music is well tagged, I was looking for some differentiation as to which ones were causing the problem.
My tracks are a roughly 70/30 mixture of .ogg and .mp3, with varied bitrates from different sources and ripped/tagged with different applications.
I re-initialised the database and then set up two simple tagnavi selections, one for all tracks with Year == "0" and one for all tracks with Year != "0".
To my surprise, it neatly divided my entire music collection into .ogg in the Year == "0" playlist and .mp3 in the Year != "0" playlist.
It appears, therefore, that the DataBase initilisation does not correctly read the year tag from .ogg files
.

It seems pretty clear to me that there is a definite problem with the dataBase reading the year tag in .ogg files (it reads them all as "0"), but I wanted to get any other user experience on this in order to add to the Tracker coments if necessary.

Please check that this is also a problem on targets other than an iriver H120 and post any findings here or directly to the bug report if you are registered.
Title: Re: DataBase not reading year tag in .ogg files
Post by: lowlight on January 04, 2007, 11:47:23 AM
Rockbox parses the "date" tag for year (that's the vorbis comment standard). If the date tag is present, then something is wrong.
Title: Re: DataBase not reading year tag in .ogg files
Post by: lowlight on January 04, 2007, 11:57:27 AM
Nevermind...I see the problem.

There are two "year" references for the metadata in the id3 struct: id3.year (an integer) and id3.year_string (pointer to a string). The database is only storing the integer value of id3.year; however, the vorbis date tag uses id3.year_string since it can contain non-numeric characters.

This is a bug, I'll add my comment to the FS page.
Title: Re: DataBase not reading year tag in .ogg files
Post by: bascule on January 04, 2007, 02:53:03 PM
Thanks for that lowlight. Can you fix it, though? It certainly sounds like you know what you're doing ;)