Rockbox Technical Forums

Support and General Use => Recording => Topic started by: Davide-NYC on November 10, 2009, 10:34:52 PM

Title: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: Davide-NYC on November 10, 2009, 10:34:52 PM

Bug report for the recording rockbox community.

The trigger code seems to be rather broken.
Attempting to change the trigger DB limits (above or below) causes the setting to jump to -84db and get stuck.
You can however still turn the "start above" or "start below" features off.

It also does not show up on the WRS and resets the peakmeters to their smallest size.

Long story short, it's very broken. :-(
At least on the H1x0 target.

If a few people would post their findings here it would be helpful.

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: Llorean on November 10, 2009, 11:40:00 PM

Is this reported on flyspray?

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: JdGordon on November 11, 2009, 02:55:18 AM

that wont really help.... trigger is not something any of the devs use.. IIRC trigger stuff hasnt changed in months...

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: petur on November 16, 2009, 08:27:09 AM

Last time I worked on it everything was still OK... I wonder what went wrong

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: fredwbauer on November 17, 2009, 01:08:03 PM

David, can you work around it by manually adding some of the following settings to your config.cfg file?

trigger start threshold dB: -73 (or whatever you want...)
trigger start threshold linear: 5
trigger stop threshold dB: -73
trigger stop threshold linear: 10

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: Davide-NYC on November 25, 2009, 07:44:16 AM

Thanks for the tip FredWBauer,

Here was I did  and what happened:

I modified by config.cfg file to include these lines:

Code: [Select]

trigger mode: repeat
trigger start threshold dB: -35
trigger start threshold linear: 5 (actually I'm not sure about this integer)
trigger stop threshold dB: -65
trigger stop threshold linear: 10 (actually I'm not sure about this integer)
When I attempted to record it seemed to work correctly.
I raised and lowered the gain and ended up with a few separate files.

When I re-examined the config.cfg file it looked like this:

Code: [Select]

# .cfg file created by rockbox r23746M-091125 - http://www.rockbox.org

volume: -26
rec path: /recordings
rec mic gain: 8
trigger stop threshold dB: -65
trigger mode: repeatReturning to Rockbox and entereing recording I attempted to modify the trigger settings and the start/stop gain thresholds would stick at -84 (or OFF) as previously described.

Examining the config.cfg file after having attempted to modify the trigger settings it still looked like this:

Code: [Select]

# .cfg file created by rockbox r23746M-091125 - http://www.rockbox.org

volume: -26
rec path: /recordings
rec mic gain: 8
trigger stop threshold dB: -65
trigger mode: repeatExactly the same! Something is not accepting changes somewhere in the trigger code.

I rarely use the trigger function, but when it's needed it's very very handy.

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: Domonoky on November 25, 2009, 03:22:25 PM

I just commited a fix for this.

In the future, please report such bugs to flyspray, regardless of what JdGordon says :-)

Title: Re: Trigger code is broken on H1x0. (possibly on other targets as well)
Post by: Davide-NYC on December 18, 2009, 02:55:14 PM

Seems to be fixed, but I only did some very cursory testing.
In the future I will file a bug report in flyspray.
Cheers, Davide.