Rockbox Technical Forums

Support and General Use => Recording => Topic started by: JdGordon on May 27, 2007, 05:28:47 AM

Title: custom recording dir setting
Post by: JdGordon on May 27, 2007, 05:28:47 AM
So, we are arguin in IRC about FS#7201 (user selectable record dir) and what should happen if the directory you want to record to doesnt exist and cant be created. (If it can be created it will).

Either it records to / -
pros:
will still record so no nasty suprise later

cons:
possibly have to go searchign for the file
recording to the ondios 128MB internal ram wouldnt last very long.

or, fail with an error message
pros:
umm...?
cons:
you recording may not happen

my view is it shhuold do the first, but I dont record very often. (and i guess if this goes 50:50 we could easil add the option so you can choose what to do)
Title: Re: custom recording dir setting
Post by: ColdSphinx on May 27, 2007, 06:17:40 AM
I think it should record to the rootdir so the record don't get lost if the "thing" to be recorded can't be repeated.

(Currently don't know how to explain better)
Title: Re: custom recording dir setting
Post by: whatboutbob on May 27, 2007, 09:33:38 AM
My instinct would be to have it fail gracefully.  ie option 1 + an error message (if possible) - 'Dir doesn't exist; saving to root dir'...
Title: Re: custom recording dir setting
Post by: gnu on May 27, 2007, 10:40:52 AM
Yes, I agree with option 1. If you don't like your recording, or your disc/ram gets full, you can always delete your file!
Title: Re: custom recording dir setting
Post by: JdGordon on May 27, 2007, 10:46:47 AM
can the person who voted option 2 explain why? although it does look like opt 1 will win
Title: Re: custom recording dir setting
Post by: Llorean on May 27, 2007, 03:52:57 PM
In my opinion 9 times out of 10, this is going to be a case of the MicroSD or MMC card not being present. This means, you probably don't have enough storage on the device for what you intend to record.

I think that the error should be hard (ie, don't start recording). A user can easily make sure things are right ahead of time, but if a user misses the splash, glances down, and sees it recording they may think no error has occurred. If they see clearly that it's NOT recording, they'll know something has gone wrong and are more likely to have a chance to fix it and at least somewhat mitigate the bad start.

Otherwise, they could get 5 minutes into a 2 hour show, the recording could stop in their pocket, they think it's all good, and quite some time later finally realize the disk was full.

The only case a recording directory can't be created is if the removable storage is gone, and in these cases the user probably NEEDs to record on it, more often than merely WANTS to.
Title: Re: custom recording dir setting
Post by: petur on May 27, 2007, 06:21:39 PM
Wow, that's a good way to look at it.... Let me change my vote

A clear indication of remaining time/space should help too
Title: Re: custom recording dir setting
Post by: JdGordon on May 28, 2007, 05:48:56 AM
The only case a recording directory can't be created is if the removable storage is gone, and in these cases the user probably NEEDs to record on it, more often than merely WANTS to.

this isnt true.
delete the /recordings folder, create a new blank file with ta name and try doing a recording.
Title: Re: custom recording dir setting
Post by: Llorean on May 28, 2007, 05:51:31 AM
That case takes a very special effort on the user's end to mess things up. I did say, though, that the majority of cases is likely to revolve around the removal of external storage.
Title: Re: custom recording dir setting
Post by: Davide-NYC on May 28, 2007, 11:09:58 AM
If the scenario described occurs, the user should be informed via splash screen and then asked whether to start recording in "/" AND should be informed of how much space there is left on the device. The user would have to acknowledge both of these facts before the recording begins.

I.E.
Quote
The "recordings" directory does not exist and cannot be created. There is 64MB of space remaining. Save Recording to "root" ?     Y/N
Title: Re: custom recording dir setting
Post by: petur on May 28, 2007, 04:31:17 PM
I.E.
Quote
The "recordings" directory does not exist and cannot be created. There is 64MB of space remaining. Save Recording to "root" ?     Y/N
On that little screen?  :P
Title: Re: custom recording dir setting
Post by: JdGordon on May 30, 2007, 06:16:58 AM
I've updated the FS patch... it does similar to Davide-NYC's splash, but doesnt give you the option of recording to /.
Title: Re: custom recording dir setting
Post by: Davide-NYC on June 05, 2007, 02:11:01 PM
I.E.
Quote
The "recordings" directory does not exist and cannot be created. There is 64MB of space remaining. Save Recording to "root" ?     Y/N
On that little screen?  :P

!!@#%^ Archos!

OK, I just installed FS#7201 from Jonathan Gordon (jdgordon) - Wednesday, 30 May 2007, 10:15 GMT

I get a strange error on my H1x0:

"Can't create the / directory. Error code -3"

Also the recording end up in "/" instead of "/recordings" even though "/recordings" exists.  IMO this is bad. If you cannot have  a custom folder then recordings should end up in the recordings directory if it exists or can be created.

FWIW: I have modded my H1x0 for RTC and have configured my builds to use the RTC code... so at least my files are chronologically organized.

I have not checked out the mul.dir.patch of Allen Young (IntelliCoder) - Thursday, 24 May 2007, 15:39 GMT, but will do so now.




[attachment deleted by admin for age]
Title: Re: custom recording dir setting
Post by: Davide-NYC on June 05, 2007, 03:25:27 PM
The mul.dir.patch by Allen Young (IntelliCoder) - Thursday, 24 May 2007, 15:39 GMT does not patch with SVN easily. All of the paths are wrong.

I managed to apply the patch but it is still pretty broken.
On STEREO inputs the Directory line causes the "Gain Right" line to not display and line selection is messed up. (IE the line highlighted is not the parameter that gets modified on joystick left/right)

Also even on the Mono (internal Mic) input joystick input seems to function as it would prior to patching.

----------------------------

I think JGordons simplified patch is better as an SVN committable idea except for the bug I just reported. Testing over for a few days. (sorry)
Title: Re: custom recording dir setting
Post by: JdGordon on June 05, 2007, 09:12:31 PM
yeah, my patch is fubar atm, not 100% sure why, and exams need to take priority over at least one of my WIP's :p
although, now recording works on my main DAP (sansa) it could getme working on this faster....