Rockbox Technical Forums

Support and General Use => Audio Playback, Database and Playlists => Topic started by: Buzkill on August 31, 2021, 09:08:18 AM

Title: SOLVED Tagnavi_custom MAX SIZE?
Post by: Buzkill on August 31, 2021, 09:08:18 AM

Been putting some decent time into making a cool custom genre database page and Ive found that if I add anymore code, it seems to break the viewer and how it's supposed to work.

Is there a limit to the size and length of the tagnavi_custom file? Or what could be the issue? I know its not the code, because if I remove any part to make it smaller it starts to work as expected again.

Any ideas? ???

THANK YOU

Title: Re: Tagnavi_custom MAX SIZE?
Post by: chris_s on August 31, 2021, 09:21:42 AM

Quote from: Buzkill on August 31, 2021, 09:08:18 AM

Is there a limit to the size and length of the tagnavi_custom file?

Yes:

Code: [Select]

#define TAGMENU_MAX_ITEMS  64
#define TAGMENU_MAX_MENUS  32
#define TAGMENU_MAX_FMTS   32See here: https://github.com/Rockbox/rockbox/blob/c11ed99cb453af968493018e1b83606423d9b9a0/apps/tagtree.h#L30

Title: Re: Tagnavi_custom MAX SIZE?
Post by: chris_s on August 31, 2021, 09:25:07 AM

Actually, sorry, I think I sent you to the wrong place. This seems to be the relevant piece of code:

Code: [Select]

#define TAGCACHE_MAX_CLAUSES 32
https://github.com/Rockbox/rockbox/blob/c11ed99cb453af968493018e1b83606423d9b9a0/apps/tagcache.h#L84

Title: Re: Tagnavi_custom MAX SIZE?
Post by: chris_s on August 31, 2021, 09:27:40 AM

Wait, no, now I'm confusing myself. I was right before (I think).  :D

Title: Re: Tagnavi_custom MAX SIZE?
Post by: Buzkill on August 31, 2021, 09:55:22 AM

Im not quite sure what your pointing out :D is it something i can change or no?
I mean obviously i can change the value and recompile, but why did they pick that limit to begin with?

Would be interested to know how high you could push that without major problems but i have no clue what it would effect

Title: Re: Tagnavi_custom MAX SIZE?
Post by: Buzkill on August 31, 2021, 10:05:22 AM

OMG THANK YOU!!!!! that worked.

Title: Re: Tagnavi_custom MAX SIZE?
Post by: chris_s on September 01, 2021, 05:19:37 PM

Quote from: Buzkill on August 31, 2021, 09:55:22 AM

Im not quite sure what your pointing out :D is it something i can change or no?
I mean obviously i can change the value and recompile, but why did they pick that limit to begin with?

Would be interested to know how high you could push that without major problems but i have no clue what it would effect

I'm assuming RAM usage and possibly execution speed. The effect is probably going to be negligible on something like an iPod classic if you don't go crazy with the values.

Quote from: Buzkill on August 31, 2021, 10:05:22 AM

OMG THANK YOU!!!!! that worked.

Cool!