Rockbox Technical Forums

Support and General Use => Theming and Appearance Customization => Topic started by: RedBreva on May 21, 2007, 10:31:22 AM

Title: Album Art Tags in wps - Error or Ignore??
Post by: RedBreva on May 21, 2007, 10:31:22 AM

There are several AA themes which used to work with a standard daily build, by - I think - having the offending non standard tags below the bottom line of the screen.  If an AA build was present, AA was displayed, else No-Album Art placeholder graphic was seen.

Since the improved parsing, this no longer works, the AA tags causing a failure.  

My question is *should* it?  Might it be possible to just ignore these (well known) unknown tags to allow the old method to work...

Just a suggestion, what's the opinion of other people??

Title: Re: Album Art Tags in wps - Error or Ignore??
Post by: Llorean on May 21, 2007, 11:49:08 AM

Why should the official build go out of its way to work with WPSes with tags it doesn't recognize? These tags are invalid, and I don't think it should make exceptions for tags that are "Invalid, but we'll ignore them since they're valid in other builds." It somewhat defeats the purpose of the parser rejecting invalid tags and otherwise if there are exceptions. What if someone does %C as a typo rather than intending to have album art? The parser will ignore it, and they'll think there's nothing wrong with the WPS, except that it's behaving irregularly, and possibly report a bug.

I think there should be no exceptions.