WPS tokenizer: REPORT PROBLEMS HERE

[bundy]

The newest patch broke few themes with multiple sublines in them.

I made a patch which should solve this: http://www.rockbox.org/tracker/task/7004

[NicolasP]

I committed your patch, thanks

[vimes]

I am not 100% sure that the problem comes from this change but I use today's (12th of April) build of Rockbox for Gigabeat and, using any WPS, all the texts element display  are offset to the top of the screen by a constant.
What I should have on screen:
-------------------
|                        |
|                        |
|                        |
|test                   |
|test2                 |
-------------------
what I get :
-------------------
|                        |
|test                   |
|test2                 |
|                        |
|                        |
-------------------

[PaulJam]

Hi,

the tags for Crossfeed (%xd) and Crossfade (%xf) don't work anymore (in the uisimulator).
When i tried them in the simulator, it froze when it should display the wps.
I haven't tried them on the target.

[NicolasP]

The tags for Crossfeed (%xd) and Crossfade (%xf) don't work anymore (in the uisimulator).
When i tried them in the simulator, it froze when it should display the wps.
I haven't tried them on the target.

I'll add them in my next commit.

I am not 100% sure that the problem comes from this change but I use today's (12th of April) build of Rockbox for Gigabeat and, using any WPS, all the texts element display  are offset to the top of the screen by a constant.

Do you use the crossfade or crossfeed tags ?

[vimes]

Both the use of crossfade and crossfeed tags are disabled in the options.
Tough if you meant in the WPS files, I found %xdE, %xdA  etc... tags in the WPS file corresponding to iCatcher and BeatMPGirl  but no straight %xd... but I don't really have any knowledge in WPS syntax.

[NicolasP]

Is the problem still present with the latest version (r13127) ?

[|2eM!x]

Just updated today, I am not sure if this is a bug caused by this but here goes:

Code: [Select]

%al                              %pc%ac%pv                         -%pr  
Using this it seems the center tag is totally ignored.

[NicolasP]

Just updated today, I am not sure if this is a bug caused by this but here goes:

Code: [Select]

%al                              %pc%ac%pv                         -%pr  
Using this it seems the center tag is totally ignored.

I think that's probably because the text on the left is too long to allow the centered text to be centered. The displaying code merges strings that would overlap.

[Mmmm]

Just noticed this commit....

13 Apr 12:05 Remove the crossfeed WPS tag from the manual.

Does that mean you aren't going to incorporate crossfeed tag? If so why not?

EDIT: Just found your chat on IRC about this.... I reckon it should be included because it is useful and a very small change. If I have set crossfeed it is really easy for me to forget that I have done so and very useful to have a reminder on the WPS.

[Mmmm]

Another thing is that when I did have %?xd<%xdP|%xdQ> in my WPS code, I just got a freeze when the WPS was attempting to load. Shouldn't the line be ignored if it is erroneous?

Took me ages to find the culprit!

[NicolasP]

Mmmm: I'll probably readd the crossfeed tag eventually but it won't be %xd anymore.
I'm about to commit a fix that should prevent crashing with the code you gave.

Bascule: There probably are some glitches with UTF-8 as I don't know much about it. Could you send me one of the files that cause a crash/freeze ?

[bascule]

I'll try again from scratch:
Has this patch stopped the WPS code from accepting UTF-8 .wps files?

I have a couple of UTF-8 without BOM (but with Windows line-endings) .wps files that I have written that worked perfectly before and now cause a unit freeze on my H120 whenever I try to go to the While Playing Screen once the .wps file has been loaded.

They are really simple WPSs, so I don't think it's a tag problem...
I'm on r13142-20070413

EDIT: No, that wasn't it. Converted to ANSI (and UNIX line-endings) - same result

Surely there can't be anything in the attached WPS to cause a problem?

# 'Calmer' WPS to emulate Rio Karma display
# Constructed by bascule
# Designed for nedore-9 font
# Works OK with any font up to nine pixels high
%wd
%al%?mm< [OFF]|[R@]|[R1]|[RS]|[A-B] >   %?ps< [SHF]|[ORD] >%ar%?bc< Batt: [CHG]|Batt: %bl %% >

%ac%s%?it< %it|File: %fm >

%ac%s%?ia< %ia|No Artist Info >

%ac%s%?id< %id|Folder: %d1 >

%pb|12|||

%acNext Track:
%ac%s%?It< %It (%Ia)|No Next Track Info >

%al-%pr   %?mp< #|%>|%|%||%>%>|%|%|%||%>%>|%

%ac%s%?it|%|%||%>%>|%< %< >%ac%pp/%pe%ar%pv db

[NicolasP]

Bascule: you need to escape the '#' character on the last line.
This made me see a flaw in the parser so thanks

[bascule]

Oh, yeah, I remember seeing something about the change of behaviour of the hash symbol.

Thanks for that steer, here's hoping I can fix all my homebrews now

EDIT: OK, well, that fixed the simple ones...

However, my WPS up on the Wiki, (TextBox), is still causing a freeze, and it contains no hash characters.

It is more complicated, but I don't see why it is misbehaving. Can anyone shed some light?