Themes need updates - e.g. Nudel Green 5gAA

[tdtooke]

Here's another one of my themes needing updating threads.  Alotta great themes out there, congrats to all our artists.  Well, here's an example of what I'm talking about:

Code: [Select]

The wps for Nudel Green 5gAA reads as this:
# "Nudel Green 5GAA" ROCKbox theme for iPod 5G/Video
# Version 1.1, 19th March 2006, Leo Davidson (www.PretentiousName.com)
# Uses Album Art Patch: http://www.rockbox.org/bugs/task/3045
#
%X|bg.bmp|
%P|pb.bmp|
%xl|a|lstop.bmp|16|164|
%xl|b|lplay.bmp|16|164|
%xl|c|lpause.bmp|16|164|
%xl|d|lfwd.bmp|16|164|
%xl|e|lrwd.bmp|16|164|
%xl|f|v0.bmp|306|221|
%xl|g|v1.bmp|306|221|
%xl|h|v2.bmp|306|221|
%xl|i|v3.bmp|306|221|
%xl|j|v4.bmp|306|221|
%xl|k|v5.bmp|306|221|
%xl|l|v6.bmp|306|221|
%xl|m|v7.bmp|306|221|
%xl|n|v8.bmp|306|221|
%xl|o|v9.bmp|306|221|
%xl|p|vA.bmp|306|221|
%xl|q|b000.bmp|0|221|
%xl|r|b025.bmp|0|221|
%xl|s|b050.bmp|0|221|
%xl|t|b075.bmp|0|221|
%xl|u|b100.bmp|0|221|
%xl|v|h0.bmp|302|25|
%xl|w|h1.bmp|302|25|
%xl|x|rnone.bmp|291|163|
%xl|y|rall.bmp|291|163|
%xl|z|rone.bmp|291|163|
%xl|A|rrand.bmp|291|163|
%xl|B|s0.bmp|292|184|
%xl|C|s1.bmp|292|184|
%xl|D|bc0.bmp|147|221|
%xl|E|bc1.bmp|147|221|
%xl|F|bp0.bmp|161|221|
%xl|G|bp1.bmp|161|221|
%wd
%C|16|40|100|100|
 Now Playing%ar%cH:Mc 
%?mp<%xda|%xdb|%xdc|%xdd|%xde>%?mm<%xdx|%xdy|%xdz|%xdA>%?mh<%xdw|%xdv>%?ps<%xdC|%xdB>

                                %ia
                                %id %?iy<(%iy)>
                                %?it<%it|%fn>

                                %pp of %pe

                                %?It

%pb|21|42|278|

           %pc%ar-%pr           
%ac%fc %fbkbps
%?bl<%xdq|%xdr|%xds|%xdt|%xdu>%?pv<%xdf|%xdg|%xdh|%xdi|%xdj|%xdk|%xdl|%xdm|%xdn|%xdo|%xdp>
    %?bc<%xdE%bl%%|%xdD%bt>%?bp<%xdG|%xdF>%ar%pvdb    

Which displays the location info for the album art on the screen and throws the formating off and doesn't actually show the art.  I figured since bmp resizing is up and running again I'd tweak it just a bit so it'd work as:

Code: [Select]

# "Nudel Green 5GAA" ROCKbox theme for iPod 5G/Video
# Version 1.1, 19th March 2006, Leo Davidson (www.PretentiousName.com)
# Uses Album Art Patch: http://www.rockbox.org/bugs/task/3045
#
%X|bg.bmp|
%P|pb.bmp|
%xl|a|lstop.bmp|16|164|
%xl|b|lplay.bmp|16|164|
%xl|c|lpause.bmp|16|164|
%xl|d|lfwd.bmp|16|164|
%xl|e|lrwd.bmp|16|164|
%xl|f|v0.bmp|306|221|
%xl|g|v1.bmp|306|221|
%xl|h|v2.bmp|306|221|
%xl|i|v3.bmp|306|221|
%xl|j|v4.bmp|306|221|
%xl|k|v5.bmp|306|221|
%xl|l|v6.bmp|306|221|
%xl|m|v7.bmp|306|221|
%xl|n|v8.bmp|306|221|
%xl|o|v9.bmp|306|221|
%xl|p|vA.bmp|306|221|
%xl|q|b000.bmp|0|221|
%xl|r|b025.bmp|0|221|
%xl|s|b050.bmp|0|221|
%xl|t|b075.bmp|0|221|
%xl|u|b100.bmp|0|221|
%xl|v|h0.bmp|302|25|
%xl|w|h1.bmp|302|25|
%xl|x|rnone.bmp|291|163|
%xl|y|rall.bmp|291|163|
%xl|z|rone.bmp|291|163|
%xl|A|rrand.bmp|291|163|
%xl|B|s0.bmp|292|184|
%xl|C|s1.bmp|292|184|
%xl|D|bc0.bmp|147|221|
%xl|E|bc1.bmp|147|221|
%xl|F|bp0.bmp|161|221|
%xl|G|bp1.bmp|161|221|
%wd
 Now Playing%ar%cH:Mc 
%?mp<%xda|%xdb|%xdc|%xdd|%xde>%?mm<%xdx|%xdy|%xdz|%xdA>%?mh<%xdw|%xdv>%?ps<%xdC|%xdB>

                                %ia
                                %id %?iy<(%iy)>
                                %?it<%it|%fn>

                                %pp of %pe

                                %?It

%pb|21|42|278|

           %pc%ar-%pr           
%ac%fc %fbkbps
%?bl<%xdq|%xdr|%xds|%xdt|%xdu>%?pv<%xdf|%xdg|%xdh|%xdi|%xdj|%xdk|%xdl|%xdm|%xdn|%xdo|%xdp>
    %?bc<%xdE%bl%%|%xdD%bt>%?bp<%xdG|%xdF>%ar%pvdb
%Cl|16|40|s100|s100|
%C  

Sorry for the excessive length of this post, but I thought I should give a complete example of something I've seen quite a bit of on the wps5g page.

[bascule]

Well, it's a Wiki page, so there's nothing stopping you uploading the fixed version and noting it in the WPS entry. Alternatively, contact the author...

[tdtooke]

I'm not now, nor will I ever be modifying the posted work of others without their explicit permission.  I also won't be tracking down individual artists.  I'm calling myself putting out information that some people might find useful.  If this is not the case then I will keep future observations such as this to myself.

[bascule]

I didn't mean to imply that it wasn't useful, just that, to my mind, there's a natural next step (in a commons-based project such as Rockbox) to fix the 'problem' for everyone.

However, I appreciate your stance on modifying the works of others and obviously, by sharing the information, you have made the first step.

It may be worth modifying your topic title to include the WPS name, so that it might catch the eye of the author...

[Llorean]

I would say that semantic corrections to themes is in no way modifying the work of an artist, but that's my personal opinion.

In the future we're going to be asking artists to release their WPSes under a license when posting them that would allow authors to modify them in this way legally and without any guilt (beyond that they create for themselves).

In general, though, the forums are here for discussion, not for posting static pieces of information. While I'm not taking this down right now, it would be very much appreciated if you tried to get in contact with the artist, because just posting it here in the forums doesn't do that much good: This page will soon fade away.

[tdtooke]

Fair enough, basically all of the older themes featuring album art have that problem since (I assume) they're built to use an older version of the album art patch.  

Edit: Since I successfully contacted the author I tweaked this particular theme myself and got off my lazy (edited for content) and updated the wiki.  Since there are several themes where this is happening I propose that we all fix our favorites, I did mine already.