Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Starting Development and Compiling
| | |-+  Patch help
« previous next »
  • Print
Pages: [1] 2

Author Topic: Patch help  (Read 4224 times)

Offline deadacres

  • Member
  • *
  • Posts: 15
Patch help
« on: March 11, 2007, 01:55:08 PM »
I'm trying to patch rockbox using cygwin on windows xp. I'm using a 5G iPod. I've read simpleguidetocompiling, but when I try to patch it it says

missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or strip option?

Then it says some other stuff.  I did -p0, -p1, -p2, all the way to -p5 and it still says the same thing. I've tried all three patches that I want to use and it says the same thing with a different line number for each one. My patches are in F:\.rockbox

please help, thanks.
Logged

Offline Rincewind

  • Member
  • *
  • Posts: 266
Re: Patch help
« Reply #1 on: March 11, 2007, 02:51:18 PM »
are you sure you are running the patch command in your source root?

you have to run the patch command in the directory where you checked out / extracted the rockbox source. I usually place my patches there, too.

Looks like this:

x:\rockbox>patch < the_file.patch
Logged
Iriver H120, Sansa e280

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #2 on: March 11, 2007, 05:16:04 PM »
Quote from: Rincewind on March 11, 2007, 02:51:18 PM
are you sure you are running the patch command in your source root?

you have to run the patch command in the directory where you checked out / extracted the rockbox source. I usually place my patches there, too.

Looks like this:

x:\rockbox>patch < the_file.patch

I didn't understand that at all, haha. How do I run the patch command?
Logged

Offline nls

  • Developer
  • Member
  • *
  • Posts: 460
Re: Patch help
« Reply #3 on: March 11, 2007, 05:23:54 PM »
First, do you have the rockbox source? It is either checked out using svn or downloaded as an archive from the current build page, you need this to patch, you saying that your patches are in .rockbox directory makes me think that you are trying to patch a build of rockbox, that will not work as you need to patch the source and then compile.
Logged

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #4 on: March 11, 2007, 05:30:59 PM »
Quote from: nls on March 11, 2007, 05:23:54 PM
First, do you have the rockbox source? It is either checked out using svn or downloaded as an archive from the current build page, you need this to patch, you saying that your patches are in .rockbox directory makes me think that you are trying to patch a build of rockbox, that will not work as you need to patch the source and then compile.

Oh alright, I get it. Thanks. I'll try it out.
Logged

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #5 on: March 11, 2007, 05:42:19 PM »
How do I get the source?
Logged

Offline scorche

  • Administrator
  • Member
  • *
  • Posts: 666
Re: Patch help
« Reply #6 on: March 11, 2007, 05:44:22 PM »
Read the SimpleGuideToCompiling page again.
Logged

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #7 on: March 11, 2007, 05:49:31 PM »
Quote
From Daily Build page

Usually there are two different versions of the source code available... the Daily Build and the Bleeding Edge Build. Both of these builds are available at http://www.rockbox.org/daily.shtml The Bleeding Edge build contains the latest changes made by the Developers whereas the Daily Build is produced automatically at the same time every day. If you are new to Rockbox I would recommend downloading the Daily Build, because the Bleeding Edge build could contain bugs that the Developers are not aware of yet. In addition to this, older builds can also be downloaded, so all in all, its pretty much up to you what you decide to download.

    * Once the source code file has been downloaded, you should have a file called rockbox-daily-XXXXXXXX.tar.tar (where XXXXXXXX is the date) or _rockbox-bleeding.tar.tar

I don't know where to download it.

Edit: I don't want to use SVN.

Edit 2: I found it. Sorry about the dumb questions. Thanks for the help.
« Last Edit: March 11, 2007, 05:53:00 PM by deadacres »
Logged

Offline scorche

  • Administrator
  • Member
  • *
  • Posts: 666
Re: Patch help
« Reply #8 on: March 11, 2007, 06:11:35 PM »
Why do you not want to use SVN?  That is the easiest way.
Logged

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #9 on: March 11, 2007, 06:23:07 PM »
Quote from: scorche on March 11, 2007, 06:11:35 PM
Why do you not want to use SVN?  That is the easiest way.

It seemed harder, plus I would have to download it.
Logged

Offline Rincewind

  • Member
  • *
  • Posts: 266
Re: Patch help
« Reply #10 on: March 11, 2007, 07:39:40 PM »
deadacres: If you are serious about compiling rockbox then it is not a good idea to say "I don't want to downlad svn". If you install Cygwin the way it is described, you have svn already anyway.

And don't expect it to work without some serious reading of the Rockbox wiki. I spent a few days reading things up before I tried compiling the first time.
Logged
Iriver H120, Sansa e280

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #11 on: March 12, 2007, 04:07:26 PM »
Yeah I've been reading for awhile now. It's just that at some points in the guide I get completely lost because it's either complicated or I'm overlooking something really obvious.

I already have SVN, I guess, then, cause I downloaded cygwin correctly.
Logged

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #12 on: March 12, 2007, 04:35:07 PM »
I'm getting a new error now.

The source is unzipped and I put a patch into the apps folder where it should be. I patch it like I think I'm supposed to and I get...

patching file menu.c
Hunk #1 FAILED at 11
Hunk #2 FAILED at 136
2 our of 2 hunks FAILED -- saving rejects to file menu.c.rej

Logged

Offline bascule

  • Rockbox Expert
  • Member
  • *
  • Posts: 1298
Re: Patch help
« Reply #13 on: March 12, 2007, 04:41:47 PM »
That just means the patch is out of sync with the current SVN. See the patch author to correct this.

Alternatively, look at the .rej file and see what went wrong...
Logged
DataBase fanboy and author of the totally overhauled Rockbox Sync Tool

Offline deadacres

  • Member
  • *
  • Posts: 15
Re: Patch help
« Reply #14 on: March 12, 2007, 10:58:46 PM »
It's okay. The only plugin I really need works. I patched it and everything but now I'm having trouble configuring the build.
I get everything right but it messes up on the last step. I see...

Using source code root directory: (the directory of the source folder)
../tools/configure: line 1471: arm-elf-gcc: command not found
WARNING: The compiler you must use is not in your patch
WARNING: this may cause your build to fail since we cannot do the
WARNING: checks we want now.
Created Makefile

Should I be worried or is this build safe to use?

Edit: When I try to compile it and type make it says

make: *** No targets specified and no makefile found. Stop.
Logged

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Rockbox Development
| |-+  Starting Development and Compiling
| | |-+  Patch help
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.095 seconds with 15 queries.