Virtual Keyboard issues on the H300

[rah]

Hi,

First post, so forgive any etiquette issues.  Secondly, thanks to all for Rockbox, it's amazing!

I just noticed that the virtual keyboard on a friend's X5 was far more functional than on my H340. On the H340, you couldn't select the line being edited, and place the cursor at arbitrary positions.  You could only delete from the end, and retype the lot.

Some grepping later, I think I found the problem.  In the file, apps/recorder/keyboard.c KBD_MODES is not defined for the H300 series.  Changing this, and compiling under the simulator worked a treat.  I just cross compiled it, and fired it onto the H300, and that worked a treat, too. Time will tell if I've actually broken anything.  Anyway, I've included the patch, for what it's worth.

Finally, is there a reason that the first char of the virtual keyboard starts in the 2nd column of the screen?

Once again, thanks to all for Rockbox!

===Rich

[attachment deleted by admin, too old]

[JdGordon]

hold play while you use the arrows to move the cursor.... if this isnt menitoned in the manual then this is a big problem (with the manual, not the vk).

[rah]

Hello,

Thanks for the quick reply.  Yep, it's in the manual.  Oh dear, all that effort to find the issue.  But, isn't the X5 functionality better?  Did I break something, I wonder?  I guess I could turn this into a feature request.  

Thanks again,

===Rich

[Mmmm]

I think (I may be wrong though) that the H1/3xx models were given a special key to move the cursor instead of using the KBD_MODES because they have enough keys for this to be possible.

It was reasoned (I suppose) that having a dedicated key combination was better than having to scroll down to the bottom line to delete and move the cursor and it actually made the KBD_MODES functionality redundant too. I have played with the KBD_MODES thing on the simulator and I must say that I prefer the way the I-rivers work... I would always use the keys rather than the editing line. Maybe it's just what I'm used to but I'm sure it is more convenient using the keys.

If you use the remote on the I-rivers, it is even better as you don't have to use a key combination at all, you have three dedicated keys for forward backward and delete!

[rah]

Hi,

I guess it's what you're used to.  Since I didn't see that bit in the manual about pressing both play and the 'arrow' keys, I just assumed it wasn't possible.  Playing with the X5 showed that it was possible.  I liked the one handed approach.  I have the choice of both now, so I can't complain.  What fun!

Thanks for the reply.

===Rich

[Mmmm]

Are you sure you can use both? I thought that defining KBD_MODES disabled the buttons for the filename line.... I could be wrong though - as I haven't looked at that bit of code for a bit, or maybe you have changed more than just the define.

[rah]

Hi,

All I meant is I've got two binaries on my disk, one the default, one with KBD_MODES, so I can flick back and forth.  You are right in that KBD_MODES disables the default H300 way of editing.  It might be worth looking into having both in one bin, but I guess it'd take me a while to fathom the consequences of merging the KBD_MODES and non KBD_MODES code.

Thanks again,

===Rich