Rockbox General > Rockbox General Discussion
New album artist and comment patch for WPS and tagcache
roolku:
--- Quote from: dip on February 09, 2007, 03:36:28 AM ---Based on the comment patch from Nicolas Pennequin (see http://www.rockbox.org/tracker/task/2974) I created a patch to enable usage of the albumartist tag and the comment tag for both displaying in the WPS as well as using as filter and conditional in tagnavi.config.
--- End quote ---
It would have been nice if you had credited http://www.rockbox.org/tracker/task/6301 as well, as this is where the Comment tag code for WPS and tagcache comes from.
Roolku
dip:
--- Quote from: roolku on February 09, 2007, 09:44:10 AM ---
--- Quote from: dip on February 09, 2007, 03:36:28 AM ---Based on the comment patch from Nicolas Pennequin (see http://www.rockbox.org/tracker/task/2974) I created a patch to enable usage of the albumartist tag and the comment tag for both displaying in the WPS as well as using as filter and conditional in tagnavi.config.
--- End quote ---
It would have been nice if you had credited http://www.rockbox.org/tracker/task/6301 as well, as this is where the Comment tag code for WPS and tagcache comes from.
Roolku
--- End quote ---
Sorry for that!! :-[
I mixed up the two patches and cited the wrong one. Of course I amended the comment patch from you and not from Nicolas. I corrected my previous post accordingly.
Thanks for the great patch. As previously mentioned, I only duplicated your comment code and replaced some text.
roolku:
--- Quote from: dip on February 09, 2007, 09:54:24 AM ---
--- Quote from: roolku on February 09, 2007, 09:44:10 AM ---
--- Quote from: dip on February 09, 2007, 03:36:28 AM ---Based on the comment patch from Nicolas Pennequin (see http://www.rockbox.org/tracker/task/2974) I created a patch to enable usage of the albumartist tag and the comment tag for both displaying in the WPS as well as using as filter and conditional in tagnavi.config.
--- End quote ---
It would have been nice if you had credited http://www.rockbox.org/tracker/task/6301 as well, as this is where the Comment tag code for WPS and tagcache comes from.
Roolku
--- End quote ---
Sorry for that!! :-[
I mixed up the two patches and cited the wrong one. Of course I amended the comment patch from you and not from Nicolas. I corrected my previous post accordingly.
Thanks for the great patch. As previously mentioned, I only duplicated your comment code and replaced some text.
--- End quote ---
No worries - I didn't mean to sound so harsh. I was just curious how you had done the comment tag extraction from the id3 tag and noticed the exact same ugly hack that I used. :)
Well at least it reminded me to have another look at it, as I have had 2 bad comment tags that crashed the player in browse-by-comment. Re-saving the comment in winamp fixed it, but it would be nice if it didn't crash in the first place.
dip:
I made a new version of the patch. It shows now album artist and comment also on the id3 info page (including English and German labels).
I also added support for the mp3 COM tag (id3v2.2) in addition to the mp3 COMM tag (id3v2.3) but I cannot test it since I have not tagging program which writes v2.2.
The new version can be found on flyspray (http://www.rockbox.org/tracker/task/6638).
I also confirm that %IA and %IC (next album artist and next comment) do work in WPS.
Dieter
Rincewind:
Just a quick question:
Is it possible now to create an entry which shows Album Artist if that tag is present and shows Artist if it isn't?
I have tagged my mp3s in a way that normal albums don't have the Album Artist set and only on compilations I have set the Album Artist to "Various" or on some classical pieces to the performer.
And another thing: you wrote something about BAND for mp3s. Does that mean that ALBUM ARTIST isn't supported for mp3s? I don't know from where you get that BAND is more commonly used than ALBUM ARTIST. I think that foobar2000 users use ALBUM ARTIST more often (that's the standard tag they describe in their wiki).
Since the code for ALBUM ARTIST and ALBUMARTIST is already there for oggs I would suggest that you extend this to mp3s, too. That would save me a lot of retagging and reprogramming foobar2000.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version