Rockbox General > Rockbox General Discussion

New album artist and comment patch for WPS and tagcache

<< < (3/4) > >>

senab:
I'm currently altering the patch to make use of foobar's album artist tag aswell :)

dip:
@Rincewind
Unfortunately the patch only adds the possibility to use the album art tag  but no additional logic to use it only if it is set and the artist tag if it isn't. This would be much more complicated. So in order to create a browse album artist entry you must set album artist for all of your tracks.

Applications like Winamp and MediaMonkey (and others) use the BAND tag for mp3 files as album artist tag. These applications have predefined input fields for inputting the tags, and one of the fields is labeled Album Artist. Depending on the audio format (mp3, ogg, flac...) the tags are written into a specific tag. For mp3 files the BAND tag is used and for ogg files MediaMonkey writes the ALBUM ARTIST as well as the ENSEMBLE tag. I assume that for mp3 files the BAND tag is used for Album Artist since this is one of the standard tags predefined in the id3 definition and which should be therefore supported by all applications. ALBUM ARTIST is, however, not predefined in the id3 standard, neither is ALBUMARTIST.

For ogg files this is different since for these no predefined tag names exist. So you can choose any tag name you want (which may of course lead to incompatibilities with other applications).

It should be possible to amend the patch that it reads in addition to the standard BAND tag also an existing non standard ALBUM ARTIST tag from mp3 files. But I do not know how to do that, so if Senab does it that would be great.

@senab
The patch has already be committed to the svn (I don't know if you have seen that, if yes forget my note). It has been slightly amended so you should make your improvements based on the commited code. I have also seen that at the end of id3.c in function main there is a printf command for all id3 tags. I have no idea what this printf is for, but shouldn't the new tags albumartist and comment also be included there?

Rincewind:
dip, thank you for the explanation.
If there is a way in TagNavi syntax to check in a conditional wheater a Tag exists then It should be possible to create an entry that does what I want.

This is where I have my information about ALBUM ARTIST from (and I followed this for my collection)
http://wiki.hydrogenaudio.org/index.php?title=Foobar2000:Encouraged_Tag_Standards

I just read in the id3v2 standard from id3.org and it seems to me that the BAND tag is not really supposed to be album artist, it was just chosen by some popular players for this purpose. But there is no point discussing this here, I just wanted to make my point clear, that I think that ALBUM ARTIST is a valid tag for album artist even in the mp3 format.

If the addition of ALBUM ARTIST for mp3s isn't much overhead for the DB (with that I mean: doesn't take space/computing time if it isn't used) then I would love to have it in Rockbox.

alsaf:
I use Easytag which does not have the facility to edit ALBUMARTIST field.

I have amended the tagnavi.config file as follows:

* Changed artist  to "Artist"   -> artist ? artist != "Various" -> album  -> title = "fmt_title"  
* Added the following line: "Various Artist" -> album ? artist == "Various" -> comment -> title = "fmt_title"
For the music file tags I have did the following:

*  Set Artist to artist for single artist cd's or Various for multiple artist  compiliations
*  Set Composer to artist
*  Set Album to name of album (rather than format album name (CD1), album name  (CD2) etc for multi disc compilations)
*  Set Comment to disc number
In all wps files replace %ia with %ic

This displays multi disc compilations as follows:

   Various-> album name -> 1
   Various-> album name -> 2
   Various-> album name -> 3
   ....

I am looking for something better like for instance:

   Various-> album name ->album name (CD 1)
   Various-> album name -> album name (CD 2)
   Various-> album name -> album name (CD 3)

I've tried adding a format field to tagnavi.config as follows:

      %format "fmt_disc"        "%s - (CD %s)" album comment

When I navigated through compilation part and I get to disc number section (comment) the screen is blank and I can get no further. It looks like my format field for comment does not work. Can anybody please help.

roolku:

--- Quote from: alsaf on February 12, 2007, 01:37:51 AM ---I've tried adding a format field to tagnavi.config as follows:

      %format "fmt_disc"        "%s - (CD %s)" album comment

When I navigated through compilation part and I get to disc number section (comment) the screen is blank and I can get no further. It looks like my format field for comment does not work. Can anybody please help.

--- End quote ---

The format string works for me. I suspect you have assigned to a filter rather than the title tag?

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version