Rockbox General > Rockbox General Discussion

New album artist and comment patch for WPS and tagcache

(1/4) > >>

dip:
Based on the comment patch from Robert Kukla (roolku) (see http://www.rockbox.org/tracker/task/6301) I created a patch to enable usage of the albumartist tag and the comment tag for both displaying in the WPS as well as using as filter and conditional in tagnavi.config.

If you set the albumartist tag e.g. to Various for all tracks of compilations and to the track artist for all tracks of non compilation albums you can easily create a "browse by albumartist" menu item in tagnavi.conf which shows only artists who have their own album (which usually reduces the length of the artist list a lot).

Example: "Album artist" -> albumartist ? albumartist != "Various" -> album -> title

You can also create a Compilation menu item with: "Compilations" -> album ? albumartist == "Various" -> title

For mp3 files you have to set the BAND tag (TP2/TPE2) which is commonly used for album artist.

Since for ogg vorbis and flac files no single standard tag exist, the patch reads the tags ALBUMARTIST, ALBUM ARTIST (with one space inbetween) and ENSEMBLE which are the most commonly used tags for album artist. Each of these tags will be recognized by the patch.

In tagnavi.config you have to use albumartist or ensemble as filter or in conditionals. album artist (with space) is not possible since spaces are used as delimiter between tags. Both of albumartist and ensemble will work in tagnavi.config, it doesn't matter whether you tag your ogg/flac files with an ALBUMARTIST, ALBUM ARTIST or ENSEMBLE tag.

In WPS the album artist can be displayed with %iA

The comment tag can e.g. be used for titles of classical pieces (like "Symphony Nr. 9") if more than one piece are on an album. In tagnavi.config simply use comment as filter or in a conditional. In WPS use %iC to display the comment. Of course you can use the comment tag to store whatever you want.

The patch can be downloaded from flyspray (http://www.rockbox.org/tracker/task/6638). I hope you will enjoy the patch :-)

Dieter

bascule:
This will please a lot of people :)

Did you also code WPS tags for next ALBUMARTIST and COMMENT (%IA and %IC respectively)?

dip:

--- Quote from: bascule on February 09, 2007, 05:08:35 AM ---Did you also code WPS tags for next ALBUMARTIST and COMMENT (%IA and %IC respectively)?

--- End quote ---
I think this should work automatically since I added only the characters A and C to the available tag list and it worked automatically with %iA and %iC. So %I should also work, but I will test it this evening.

I will also try to extend the patch that in the id3 info page the new tags are also shown. But I have to admit that I did not step really deep in the source code since I simply took the comment patch from Robert Kukla (roolku) and adapted the code for albumartist. Without his patch I wouldn't have found all places in the code which have to be amended.

For the sake of completeness I will also extend the patch that the comment tag will work with mp3 files using only id3v2.2 tags instead of id3v2.3 tags. As far as I understand, at the moment only the v2.3 COMM tag is read but not the v2.2 COM tag.

senab:
Very good work, i'm going to add this to my build  :D

dip:

--- Quote from: senab on February 09, 2007, 06:50:23 AM ---Very good work, i'm going to add this to my build  :D

--- End quote ---
Great to hear, since I would like to use your build, as it does exactly include the patches I want to use.

Unfortunately, I have only an iPod 80GB 5.5g so I am waiting for a first running version of Rockbox at the moment. Meanwhile I am playing around with the simulator and try to optimize my configuration for the REAL usage... (sigh)

Navigation

[0] Message Index

[#] Next page