Rockbox General > Rockbox General Discussion

Optimizing Rockbox Sources

(1/6) > >>

Sentertainment:
Ok, I'm new tto the rockbox community....so I do have alot of questions and such and I've been having trouble with one mod in particular (I do understand why, I just wish I could explain plain and simple I actually know a thing or two and I am here to help)

Anyways, I wasn't sure where to put this and I just don't feel a topic like this is fit as a patch.

So...to get started, I just began examining the source and such and am finding a few things I feel could be improved. (while they aren't huge things, seeing these functions called 100xxx times, it can add up)

Well, I've started at the menu code as I want to improve some GUI functionality (and speed) of Rockbox.
First I came across a menu limit and am curious as to why this is so.
Second I came across a few things that can be possibly "improved" in menu management.
*keep in mind I have little free time and this is after looking at the code for about 10min

Well, I saw the code for freeing a menu and I feel the whole structure can be improved using dynamic arrays.
This would minimize this:

--- Code: ---static int menu_find_free(void)
{
    int i;
    /* Tries to find an unused slot to put the new menu */
    for ( i=0; i

Llorean:
There is no dynamic allocation of memory in the core in Rockbox.

Sentertainment:

--- Quote from: Llorean on December 30, 2006, 11:18:39 PM ---There is no dynamic allocation of memory in the core in Rockbox.

--- End quote ---

So...isn't that what my goal is to do? :P
Not everything would benefit like I said, but alot of reiterating statements (such as that 'if' shown above) could be wiped out or even optimized more.

Anyways, are you telling me the arm processors and memory management wont support this? I honestly don't see how it wont, if it doesn't support it I would say it would be at the compiler's fault (I could be wrong).  Maybe I'm confused or I'm just not getting the idea...I don't know, lol

Llorean:
You said your goal was to do things more dynamically by using dynamic memory allocation. You didn't make mention of adding it, so I wasn't sure you realized that it didn't exist within Rockbox.

It has often been stated that it is not wanted within the core of Rockbox. Come into the IRC channel and ask about it, if you would like to try to argue the case before the main developers (assuming you can catch them online).

Sentertainment:

--- Quote from: Llorean on December 30, 2006, 11:26:45 PM ---You said your goal was to do things more dynamically by using dynamic memory allocation. You didn't make mention of adding it, so I wasn't sure you realized that it didn't exist within Rockbox.

It has often been stated that it is not wanted within the core of Rockbox. Come into the IRC channel and ask about it, if you would like to try to argue the case before the main developers (assuming you can catch them online).

--- End quote ---

Yeah, sorry if I seem a  bit scattered as I had a long day at work...I was talking about adding that (more-or-less modifying it in)
Thanks for the heads up, it's starting to get me wondering so I'll probably give that a shot.  KNow what time (say in GMT to avoid confusion, lol) would be best to get on IRC to catch a dev or two?

Navigation

[0] Message Index

[#] Next page