Support and General Use > Plugins/Viewers

Disktidy: "Plugin returned an error"

<< < (2/2)

mlind:
I managed to fix this myself!
 
At last I got myself a working coding environment!
And with some coding I made the plugin avoid going deeper than allowed, but still carry on with the rest.

Here's my experimental patch:
http://www.rockbox.org/tracker/task/6512

How do I edit "related tasks" / dependencies on FS?

the_winch:
Please test this patch.

http://www.rockbox.org/tracker/task/6514

It keeps track of the position in the directory so the handle can be closed when recursing into a sub dir and then reopened afterwards.
It will run a little slower due to reopening dir handles and skipping over already processed items.
This removes the directory handle limit but the next limit is the stack, if the dir tree is too deep you will get a stack overflow.

There is a h120 build with the patch applied here
http://winch.pinkbile.com/temp/h120.zip

mlind:

--- Quote from: the_winch on January 07, 2007, 08:39:46 AM ---next limit is the stack, if the dir tree is too deep you will get a stack overflow.
--- End quote ---

I got:

--- Code: ---*PANIC*
Stkov main

--- End code ---
Seems it managed to clean 8 but not 9.
But for my original actual case, before I put things even deeper for testing, it is just enough to be ok.

In my case I really don't think it's such a big deal if the deepest folders don't get cleaned.
It's no place I will go browsing for music.

But a possible sollution would maybe be to let Disktidy start with the current folder (in the browser) and clean the 8 allowed but no further down. If the user wants his one deep folder to be cleaned he can browse there and Disktidy will that folder and its contents?

Navigation

[0] Message Index

[*] Previous page

Go to full version