Support and General Use > User Interface and Voice
Album art & co. patches still no in the cvs?
rasher:
--- Quote from: bascule on November 12, 2006, 04:27:26 PM ---
--- Quote from: NicolasP on November 12, 2006, 03:53:57 PM ---...Scrollmargins will never be commited because it will be made obsolete by viewports...
--- End quote ---
So would it be possible to commit this WPS partial line scroll patch (link) instead?
--- End quote ---
Same deal. This is a much too specific patch. What is wanted is the general "viewports" solution, that will solve a whole bunch of related problems and allow much finer control of the WPS.
Llorean:
I personally think the partial line scroll would work well even with viewports, that way you don't have to put the "Title:" bit outside it, and the %it tag inside it.
bascule:
--- Quote from: rasher on November 12, 2006, 05:17:59 PM ---...Same deal. This is a much too specific patch...
--- End quote ---
I disagree. For me, the patch brings the line scrolling functionality in line with what I would intuitively expect it to do and adds a significant improvement in appearance for simple text-based WPS's (especially on small screens) and with very little cost in terms of code size.
Viewports seems like a different order of magnitude in terms of change to the functionality and when that happens the whole subject would need to be reviewed anyway.
LinusN:
I wouldn't mind committing the partial scroll patch in the mean time, until the viewport implementation is done.
bascule:
Many thanks for that, Linus ;D
http://www.rockbox.org/tracker/task/5907
If you need any assisstance/help, just let me know.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version