Support and General Use > User Interface and Voice
Album art & co. patches still no in the cvs?
bernych:
Hi Everyone,
It's now several months that I compile my own version of rockbox always with album art/progressbar y coord/scroll margin/etc.. and I pretty sure that lots of people are doing the same.
Can some one explain me why this album art patches are still not in the CVS?
They are primary feature for Rockbox, and it does no harm to people that doesn't use an album art WPS.
It's a big pain to try to adapt the patches on every CVS code modification.
If there is a good reason, please let me know. Otherwise, can someone commit these essential patches?
Thank you everyone for the great software you are creating.
Cheers,
Bernych
Llorean:
Have you tried reading the discussion of them on the patch tracker? There are still things in the way of committing it, like not having metadata-on-buffer, I believe.
JdGordon:
--- Quote from: bernych on November 10, 2006, 11:56:41 AM ---can someone commit these essential patches?
--- End quote ---
I fail to see how AA is an essential patch.. personally i tihnk its a waste of space.. (lucky for you the final say isnt mine :p )
NicolasP:
Album art is currently implemented in an inelegant way, and I'm waiting for metadata on buffer to come along to be able to do it the right way.
Progressbar Y coord hasn't been commited because it's author refuses to give his real name, which is against the project's policy.
Scrollmargins will never be commited because it will be made obsolete by viewports (whenever they are added... is anyone working on it ?)
bascule:
--- Quote from: NicolasP on November 12, 2006, 03:53:57 PM ---...Scrollmargins will never be commited because it will be made obsolete by viewports...
--- End quote ---
So would it be possible to commit this WPS partial line scroll patch (link) instead?
It moves the scrolling to start after the %s, so that you can have:
Title: %s%it
and the 'Title:' bit of the line does not scroll.
I don't know how near the viewport implementation is, but this is a really small patch that gives an elegant solution to some of the functionality of the scrolling margins patch, that could be committed in the meantime...
Please? :-*
Navigation
[0] Message Index
[#] Next page
Go to full version