Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Welcome to the Rockbox Technical Forums!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  Album art & co. patches still no in the cvs?
« previous next »
  • Print
Pages: [1] 2

Author Topic: Album art & co. patches still no in the cvs?  (Read 5951 times)

Offline bernych

  • Member
  • *
  • Posts: 6
Album art & co. patches still no in the cvs?
« on: November 10, 2006, 11:56:41 AM »
Hi Everyone,
It's now several months that I compile my own version of rockbox always with album art/progressbar y coord/scroll margin/etc.. and I pretty sure that lots of people are doing the same.

Can some one explain me why this album art patches are still not in the CVS?
They are primary feature for Rockbox, and it does no harm to people that doesn't use an album art WPS.

It's  a big pain to try to adapt the patches on every CVS code modification.

If there is a good reason, please let me know. Otherwise, can someone commit these essential patches?

Thank you everyone for the great software you are creating.

Cheers,

Bernych
Logged

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Album art & co. patches still no in the cvs?
« Reply #1 on: November 10, 2006, 01:28:21 PM »
Have you tried reading the discussion of them on the patch tracker? There are still things in the way of committing it, like not having metadata-on-buffer, I believe.
Logged

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: Album art & co. patches still no in the cvs?
« Reply #2 on: November 12, 2006, 04:57:57 AM »
Quote from: bernych on November 10, 2006, 11:56:41 AM
can someone commit these essential patches?
I fail to see how AA is an essential patch.. personally i tihnk its a waste of space.. (lucky for you the final say isnt mine :p )
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline NicolasP

  • Developer
  • Member
  • *
  • Posts: 195
Re: Album art & co. patches still no in the cvs?
« Reply #3 on: November 12, 2006, 03:53:57 PM »
Album art is currently implemented in an inelegant way, and I'm waiting for metadata on buffer to come along to be able to do it the right way.
Progressbar Y coord hasn't been commited because it's author refuses to give his real name, which is against the project's policy.
Scrollmargins will never be commited because it will be made obsolete by viewports (whenever they are added... is anyone working on it ?)
Logged

Offline bascule

  • Rockbox Expert
  • Member
  • *
  • Posts: 1298
Re: Album art & co. patches still no in the cvs?
« Reply #4 on: November 12, 2006, 04:27:26 PM »
Quote from: NicolasP on November 12, 2006, 03:53:57 PM
...Scrollmargins will never be commited because it will be made obsolete by viewports...

So would it be possible to commit this WPS partial line scroll patch (link) instead?

It moves the scrolling to start after the %s, so that you can have:

Title: %s%it

and the 'Title:' bit of the line does not scroll.

I don't know how near the viewport implementation is, but this is a really small patch that gives an elegant solution to some of the functionality of the scrolling margins patch, that could be committed in the meantime...

Please?  :-*
Logged
DataBase fanboy and author of the totally overhauled Rockbox Sync Tool

Offline rasher

  • Developer
  • Member
  • *
  • Posts: 295
    • My Rockbox stuff
Re: Album art & co. patches still no in the cvs?
« Reply #5 on: November 12, 2006, 05:17:59 PM »
Quote from: bascule on November 12, 2006, 04:27:26 PM
Quote from: NicolasP on November 12, 2006, 03:53:57 PM
...Scrollmargins will never be commited because it will be made obsolete by viewports...

So would it be possible to commit this WPS partial line scroll patch (link) instead?

Same deal. This is a much too specific patch. What is wanted is the general "viewports" solution, that will solve a whole bunch of related problems and allow much finer control of the WPS.
Logged

Download my Rockbox stuff: Prebuilt Windows simulators, Fonts, and more!

Offline Llorean

  • Member
  • *
  • Posts: 12931
Re: Album art & co. patches still no in the cvs?
« Reply #6 on: November 12, 2006, 08:39:50 PM »
I personally think the partial line scroll would work well even with viewports, that way you don't have to put the "Title:" bit outside it, and the %it tag inside it.
Logged

Offline bascule

  • Rockbox Expert
  • Member
  • *
  • Posts: 1298
Re: Album art & co. patches still no in the cvs?
« Reply #7 on: November 13, 2006, 03:33:53 AM »
Quote from: rasher on November 12, 2006, 05:17:59 PM
...Same deal. This is a much too specific patch...
I disagree. For me, the patch brings the line scrolling functionality in line with what I would intuitively expect it to do and adds a significant improvement in appearance for simple text-based WPS's (especially on small screens) and with very little cost in terms of code size.

Viewports seems like a different order of magnitude in terms of change to the functionality and when that happens the whole subject would need to be reviewed anyway.
Logged
DataBase fanboy and author of the totally overhauled Rockbox Sync Tool

Offline LinusN

  • Member
  • *
  • Posts: 1914
Re: Album art & co. patches still no in the cvs?
« Reply #8 on: November 13, 2006, 03:44:34 AM »
I wouldn't mind committing the partial scroll patch in the mean time, until the viewport implementation is done.
Logged
Archos Jukebox 6000, Recorder, FM Recorder/iAudio X5/iriver H1x0, H3x0/Toshiba Gigabeat F20/iPod G5, G5.5

Offline bascule

  • Rockbox Expert
  • Member
  • *
  • Posts: 1298
Re: Album art & co. patches still no in the cvs?
« Reply #9 on: November 13, 2006, 03:47:56 AM »
Many thanks for that, Linus ;D

http://www.rockbox.org/tracker/task/5907

If you need any assisstance/help, just let me know.
« Last Edit: November 13, 2006, 04:16:15 AM by bascule »
Logged
DataBase fanboy and author of the totally overhauled Rockbox Sync Tool

Offline Genre9mp3

  • Artist
  • Member
  • *
  • Posts: 146
Re: Album art & co. patches still no in the cvs?
« Reply #10 on: November 13, 2006, 04:58:18 AM »
Am I wrong to think that according to all these, album art will be implemented when viewports will be implemented, too?

The reason I am saying this, is because album art is "somehow" depedent on scroll margins. There's no WPS out there that uses album art and not using scroll margins. This is because without scroll margins, you can't have text next to the cover displayed and it's a total waste of space without it (especially on big album art displays, eg. 100x100)

Seeing no one is working on viewports at the moment I guess it will take some time before we see album art on CVS. In fact, we may never see album art on CVS (cause it's more likely that we 'll have switched to SVN by then! :P)
Logged

Offline lowlight

  • Developer
  • Member
  • *
  • Posts: 194
Re: Album art & co. patches still no in the cvs?
« Reply #11 on: November 13, 2006, 09:00:59 AM »
Quote from: LinusN on November 13, 2006, 03:44:34 AM
I wouldn't mind committing the partial scroll patch in the mean time, until the viewport implementation is done.

I'll do that soon ;D
Logged

Offline Yotto

  • Artist
  • Member
  • *
  • Posts: 826
  • Every Silver Lining has a Cloud
    • My Blog
Re: Album art & co. patches still no in the cvs?
« Reply #12 on: November 13, 2006, 11:05:03 AM »
Quote from: Genre9mp3 on November 13, 2006, 04:58:18 AM
Am I wrong to think that according to all these, album art will be implemented when viewports will be implemented, too?

The reason I am saying this, is because album art is "somehow" depedent on scroll margins. There's no WPS out there that uses album art and not using scroll margins. This is because without scroll margins, you can't have text next to the cover displayed and it's a total waste of space without it (especially on big album art displays, eg. 100x100)
These don't use scroll margins:


I know becasue I made them.

I also made one with a centered-top album art, but mistakenly deleted it.  It had textual information on both the right and left of the album art.
« Last Edit: November 13, 2006, 11:06:40 AM by Yotto »
Logged
Pulp Audio Weekly - Where we talk about News, Reviews, and pretty much anything else we feel like discussing.

Offline iPodFoo

  • Member
  • *
  • Posts: 221
  • Ya dig?
    • iPod Nano Rockbox Blog
Re: Album art & co. patches still no in the cvs?
« Reply #13 on: November 13, 2006, 11:55:13 AM »
All very well if you have a 320x240 screen to fit text on without scrolling :P
Logged
Visit my blog at modprojects.blogspot.com for some iPod Nano goodies!

Offline Yotto

  • Artist
  • Member
  • *
  • Posts: 826
  • Every Silver Lining has a Cloud
    • My Blog
Re: Album art & co. patches still no in the cvs?
« Reply #14 on: November 13, 2006, 12:24:53 PM »
Well, if the proposed scrolling margins "lite" patch is included, then your problems will be solved with:
Code: [Select]
         %shere is the srolling text
Instead of what I have:
Code: [Select]
         here is the non-scrolling text
If I didn't have the 320x240 display, I'd probably not use 100x100 album art.

One thing about the new %s patch, does it allow you to put an "end point" on the scrolling text?  IE:

non-scrolling%sscrolling%smore non-scrolling

Just a thought, so you could have album art on the right side of the screen as well.  I have no idea how hard it would be to code, so I won't insert the obligatory "It should be easy" clause, thereby volunteering myself to do it :D
Logged
Pulp Audio Weekly - Where we talk about News, Reviews, and pretty much anything else we feel like discussing.

  • Print
Pages: [1] 2
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  Album art & co. patches still no in the cvs?
 

  • SMF 2.0.17 | SMF © 2019, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.179 seconds with 22 queries.