Album art & co. patches still no in the cvs?

[bernych]

Hi Everyone,
It's now several months that I compile my own version of rockbox always with album art/progressbar y coord/scroll margin/etc.. and I pretty sure that lots of people are doing the same.

Can some one explain me why this album art patches are still not in the CVS?
They are primary feature for Rockbox, and it does no harm to people that doesn't use an album art WPS.

It's  a big pain to try to adapt the patches on every CVS code modification.

If there is a good reason, please let me know. Otherwise, can someone commit these essential patches?

Thank you everyone for the great software you are creating.

Cheers,

Bernych

[Llorean]

Have you tried reading the discussion of them on the patch tracker? There are still things in the way of committing it, like not having metadata-on-buffer, I believe.

[JdGordon]

can someone commit these essential patches?

I fail to see how AA is an essential patch.. personally i tihnk its a waste of space.. (lucky for you the final say isnt mine :p )

[NicolasP]

Album art is currently implemented in an inelegant way, and I'm waiting for metadata on buffer to come along to be able to do it the right way.
Progressbar Y coord hasn't been commited because it's author refuses to give his real name, which is against the project's policy.
Scrollmargins will never be commited because it will be made obsolete by viewports (whenever they are added... is anyone working on it ?)

[bascule]

...Scrollmargins will never be commited because it will be made obsolete by viewports...

So would it be possible to commit this WPS partial line scroll patch (link) instead?

It moves the scrolling to start after the %s, so that you can have:

Title: %s%it

and the 'Title:' bit of the line does not scroll.

I don't know how near the viewport implementation is, but this is a really small patch that gives an elegant solution to some of the functionality of the scrolling margins patch, that could be committed in the meantime...

Please?  

[rasher]

...Scrollmargins will never be commited because it will be made obsolete by viewports...

So would it be possible to commit this WPS partial line scroll patch (link) instead?

Same deal. This is a much too specific patch. What is wanted is the general "viewports" solution, that will solve a whole bunch of related problems and allow much finer control of the WPS.

[Llorean]

I personally think the partial line scroll would work well even with viewports, that way you don't have to put the "Title:" bit outside it, and the %it tag inside it.

[bascule]

...Same deal. This is a much too specific patch...

I disagree. For me, the patch brings the line scrolling functionality in line with what I would intuitively expect it to do and adds a significant improvement in appearance for simple text-based WPS's (especially on small screens) and with very little cost in terms of code size.

Viewports seems like a different order of magnitude in terms of change to the functionality and when that happens the whole subject would need to be reviewed anyway.

[LinusN]

I wouldn't mind committing the partial scroll patch in the mean time, until the viewport implementation is done.

[bascule]

Many thanks for that, Linus

http://www.rockbox.org/tracker/task/5907

If you need any assisstance/help, just let me know.

[Genre9mp3]

Am I wrong to think that according to all these, album art will be implemented when viewports will be implemented, too?

The reason I am saying this, is because album art is "somehow" depedent on scroll margins. There's no WPS out there that uses album art and not using scroll margins. This is because without scroll margins, you can't have text next to the cover displayed and it's a total waste of space without it (especially on big album art displays, eg. 100x100)

Seeing no one is working on viewports at the moment I guess it will take some time before we see album art on CVS. In fact, we may never see album art on CVS (cause it's more likely that we 'll have switched to SVN by then! )

[lowlight]

I wouldn't mind committing the partial scroll patch in the mean time, until the viewport implementation is done.

I'll do that soon

[Yotto]

Am I wrong to think that according to all these, album art will be implemented when viewports will be implemented, too?

The reason I am saying this, is because album art is "somehow" depedent on scroll margins. There's no WPS out there that uses album art and not using scroll margins. This is because without scroll margins, you can't have text next to the cover displayed and it's a total waste of space without it (especially on big album art displays, eg. 100x100)

These don't use scroll margins:


I know becasue I made them.

I also made one with a centered-top album art, but mistakenly deleted it.  It had textual information on both the right and left of the album art.

[iPodFoo]

All very well if you have a 320x240 screen to fit text on without scrolling

[Yotto]

Well, if the proposed scrolling margins "lite" patch is included, then your problems will be solved with:

Code: [Select]

         %shere is the srolling text
Instead of what I have:

Code: [Select]

         here is the non-scrolling text
If I didn't have the 320x240 display, I'd probably not use 100x100 album art.

One thing about the new %s patch, does it allow you to put an "end point" on the scrolling text?  IE:

non-scrolling%sscrolling%smore non-scrolling

Just a thought, so you could have album art on the right side of the screen as well.  I have no idea how hard it would be to code, so I won't insert the obligatory "It should be easy" clause, thereby volunteering myself to do it