Rockbox General > Rockbox General Discussion
Setting limit volume on rockbox?
Llorean:
But the *advantages* are:
- Does not increase binary size at all beyond current.
Seriously, I don't think it's worth wasting any binary size on an option that simply prevents user error, especially when there are very similar functions that can be achieved using both the equalizer and replaygain (though not ideal, at least they don't increase the binary size any since they're already there).
L:
If you get proper earphones, they wouldn't blow that easily.
Genre9mp3:
--- Quote from: Llorean on October 20, 2006, 08:16:57 AM ---But the *advantages* are:
- Does not increase binary size at all beyond current.
--- End quote ---
I disagree with that point because I don't think that adding such an option will increase the binary size so much that we have to worry about. Sure, binary size is an important factor to take into account but so many features are being added into CVS in daily basis and increase the binary size much more than this feature would.
And to quote LinusN from yesterday's logs:
--- Quote ---let's just stop adding features to rockbox - the binary size is too big
--- End quote ---
Llorean:
Yes, *features* are being added. Things that cannot be done without adding code.
Volume limiting can be done without adding code by a user not increasing the volume.
Saying "it's small" means nothign. It still increases the code size for very very very little added gain.
Genre9mp3:
--- Quote from: Llorean on October 20, 2006, 08:36:28 AM ---Volume limiting can be done without adding code by a user not increasing the volume.
--- End quote ---
Actually this is not a volume limiting feature, it is a "user error" prevent feature, and I _do_ think that such features are worth adding.
Some may find this feature handy, others may won't gain anything from it and never use it (I never experienced such a problem, so I can say that I wouldn't gain for it) but I don't think that we shouldn't add features to conserve binary size at a small size.
We just see it differently... You see it as a "very very very little added gain" feature while I see it as a "very very very little binary size increase" feature
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version