Rockbox General > Rockbox General Discussion

cannot show replaygain values in wps

<< < (5/6) > >>

Multiplex:
OK, after a few hours of consideration and code study (I got distracted working out how the arbitary number of images for the batery worked - neat) I can confirm that it is possible to have "%?rg" and have an "%rg" return the actual gain in use for the current track (probably including RG, Pre-Amp and prevent clipping).

I don't know if I'll get chance to do a patch tonight, if not it will be early next week (you've got to respect all the developers who've managed to find thousands of hours of their own time for this project !)

Multiplex:
OK I spent a bit of time last night and did as previously described;

--- Code: ---%?rg< off|Track|Album|ShuffleTrack|ShuffleAlbum|NoTag >
--- End code ---
and %rg gives the track or album gain from the tag as displayed in the Show ID3 Info screen, I could not see an easy way to get the gain with Pre-Amp and the avoid clipping taken into account without copying a great chunk out of the DSP code.

I need to do some tidying and testing, should be able to upload a new patch tonight or tomorow.

Update: New patch loaded to flyspray in previous location (task 6223)
All we need now is a WPS to make use of it ...

Further Update re-instate the angle brackets - now let's see how many WPS files include the spaces needed to make the brackets appear in the forums...

lenny:
Thanks so much Multiplex! ;D

I just tried the patch and it seems to work great! I think the implementation is very sensible. Thanks

Mmmm:
That's getting better Multiplex.... But is there really a need for the two shuffle results? Surely they are just the same as the two normal track/album results? So you really just need

--- Code: ---%?rg< off|Track|Album|NoTag >
--- End code ---
So intval = 4 and 5 should instead be intval = 2 and 3... (ie you still check for shuffle but just give the track/album result)

What do you think?

Multiplex:
I went for the set of options so that it would be possible get any set of answers that was wanted (I hope)
So, you and I will set it up like;

--- Code: ---%?rg< Off|Track|Album|Track|Album|NoTag >
--- End code ---
someone who likes the original rg settings but sees the benefit of knowing that there is a tag missuing might use;

--- Code: ---%?rg< Off|Track|Album|Shuffle|Shuffle|NoTag >
--- End code ---
And someone who takes an even simpler view than you and me might use;

--- Code: ---%?rg< Off|Track|Album|Track|Album|Off >
--- End code ---
Where 'Track' and 'Album' etc might be code for images, etc.

Of course the full set of values is there for those who want it.

Well, that was the idea anyway ...

Navigation

[0] Message Index

[#] Next page

[*] Previous page