cannot show replaygain values in wps

[Multiplex]

I can certainly see the value of a NoTag response (RG has been configured but there is nothing to work on).

I question the shuffle - that for me was why I did this - I want to know what RockBox is actually doing, not what I asked it to do - logically it should be possible to combine the shuffle setting with the suffle WPS tag to show Track or Album

I can easily do a patch with "NoTag" tomorow night - but should that be an addition to the original list (inc shuffle) ?

[Llorean]

I very much think that it's incredibly *silly* to have an option to show what a setting is set at in the WPS.

The RG info in the WPS should only reflect what is currently being used based on the file, not what it's set at.

If the WPS says "Track" I know the track gain is being used right now, and that the file has track gain info. Whether this is because I've set it to always use Track gain, or because I've set it to use track if shuffling, and shuffling is enabled.

If I want to know what the option is set at, I can check the menu. Since it'll never change unless I change it, it's silly to have it reflected as a WPS tag, as most other WPS tags pretty much relate to information relating to the file or actual playback.

So, Off, Album, Track, and NoTag seem to be the only necessary ones to me at least.

[roolku]

I very much think that it's incredibly *silly* to have an option to show what a setting is set at in the WPS.

What about the shuffle setting? repeat mode ? Or even volume? I don't think you can generalise it this way.

I do however aggree that the 4 options below are sufficient as far as RG is concerned.

So, Off, Album, Track, and NoTag seem to be the only necessary ones to me at least.

As an enhancement, I would suggest to include the actual db values insted the string Album/Track. This gives all the flexibility:

- the actual db value (or "off"/"notag"):
%rg
- text labels (any language you would like):
%?rg<Off|Track|Album|NoTag>
- icons
%?rg<|%xda|%xdb|%xdc>

or any combination with other tags...

[Llorean]

Volume, Repeat mode, and Shuffle setting are the three most changed options during playback, I would imagine. Replaygain is something you rarely, if ever change.

This is why Repeat Mode and Shuffle are in the quick menu, and Volume is actually bound to button so you can change it directly during playback.

[Multiplex]

Llorean, whilst I personally I agree for my own use (hence the the first patch doing exactly what you describe) , I'm thinking that there is an arguable option for this;

  Off|Track|Album|ShuffleTrack|ShuffleAlbum|NoTag

This way everyone can have what they want displayed (I think) in terms of the setting/operation - what's the view?

I'm giving some thought to roolku's suggestion, but to be honest I'd assumed that %rg and %?rg would both be affected by the single change I made - I'll take a look to see.

Or maybe we could use %RG - the case sensitivity has been used for current/next file tags (or is someone going to ask to see the RG value for the next file?).

Though I'm now wondering what value I should return if prevent clipping is enabled

[Multiplex]

OK, after a few hours of consideration and code study (I got distracted working out how the arbitary number of images for the batery worked - neat) I can confirm that it is possible to have "%?rg" and have an "%rg" return the actual gain in use for the current track (probably including RG, Pre-Amp and prevent clipping).

I don't know if I'll get chance to do a patch tonight, if not it will be early next week (you've got to respect all the developers who've managed to find thousands of hours of their own time for this project !)

[Multiplex]

OK I spent a bit of time last night and did as previously described;

Code: [Select]

%?rg< off|Track|Album|ShuffleTrack|ShuffleAlbum|NoTag >

and %rg gives the track or album gain from the tag as displayed in the Show ID3 Info screen, I could not see an easy way to get the gain with Pre-Amp and the avoid clipping taken into account without copying a great chunk out of the DSP code.

I need to do some tidying and testing, should be able to upload a new patch tonight or tomorow.

Update: New patch loaded to flyspray in previous location (task 6223)
All we need now is a WPS to make use of it ...

Further Update re-instate the angle brackets - now let's see how many WPS files include the spaces needed to make the brackets appear in the forums...

[lenny]

Thanks so much Multiplex!

I just tried the patch and it seems to work great! I think the implementation is very sensible. Thanks

[Mmmm]

That's getting better Multiplex.... But is there really a need for the two shuffle results? Surely they are just the same as the two normal track/album results? So you really just need

Code: [Select]

%?rg< off|Track|Album|NoTag >

So intval = 4 and 5 should instead be intval = 2 and 3... (ie you still check for shuffle but just give the track/album result)

What do you think?

[Multiplex]

I went for the set of options so that it would be possible get any set of answers that was wanted (I hope)
So, you and I will set it up like;

Code: [Select]

%?rg< Off|Track|Album|Track|Album|NoTag >

someone who likes the original rg settings but sees the benefit of knowing that there is a tag missuing might use;

Code: [Select]

%?rg< Off|Track|Album|Shuffle|Shuffle|NoTag >

And someone who takes an even simpler view than you and me might use;

Code: [Select]

%?rg< Off|Track|Album|Track|Album|Off >

Where 'Track' and 'Album' etc might be code for images, etc.

Of course the full set of values is there for those who want it.

Well, that was the idea anyway ...

[roolku]

I went for the set of options so that it would be possible get any set of answers that was wanted (I hope)
So, you and I will set it up like;

Code: [Select]

%?rg< Off|Track|Album|Track|Album|NoTag >

someone who likes the original rg settings but sees the benefit of knowing that there is a tag missuing might use;

Code: [Select]

%?rg< Off|Track|Album|Shuffle|Shuffle|NoTag >

And someone who takes an even simpler view than you and me might use;

Code: [Select]

%?rg< Off|Track|Album|Track|Album|Off >

Where 'Track' and 'Album' etc might be code for images, etc.

Of course the full set of values is there for those who want it.

Well, that was the idea anyway ...

I very much agree. Thanks Multiplex (haven't had time to try it yet though).

[Multiplex]

Patch has been incorporated (and made much neater by Magnus), Wiki is updated

I've raised a bug against the manual to get it updated but I may have a look and see how this TeX stuff works ...