Rockbox General > Rockbox General Discussion
cannot show replaygain values in wps
Multiplex:
I can certainly see the value of a NoTag response (RG has been configured but there is nothing to work on).
I question the shuffle - that for me was why I did this - I want to know what RockBox is actually doing, not what I asked it to do - logically it should be possible to combine the shuffle setting with the suffle WPS tag to show Track or Album
I can easily do a patch with "NoTag" tomorow night - but should that be an addition to the original list (inc shuffle) ?
Llorean:
I very much think that it's incredibly *silly* to have an option to show what a setting is set at in the WPS.
The RG info in the WPS should only reflect what is currently being used based on the file, not what it's set at.
If the WPS says "Track" I know the track gain is being used right now, and that the file has track gain info. Whether this is because I've set it to always use Track gain, or because I've set it to use track if shuffling, and shuffling is enabled.
If I want to know what the option is set at, I can check the menu. Since it'll never change unless I change it, it's silly to have it reflected as a WPS tag, as most other WPS tags pretty much relate to information relating to the file or actual playback.
So, Off, Album, Track, and NoTag seem to be the only necessary ones to me at least.
roolku:
--- Quote from: Llorean on October 24, 2006, 11:14:19 AM ---I very much think that it's incredibly *silly* to have an option to show what a setting is set at in the WPS.
--- End quote ---
What about the shuffle setting? repeat mode ? Or even volume? I don't think you can generalise it this way.
I do however aggree that the 4 options below are sufficient as far as RG is concerned.
--- Quote from: Llorean on October 24, 2006, 11:14:19 AM ---So, Off, Album, Track, and NoTag seem to be the only necessary ones to me at least.
--- End quote ---
As an enhancement, I would suggest to include the actual db values insted the string Album/Track. This gives all the flexibility:
- the actual db value (or "off"/"notag"):
%rg
- text labels (any language you would like):
%?rg<Off|Track|Album|NoTag>
- icons
%?rg<|%xda|%xdb|%xdc>
or any combination with other tags...
Llorean:
Volume, Repeat mode, and Shuffle setting are the three most changed options during playback, I would imagine. Replaygain is something you rarely, if ever change.
This is why Repeat Mode and Shuffle are in the quick menu, and Volume is actually bound to button so you can change it directly during playback. ;)
Multiplex:
Llorean, whilst I personally I agree for my own use (hence the the first patch doing exactly what you describe) , I'm thinking that there is an arguable option for this;
Off|Track|Album|ShuffleTrack|ShuffleAlbum|NoTag
This way everyone can have what they want displayed (I think) in terms of the setting/operation - what's the view?
I'm giving some thought to roolku's suggestion, but to be honest I'd assumed that %rg and %?rg would both be affected by the single change I made - I'll take a look to see.
Or maybe we could use %RG - the case sensitivity has been used for current/next file tags (or is someone going to ask to see the RG value for the next file?).
Though I'm now wondering what value I should return if prevent clipping is enabled
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version