Rockbox General > Rockbox General Discussion

cannot show replaygain values in wps

<< < (3/6) > >>

Llorean:
I think that the Off /Track /Album /Shuffle should be change to Off /Track /Album, and show which tags from your file is being used, rather than Replaygain's status in the menu.

The WPS should be relevant information from the playing file in most cases, not things that are static, like that. If the file has no Replaygain information, show "Off", if it has only one of the two, so that it's had to default back from your setting, show which one, etc. I think that would be ideal, rather that simply echoing a setting that you set in the mirror and will not actually ever change until you set it again.

lenny:
I agree with both of you (more so now than before).

and I agree Llorean, the fact that the replaygain tags don't revert to "Off" when there is no tag defeats the purpose. the point is not to see what configuation is set, the point is to see what is happening to the currently playing file. Basically what you said. the replaygain tag should show the "Off" section when there are no rg tags and all will be good.

Multiplex:
I've been looking for something that I (with very rusty coding skills and needing an excuse to play with the VMWare dev environment) can try to contribute to Rockbox...

If no-one else has decided to have a bash I'll see if I can do a patch that will change the %rg tag as Llorean describes;
Replaygain setting (1-3) in the order: Off, Track, Album. Can also be used as a conditional tag %?rg
With the value reflecting what is happening for the curernt track, not the setting.

Don't hold your breath though (and if anyone else is planning to have a go let me know).

Multiplex:
The patch is done and available here; http://www.rockbox.org/tracker/task/6223

I've tested it on the sym for the obvious scenarios;
 - tracks with no tags
 - track gain if shuffled with shuffle on and off
But I didn't go through every permutation.

Try it out and let me know what you think.

Mmmm:
The only reason I dont like this idea is that you can't tell the difference between having the setting off or having the setting on and the file not having replaygain info... So it may say Off and so you think 'ahh, I'd better turn it on then', only to find it is already on and therefore conclude that the gain info is missing. You should be able to tell exactly what the situation is straight away by looking at the WPS.

So personally I think it would be better if the info displayed was

Off
Track
Album
Shuffle
NoTag

where NoTag would only show if replaygain was on and there is no info (ie Off would never show if replaygain was on).

Navigation

[0] Message Index

[#] Next page

[*] Previous page