Creating custom Tagcache query?

[afruff23]

I discovered the problem by looking at the patch code and trial % error: you can't specify a list of more than 3 values. Is there any way to remove this limit, or allow the user to set this limit?

[afruff23]

Bug report here.

[roolku]

I discovered the problem by looking at the patch code and trial % error: you can't specify a list of more than 3 values. Is there any way to remove this limit, or allow the user to set this limit?

Well, there is no intentional limit in the number of items, but I can confirm the problem. The function seems to return true for all cases for long lists. Which is odd, as it doesn't do it in my testbed outside rockbox. I suspect a buffer overflow and will investigate further.....

EDIT: I have uploaded a patch to the tracker.

[afruff23]

Could you please submit this patch separately so it gets noticed? Also, can you allow the user to set the limit to their own will like maximum playlist sizes? Thanks again.

[roolku]

Could you please submit this patch separately so it gets noticed?

I don't think the developers would appreciate that. If you want to get it in, you could talk to slasheri on irc.

Also, can you allow the user to set the limit to their own will like maximum playlist sizes?

From experience that would have no chance of getting into cvs. I think 128 bytes is a good compromise.

EDIT: now in cvs

[afruff23]

Thanks very much!

[afruff23]

It doesn't work.

[afruff23]

When my original playlists didn't work, I tried another one:

Code: [Select]

"A" -> artist ? genre @ "Classic Rock|Grunge|Rock" -> album -> title = "%02d. %s" tracknum title

This works, but over 32 characters does not, so the following does not work:

Code: [Select]

"B" -> artist ? genre @ "Classic Rock|Grunge|Progressive Rock" -> album -> title = "%02d. %s" tracknum title

This works:

Code: [Select]

"C" -> artist ? genre @ "Hard Rock|Grunge|Rock|Metal" -> album -> title = "%02d. %s" tracknum title

So, the 32 character limit is still in place. Obviously I'm using the bleeding edge build.

[roolku]

Yup, I was just about to tell you that your example worked fine for me, when I realised that I had posted the wrong patch.

Here is the corrective patch.

[attachment deleted by admin, too old]

[afruff23]

You had better tell Miika Pekkarinen. He committed that other patch. If I knew how to contact him, I would do it myself. Sorry. Or you could submit this patch yourself. Thanks again for all the work.

[Febs]

The best way to contact him is on IRC.  He uses the name Slasheri.

[afruff23]

Oh right. Forgot about that. Going now...

[afruff23]

It should work now. I'll test later today.

[afruff23]

It works! Thanks a lot to roolku and slasheri for their hard work. Rockbox is now the only DAP software which allows for instant creation of smart playlists (albeit rather simple).

[bascule]

Some new questions:

I've successfully got my custom tagnavi working, with a couple of exceptions. I'm not sure if they are bugs or not.

I'm trying to add a line to display all artists beginning with non-alphabetic characters (911, 50 Cent etc.). I don't just want to look for artists beginning with 0 to 9, as that may exclude some bizarre entries beginning with other characters.

I've tried the following lines and they both only exclude the first query term:

Code: [Select]

"Non-Alphabetical A-E"   -> artist ? artist !^ "A" & !^ "B" & !^ "C" & !^ "D" & !^ "E" -> album  -> title = "%02d %s" tracknum title

This lists all artists except those beginning with 'A'

Code: [Select]

"Non-Alphabetical B&C"   -> artist ? artist !^ "B" & !^ "C" -> album  -> title = "%02d %s" tracknum title

This lists all artists except those beginning with 'B'

It seems that multiple negative queries (does NOT begin with "A" AND does not NOT begin with "B" AND does NOT etc...) do not work correctly.

Similarly, I'm trying to separately list artists beginning with 'T', but not 'The ' and those solely beginning with 'The '

I've tried the following lines

Code: [Select]

"T1"   -> artist ? artist !^ "The " & ^ "T" -> album  -> title = "%02d %s" tracknum title

This lists all artists except those beginning with 'The '

Code: [Select]

"T2"   -> artist ? artist ^ "T" & !^ "The " -> album  -> title = "%02d %s" tracknum title

This lists all artists beginning with 'T', but includes all those beginning with 'The ', which it shouldn't.

It seems like the same problem as above, that concatenated search queries are broken if one of them is a NOT query.

Can anyone confirm, deny or put me straight on this one? If confirmed, I'll raise a bug.