Support and General Use > Audio Playback, Database and Playlists

Creating custom Tagcache query?

<< < (4/9) > >>

afruff23:
I discovered the problem by looking at the patch code and trial % error: you can't specify a list of more than 3 values. Is there any way to remove this limit, or allow the user to set this limit?

afruff23:
Bug report here.

roolku:

--- Quote from: afruff23 on October 09, 2006, 05:19:05 PM ---I discovered the problem by looking at the patch code and trial % error: you can't specify a list of more than 3 values. Is there any way to remove this limit, or allow the user to set this limit?

--- End quote ---

Well, there is no intentional limit in the number of items, but I can confirm the problem. The function seems to return true for all cases for long lists. Which is odd, as it doesn't do it in my testbed outside rockbox. I suspect a buffer overflow and will investigate further.....

EDIT: I have uploaded a patch to the tracker.

afruff23:
Could you please submit this patch separately so it gets noticed? Also, can you allow the user to set the limit to their own will like maximum playlist sizes? Thanks again.

roolku:

--- Quote from: afruff23 on October 10, 2006, 12:06:25 AM ---Could you please submit this patch separately so it gets noticed?

--- End quote ---
I don't think the developers would appreciate that. If you want to get it in, you could talk to slasheri on irc.


--- Quote ---Also, can you allow the user to set the limit to their own will like maximum playlist sizes?

--- End quote ---

From experience that would have no chance of getting into cvs. I think 128 bytes is a good compromise.

EDIT: now in cvs

Navigation

[0] Message Index

[#] Next page

[*] Previous page