small army needed - test major patch

[Llorean]

This custom menu thing should *really* be separated out from the Menu Rework patch. You know how the guys feel about patches that add more than one thing.

[mightybrick]

new toy for you all to play with in v22 of the patch (will be uploaded as soon as im done with the reply)
if there is a file /.rockbox/user_menu.config a new menu item will apear at the top of the main menu called "User Menu"!
this lets you have your own favorites there, and can be any menu item that can be reachable from the main menu.
each number is the sub item you want linked to.. (0 based..), so the 3,2,1 means "general settings" > "display settings" > "browse wps"
if you want to be funny, you can have "endless" looping, -1 will goto the main menu, there is no danger, except if you do that you will get to a point where it wont let you enter any more submenus untill u back out... ( you can have a maximum on 32 items int he user menu, and no, you cannot make sub menus there... yet...)

With the custom menu option, I created a link to the Tagcache submenu, but also displayed in the User Menu was a link to the User Menu, which looped back to itself.  Like this:

User Menu
     User Menu
     Tagcache

Is a link to the User Menu always displayed, or is this a bug?  My config file reads like this:

#Tagcache
3,1,7

Any suggestions?

[Bagder]

This custom menu thing should *really* be separated out from the Menu Rework patch.

Amen. Creeping featurism within a single patch is only gonna make it a lot less likely to be looked at or taken seriously.

Keep separate things in separate patches.

[JdGordon]

hmm.... thats odd... have u got a blank line at the top of the user_menu.config? i just tried and that puts the user menu item there, without it it works fine. (will fix this bug)


as for the settings keys, i've just shot an email off to the dev ml, so hopefully we can come to a decision there

[mightybrick]

hmm.... thats odd... have u got a blank line at the top of the user_menu.config? i just tried and that puts the user menu item there, without it it works fine. (will fix this bug)

Nope, no blank line at top of the file.  

[JdGordon]

bumpage time...
I'm trying to get this ready to be commitable. So the user menu has been removed because id rather get this committed sooner and fix it afterwards.

ill post a new patch in a little while, but untill then, can people post any new bugs they've found that havnt been menioted in the thread yet?
ta

[mightybrick]

This may be a small thing, but I thought it may be good to help things stay consistent.  From the WPS on the iPod, a clockwise scroll increase the volume, and counter-clockwise decreases it.  In the volume menu within the sound settings menu it's just the opposite, a counter-clockwise scroll increases the volume, and clockwise decreases it, due to the ordering of the volume settings listed.  Shouldn't this be altered to maintain consistency, having the direction of scrolling the same direction for the volume in both locations?  It threw me off the first several times I adjusted the volume there.  
I don't know if this is something that can be remedied through your patch, or should be filed as a bug report if others find it counter-intuitive as well.
What are your thoughts?

[JdGordon]

hehe, thats definatly bad, but no really relevant im afriad.. actually it might be..

anyway, patch development has pretty much stopped for the time being. for some unknown reason, using the patch causes the cpu to stay boosted, and the audio codec to get starved, so playback doesnt work, and untill i figure out why I havnt really got motivation to fix the other bugs...
I'll keep the thread posted on any news.