Req help with ipod brightness patch + iPL Loader 2.4

[karlk]

I'm fairly new to Rockbox and patching/compiling. I'm trying to add the ipod brightness patch located here:
http://www.rockbox.org/tracker/task/5234

I have an iPod video with iPL Loader 2.4. When I apply the brightness patch it compiles under Cygwin OK, but when the iPod boots after the Rockbox logo it stops with the message "No files".

In the patch thread Ralf mentioned that there's a bootloader condition to make the bootloader build. I'm hoping someone can tell me how to apply the patch using that option. The command I've been using for patches is:
patch --binary -p0 < ipod_brightness_3.patch

Thanks,
Karl

[Rincewind]

I can't say much to your problem (are you shure you have done the step "make zip" and copied the contents of the zip to your player?)

but: NEVER mess with the bootloader!
If a patch needs to change the bootloader then you should ask your self if you really need it, because the risk is quite high to brick your player if you install a faulty bootloader.

[karlk]

Yep, I did the "make zip" step. I think the problem is I need to use the bootloader condition for the patch to be compatible, but I don't know how to specify that option.

The failed attempts of trying the brightness patch haven't done any damage. Overwriting the .rockbox folder with a new build restores it to normal.

[Llorean]

Rincewind: On the iPods the bootloader is completely safe to mess with. In their cases there's a hardware bootloader (which Rockbox doesn't mess with) that loads a software bootloader from the disk's firmware partition (which is what we replace) that then goes on to load Rockbox.

So if someone screws up the software bootloader, they can still tell the hardware bootloader to take them into disk mode. But you do NOT need to compile the bootloader with this patch. This patch only applies to the regular build, and while it breaks bootloader builds the bootloader binary available, or the fact that you're using the iPL Loader, means that fact doesn't matter.

As well, a version of the patch that doesn't break the bootloader build is now up.

[Rincewind]

hm, never give advice to iPod users if you don't own an iPod...  

[karlk]

I think the brightness patch is simply incompatible with iPL Loader2.

When I saw Ralf's note on the patch page about the bootloader build, I was wishfully thinking there was a condition for making the patch compatible with Loader2.

Now I realize he just meant that the (B)ootloader build from the "configure" command works. Hopefully in the future someone will update the patch to make it compatible with both loaders.

[podshot]

Reset to the default settings by booting in to rockbox with the hold switch on.
this usually fixes the "no file" error.

ciao

[karlk]

Reset to the default settings by booting in to rockbox with the hold switch on.
this usually fixes the "no file" error.

That fixed it! Thanks!

*kicks myself for not thinking to do that*

Everyone forget about what I said about the patch being incompatible-- Brightness menu is working fine!