Rockbox General > Rockbox General Discussion
small army needed - test major patch
Rincewind:
--- Quote from: Llorean on September 25, 2006, 10:52:57 AM ---I think that the idea was "Left leaves the setting where the checkmark is visibly" which would mean that if you moved the checkmark with 'Select' then "backed out" the setting would still hold.
--- End quote ---
OK, with this definition, that's what I wanted to say.
Rincewind:
testing the patch, I found some small "errors".
* in Sound Settings -> Crossfeed -> High Frequency Atenuation
the Values of the Settings have the Unit "Hz". They should have "dB".
* Some integer settings have the highest values on top, some have them at the bottom. Maybe this could be unified?
I took a look at the code, too.
The Menu code looks much cleaner than before and it is easy to see where things should be added to create new menu entries. But to add a new setting it looks like there are more places where I have to add code (settings.c, settings.h, settings_list.c, maybe more?)
I like the comment style you used to make clear what entries belong to which menu.
But I found it confusing, that nearly all the menus are inside main_menu.c and sound_menu.c but without a logical order which menus are where.
I would suggest to put all the menu definitions in one file and the functions and callbacks in a second file (or more files if one is too big). This would make it possible to rearrange the whole menu structure by only editing one file without moving functions and structs between files.
I noticed, that the onplay menu isn't converted yet. But it seems to be fully functional. Are there plans to convert this too or is it something completely different from the main menu?
JdGordon:
hey all...
RayNye: bugger, nothing looks wrong.. so ill have another look this arvo.
Rincwind: "I'll try to make this menu available in my record button configuration patch so that iriver users can have one button access to this menu." - I think this should replace (optionally) the quickscreen, i dont know if anyone agress with me tho.
re: button arguments again :D im making a post to the dev mailing list later this arfternoon, hopefully we can come to an agreement there, but thanks for the suggestions
Rincewind again: bugs, ta, ill fix them.
the menu code hasnt really been neatened up yet, but it will be so its in a more logical order.
as for adding settings, you need to add it to settings.h (like currently), then settings_list.c (instead of settings.c like now), one of the menu files (if relevant), and then you need it it settings.c under settings_apply(), so actually one less thing to do than currently (you dont need to put it under settings_reply() like you used to)
and lastly, yes, only the main menu has been converted so far, the others will follow, although there is no real reason to.
Rincewind:
--- Quote from: jdgordon on September 25, 2006, 05:37:00 PM ---I think this should replace (optionally) the quickscreen, i dont know if anyone agress with me tho.
--- End quote ---
I would agree with it. It should be optional, though. I think many people really like the quickmenu.
I have an idea for the favorites menu:
Would it be possible to have .cfg files appear directly in the menu? With this, one could load several settings at once with only one menu item.
More generally, it would be very nice to specify a file in the user_menu.config like this:
--- Code: ---# something from the main menu
1,2,3
# load cfg file
.rockbox/flat_eq.cfg; "Flat Equalizer"
# load plugin
.rockobx/rocks/tetrox.rock; "Tetris Plugin"
# play mp3
music/my favorite tune.mp3; "The best song ever"
--- End code ---
JdGordon:
ha, nice idea, I'm not sure if it will actually be possible tho.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version