Rockbox General > Rockbox General Discussion

small army needed - test major patch

<< < (5/11) > >>

Rincewind:

--- Quote from: Llorean on September 22, 2006, 10:12:39 AM ---I think he's going to change it so moving the cursor doesn't select a setting, backing out doesn't do anything but back out, and pressing select moves the checkmark (after which if you back out, it's saved). I *think*.

--- End quote ---

I hope not. Because I really like it that it is possible to change a setting without pressing select. My H120 has a quite loud click when I press select, so I try not to push it if I don't need to.
Also, If I interpret your post correctly, this would mean that it takes one more button press to change a setting. I don't think that's a good idea. Why should the current behavior be changed at all?

Llorean:
It could be possible that a right-press moves the checkmark instead of "Select" I imagine. I think the problem was that with the screen like it is now it acts in "unexpected" ways when you try to cancel out of the screen and the selection changes, or if it doesn't show some users the moved checkmark then they don't have visual confirmation of a settings change.

I dunno. I think "selection" should be a separate function from "navigation" but that's just me. Like the common concept of setting a radio button from a series of options and then clicking "Okay" after. I'm certainly not oppossed to a one-button solution, but the current highlighted entry shouldn't be considered the selection in my opinion.

Rincewind:
the current highlighted setting is only the selection for settings that change instantly and that's good, because otherwise you have click navi every time you want to see how something like contrast changes.

for every other setting, the current highlighted only applies when leave the screen (not canceling).

Maybe a nice feature would be an indicator what the previous setting was. This indicator changes with the cursor on dynamic settings and stays at the value that you would get by canceling with the other settings.

(sorry for the grammer, I'm in a hurry)

JdGordon:
thanks all for testing.
RE: the bugs on the first page, I'll hopefully fix them tonight ro tomorow.
RE: the setting seelction screen. I'm quite open to ideas for the setting selection screen. however, I want to try and please the majority (actually, I lie, I want to please the core dev guys...). iirc "they" don't like the current way where left backs out and cancels, So i figured this would be a fairly reasonable compromise.
now, I have no problems adding settings to deal with the settings screen, e.g I would gladly add an option for 1 button selection/cancelation in the screen, but the core devs are fairly against that (so i might just sneak ti in and not tell :D )

OK, now the important bits...
Each setting can have a callback function associated which "applies" whatever value is curently selected, most dont need this (and some it is plain wrong to do this), so aside from the contrtast and "sound items" (e.g volume) which others need this?

AlexP:
Good work!

RE: which items need immediate update, I can't think of anything other than contrast and sound, but unfortunately I managed to drop my H140 yesterday when accessing the disk, and now am having disk problems!  :-\  More unfortunately still, Toshiba seem to have stopped selling the 1.8" ATA disks (everywhere I found in the UK says discontinued) - I guess in preparation for release of the perpendicular disks.

So no more testing for me for a while!

Navigation

[0] Message Index

[#] Next page

[*] Previous page