small army needed - test major patch

[JdGordon]

hey all,

Well, I have been working on this patch for the last while and I tihnk it is at the stage where its finished apart from bugs and code cleanup.

What I need is a small army of testers to help find any bugs which I havnt found myself.

What this patch does is completly replace how all settings and most menus are handled in the code, The big thing for users is no more config block settings, so no reset settings when the code gets updated (yippee )

So, If you are willing to help out, please grab the patch from the bottom of http://www.rockbox.org/twiki/bin/view/Main/MenuSettingsRecoding compile it and test it on your target. It has about a dozen warnings which I know about and will fix, but they are not important and its completly safe to run with them.

What to test and look out for:
- every setting needs to be tested, some cannot be updated "live" (i.e volume can, backlight cant)
- look out for the words "Not Done Yet!" in the menus, if you see this make sure u reply with your target and where exactly you saw it.
- any menu/settings that crash.
- any drawing bugs
- any menu items which are not where they should be (or not there at all!)
- any voice bugs in the menu/settings screens

Last thing, the settings will be saved to /.rockbox/config.cfg, and at the moment the config file is incompatible with the current .cfg files, so if you have a /.rockbox/config.cfg you shuold back it up first.
If you want to help out but cannot compile it for yourself, post a reply or pm me and i will  compile it for you.

Thanks all.

[JdGordon]

bumping, and letting all know i have attached rockbox.ipod for the nano onto the wiki page for those that need it, if other builds are requested i'll put them there also

[soap]

I can test this weekend, but not before.

[AlexP]

I tried to build this for the H140, but after the warnings on make (having patched fine), it refused to make zip, saying something like nothing to do.  Sorry for the vague error message, but I'm in front of a different computer at the moment.  I'll be happy to test if you pop a H140 build up there.

[JdGordon]

BigBambi: hmm.. that sounds odd... you dont need to make zip tho, you only need to copy rockbox.iriver onto the player, all other files from the .zip are fine from a different build

[AlexP]

OK, I'll have a look at that.  I've just got into work though, so can test but not build...

I'll try it tonight if still necessary.

[JdGordon]

ta,
yes testing will be needed right up untill it gets commited.

[JdGordon]

for anyone that is willing to try, please make sure you use v16 from the wiki... config files are now compatible with regular files.. (well apart from a few settings which ant)

[mightybrick]

bumping, and letting all know i have attached rockbox.ipod for the nano onto the wiki page for those that need it, if other builds are requested i'll put them there also

for anyone that is willing to try, please make sure you use v16 from the wiki... config files are now compatible with regular files.. (well apart from a few settings which ant)

It appears the rockbox.ipod for the nano on the wiki is from v15.  Can you compile a new one for the v17 changes to be tested?  Or will testing the v15 be sufficient?
Thanks

[JdGordon]

well.. not really much has changed between the 2, except regular .cfg files work with v17 and not in v15, but apart from that, any bugs you find in v15 are most likely still in 17 so it would still be helpful.

I just realised that not all settings actually do work in 17, which is why i havnt uploaded a new version yet, hopefully ill find the bug in the next hour or so and update

[JdGordon]

yay! fixed it.

I wont be at the computer again till proably monday, so please leave any bugs you find in the thread, and il respond to them all then.

there is a nano version ont he wiki now.

thanks all

[AlexP]

Not much luck I'm afraid!  I still can't compile for H140, this time using v18 and CVS 060921 22:30.

I've managed to patch before, but it's probably something I'm doing.  Nonetheless, here is the error message on make (patching is still OK, a couple of offsets, but nothing major)

Code: [Select]

sound_menu.c:259: error: structure has no member named 'spdif'
sound_menu.c:259: error: initializer element is not constant
sound_menu.c:259: error: (near initialization for 'spdif..global_settings_variable')
sound_menu.c:259: error: initializer element is not constant
sound_menu.c:259: error: (near initialization for 'spdif.')
make[1]: *** [home/rockdev/rockbox-devel/build/apps/sound_menu.o] Error 1
make: *** [all] Error 2

Any ideas?  I've had a look at line 259 in sound_menu.c and spdif is indeed mentioned:

Code: [Select]

MAKE_SETTING_OPT(spdif,NULL);

but my limited programming ability doesn't include knowing what this means!
If it's just me being stupid, if you post a compiled rockbox.iriver for H140, I'll be happy to test - I might be able to do that bit!

[JdGordon]

grr... serves me roght for not testing that target yet :p
im about to upload a new version of the patch onto the wiki, major change is dircache is not crashing for me anymore which is good (although the fix is bad...)

ill up the nano and h100 builds onto the wiki for you both... please test it and let me know any bugs you find. It shuold be stable enough to use as a replacemtn for cvs rockbox.target

[AlexP]

Hi, one immediate comment: the default contrast is so dark as to be unreadable, and rec to clear settings had no effect, as I guess it is the default that is wrong!  When changing the contrast (via the remote), selecting a new value had no effect (the tick did change to the new value), and only when I gave up and pressed stop to exit the menu did the contrast change.  Given the setting doesn't change as you scroll (which would be really useful for things like contrast, if possible), it is quite annoying to have to leave the menu then re-enter 20 times until the setting is correct.

Edit: Oh, and on the wiki page the attached rockbox.iriver says it is for H100, but it's actually for H120.  I tried to edit it, but couldn't see how to change the comment without uploading a new file.

Edit 2: More comments:  

When using a WPS that disables status bar, when you press A/B to go to the menu the statusbar isn't redrawn, so you can still see a line of WPS at the top of the screen.  When you press a button (to scroll for instance), the statusbar re-appears.

In the recording settings, quality I can only see options for MP3 at various bitrates (64, 96, 128, 160, 192, 224).  The options for wavpack and wav are missing, as well as MP3 at 320 KBit/s.

For backlight fade in on main unit, the only option is off.

Inverse LCD mode is just called LCD mode now with settings on or off.  Perhaps LCD mode with the settings called Normal and Inverse?

In remote LCD settings, the forth item is Not Done Yet!

In remote LCD settings, again there is LCD mode not inverse LCD mode, or setting options that say Normal or inverse, not on or off

On the scrolling settings, I think actually owing to the new list settings, there is no example line, so you can't tell what your changed setting is doing until you go back to the WPS or filetree and find a long enough line, then have to go all the way back to the settings to try again - annoying!

On turning dircache on, it no longer tells you you need to restart for the changes to take effect.  I don't know whether that's because the splash is missing, or because you don't have to restart anymore!

Edit 3:

View Current Playlist under Playlist options doesn't do anything if you haven't got a playlist loaded.  Perhaps a splash saying no playlist or something?

[mightybrick]

I tried testing the rockbox.ipod v19 for the nano, but when rockbox tries to boot, I get a blank screen with the message:

Data abort
00014310

and it freezes.  I have to reboot, and manually go into diskmode and put the CVS rockbox.ipod back into the root to boot completely.
I hope that all made sense!