which album art patches to i apply?

[pixeldotz]

i'm trying to get album art wps working.

i've tried
album_art_v5.00.patch
w/
bmp_resize_v0.95.patch

and i keep errors like FAILED and then at the end of compiling ERRORS.

i figured i'd ask here since lots of the wps have album art enabled.

which patch versions work with the current cvs?

[Massa]

Is there any reason why you try to use old versions and don't use the newest available ones
(v0.99.6-MM of bmp_resize and v5.1.1 of album art patch)

Try the newest one and tell me if it's still not working...  

[pixeldotz]

i re-compiled with those two patches applied (the ones you mentioned).

http://img179.imageshack.us/my.php?image=errordsw3.png


i still get these errors. is there a way to fix them?

this is a compile for the iriver_h10_20GB

[Massa]

It seems that the bmpviewer is no longer compileable with the current CVS
The reason is the new keymapping mechanism...

For now just remove the bmpviewer by removing the line "bmpviewer.c" in "apps/plugins/SOURCES"
And then recompile the beast

I'll have a deeper look at it tomorrow (don't have time today)...

[pixeldotz]

i did that after your suggestion.
now all i get is a bunch of hex lines (im guessing its the patches trying to open the bmp and just displays the hex for in plain text instead).

i'll just till you get a chance to look at it.

thanks for the help though.

[Massa]

I now splitted the patch bmp_resize-patch in two:
One part is just the resizing and the second (not necessary needed) one is the bmpviewer.

The problem with the bmpviewer is, that it does not have keycode definitions for all targets.
So it does currently only compile on a few one.
I decided to keep it unchanged (it's only TEST code) and put it in an extra patch instead.
So it should be O.K. for most people

I tested the h10_20G version inside the simulator and it worked without problems - I'm unable to reproduce your "bunch of hex lines"?
Please retry to clean your build environment and reconfigure and recompile it...

[pixeldotz]

i'll give that a try right now.

thanks massa.

[pixeldotz]

i applied both patches that you mentioned to last nights build.

only error'd on the bmpviewer (like you said it would)

here's a screen shot of the hex i was talking about.

http://img226.imageshack.us/img226/5079/dump060915052140vx7.png

[Massa]

It shouldn't make a difference - but why didn't you use the updated (splitted) patch of bmp_resize?

Please zip and send me the WPS you use (including bitmaps of course) and maybe also one of your album bitmaps which doesn't work...
I'll test it inside the simulator and see, if it works here...

[pixeldotz]

i did. these are the patches i applied.

Here's the same version as above.
Synched with today's CVS and splitted into two patches:
One for the resizing code and the other to add the bmpviewer.
The resizing code is (and was) platform independent, but the
bmpviewer code is missing keycode defintions for several platforms.
So it will currently not compile for several platforms (e.g. H10).
The bmpviewer is only example code and not necessary needed so I decided
to put it in an extra patch which has been applied on top of the resize
patch if wanted.

IMHO it should somehow be integrated in the jpegviewer...
(which then would extend it into a "pictureviewer"
bmp_resize_v0.99.6-MM.20060913.patch
bmpviewer_20060913.patch

here's the link to the wps i screen shotted for you.

http://www.rockbox.org/twiki/pub/Main/WpsIaudioX5/boeselhack_v2.02.zip

[Massa]

You should _NOT_ apply the bmpviewer patch, only the bmp_resize patch.
The bmpviewer does currently not work for the H10 platform.

Did you edit the wps before you used it?
And did you read the manual I wrote at the patch page???

The WPS you posted does use the old %C syntax and does of course no longer work.
You have to change the %C line to be a %Cl (<- this is a lower "L") line - best at the
top of file, near the %xl tags...

And you have to add a %C tag (without any parameter).

I tested the changed WPS inside the simulator and it works without problems.
No hex lines at all!
So either it's problem which only occurs on the real device or you made something wrong when editing the WPS.
Or did you include other patches which interfere with the resize and albumart patches?

Here everything is fine (inside the simulator) so if the problem still occurs you'll have to find a developer with a real X5 device who may help you...

BTW, I used the following %Cl line - this one also enables resizing of the images

Code: [Select]

%Cl|0|28|s100|s100|

[pixeldotz]

i found out the hex i was seeing was something written in the wps.

so it was no ones fault but the wps creator .

i used the v2.0.2 of said wps and made the changes you suggested to the bottom.

i've tried

Code: [Select]

# Cover Art
%Cl|0|28|s100|s100|
%C

and

Code: [Select]

# Cover Art
%Cl|0|28|s100|s100|
%C|

both at the top and bottom of the wps (don't know what difference this makes)

i've used only
bmp_resize_v0.99.6-MM.20060913.patch

i've followed these instructions for making the cover.bmp

Code: [Select]

album art auto resize patch(support 24bit bmp/8-bit palette bmp/Mono bmp)
cover.bmp is resized by the automatic operation according to wps.
When reducing, the interpolation reduction is done.(ALL LCD type)
bmp file MAX Width is 1024.

i've used my own cygwin compiling environment (as per the instructions for isntalling cygwin rockbox compiling environment in windows)

i've even tried the vmware pre-installed environment.

everything compiles with no errors (both sims and device compiles)
(nano, h10_20GB, iaudiox5)

and it still won't show album art.

the builds work fine on my devices and in the sims with no errors. i got no errors from in the wps or glitches.

could it be the music setup? i have my folders as such

.rockbox
music
----Flow (this is the artist folder)
---------cover.bmp (album art inside artist folder)
---------go.mp3    (music file inside artist folder)

any suggestions? im probably starting to get annoying i know, it's just i hate to give up on something when so many other people have had success with it.