no resume on text viewer?

[the_winch]

If it's just an old version the source is in cvs. Based on whats in roolku post it's here.

[whatchamacallit]

Thanks the_winch,

well, that's a lot of stuff.
I don't really understand why, given the fact that it's there and that there are obviously quite some people who'd like to see the bookmark feature back, none of the active Rockboxers has yet made an attempt to integrate it into the current build again, but to comply with the GPL as pointed out by Llorean, I'll just put this into a word document and post it on my homepage along with the two files.
Greetings,

whatchamacallit

[Febs]

I've merged the two related threads on this topic.

[stanelie]

Now that we know what happened to text viewer resume, can a dev please put it back in CVS so that it is available to all?

[Dwyloc]

I would also really like to see the resume feature fix again soon.

[stanelie]

Well.

I've set up a dev environment so that I can compile the old viewer.c file from rev. 1.31 ( http://www.rockbox.org/viewcvs.cgi/*checkout*/apps/plugins/viewer.c?rev=1.31&content-type=text/plain ) for my H10 and the process went well.

But it does not work. This is not the right revision, I do not have resume either.

Could someone please post the source code to the version that works? whatchamacallit?

Stanislas

[stanelie]

Also, I found that the working version from whatchamacallit has the settings menu from 1.32 and the settings file from 1.31.

I really need the source code from this.

The link from the webpage http://www.hoffried.de/iriver.htm is broken.

Stanislas

[pabouk]

You should be able to retrieve the old sources from CVS. See:
http://www.rockbox.org/twiki/bin/view/Main/UsingCVS
http://www.nongnu.org/cvs/

You even do not need to install CVS and learn how to use it :
http://www.rockbox.org/viewcvs.cgi/apps/plugins/viewer.c

The autobookmarking was added here:
http://www.rockbox.org/viewcvs.cgi/apps/plugins/viewer.c.diff?r1=1.12&r2=1.13

[stanelie]

Working with cvs is not the problem.

As I wrote earlier, the custom version posted by whatchamacallit is a working blend of two or more different versions from cvs. So this version (the working one) is not in cvs.

Stanislas

[stanelie]

Well.

Jonathan Gordon repaired the text viewer today.

Bookmarking works again!

Thanks, Jonathan Gordon!

Stanislas

[JdGordon]

fixed it again, in case you dont see the cvs commit log.. now stores the last 46 files instead of 10

[stanelie]

Mr. Gordon,

I have a small request : would it be possible for you to implement the capacity for the text viewer to use a font different then the one used by the system? Perhaps a menu where one could choose the font used to read text?

Thanks!

stanelie

[JdGordon]

I dont tihnk so. If your asking for a different font than the user font then for sure no, but if you mean to not use the system font and instead use the user font (im not sure if it does that or not...) then its possible... but dont hold your breath :p

[stanelie]

Ok.

Thanks!

Stanislas

[pabouk]

The text viewer uses the user font already.