Scrolling Margins and Album Art

[rossy!]

It would be good if the popular rockbox patches 'scrolling margins' and 'album art' were included in the daily builds on colour platforms, because i would like to use these patches but i cant build rockbox on my system. Also they are very popular for use in custom wps.

[Febs]

Sure, it would be great, but unless the patch author (or someone else) updates these patches to address the issues that the core developers have with them, they won't get included in CVS.  

[Massa]

Sure, it would be great, but unless the patch author (or someone else) updates these patches to address the issues that the core developers have with them, they won't get included in CVS.

Huh?  
The scrollmargins are an unwanted feature - they will become useless with the viewports. So I doubt that patch ever gets included.
(I was told the same when I asked about another patch which adds margins for the peakmeter tag)

And albumart is still not completely ready for CVS inclusion - actually we're also waiting for the viewport implementation and some other stuff.
Nobody of the core developers told me or Nicolas any issues!

BTW, this is normal - most of the time you only get feedback when you often go to IRC and ask for feedback - put the accent on "often"!

[NicolasP]

Actually the issue with album art (and i hope it's the only one keeping it from getting included. If not, please tell us what's wrong) is that the bitmaps are loaded at a bad time because they are stored in the wrong place. The only problem is that to make this right, I have to wait for the metadata to be put in the audio buffer, which doesn't seem to be arriving yet.

[Febs]

Huh?  
The scrollmargins are an unwanted feature - they will become useless with the viewports. So I doubt that patch ever gets included.
(I was told the same when I asked about another patch which adds margins for the peakmeter tag)

I had the same discussion on IRC recently.   The thinking is that if scroll margins were incorporated into CVS, then when the viewport concept is implemented, all of the WPSes that use scroll margins would break.

Here's the IRC discussion, which I think gives some insight into why this patch hasn't been incorporated:

14.45.13 #       (Febs) You know, just before the freeze, there was talk of incorporating the margin patch into CVS.
14.45.38 #       (Febs) I think that is the bigger issue with using many of those WPSes on a standard build, rather than the AA issue.
...
14.47.00 #       (linuxstb) Febs: The problem with doing that IMO is that we will make WPSes work with CVS, but then we will probably break them all again when viewports are implemented - assuming viewports will replace the margins patch.
14.47.29 #       (JdGordon) viewports isnt really happening any time soon tho is it?
...
14.48.11 #       (Febs) Is it realistic to think that implementing viewports won't break existing WPSes anyway?
14.48.20 #       (amiconn) yes
...
14.48.55 #       (Febs) Fair enough.
...
14.50.07 #       (amiconn) Viewports will default to the whole screen unless the wps specifies another viewport
14.50.24 #       (amiconn) So old wps'es that don't specify viewports will just work like before
14.51.33 #       (Febs) That makes sense.
...
14.52.47 #       (Febs) Still, it's not like those WPSes work with Rockbox now anyway, so they're going to have to be updated when viewports are implemented one way or the other.
...
14.53.51 #       (linuxstb) Febs: True, but people will also create new WPSs.
...
14.54.51 #       (amiconn) Febs: I'm not talking about wps'es for inofficially patched rockbox, but about those which are working with current cvs
14.57.32 #       (Febs) Sorry, I wasn't clear.  When I said "those WPSes" I was talking about the ones that work with unofficial builds.
14.57.58 #       (Febs) But I understood your point.
14.59.06 #       (amiconn) Yes, but adding the margin patch would make them official
14.59.34 #       (linuxstb) Febs: I'm sure there are always going to be those problems - the WPS seems to be the favourite place for people to hack new features into, and one of many places where no developer with CVS access seems to work...
15.00.57 #       (amiconn) Another reason why I didn't start viewports yet is that I deem wps design fairly unimportant. It's just design, which helps nothing if the functionality is broken
15.01.31 #       (amiconn) But since viewports will also be useful in other places, I'll start implementing them sometime soonish