Support and General Use > User Interface and Voice
While Recording Screen - User Interface Discussion - including remotes
Davide-NYC:
Thanks!
This (crap) hack job of a patch took a dolt (me) four hours to get functioning without error.
I have very little understanding of the logic. I'm going to pick up a C book and try to read some over the weekend (if I find time). Only by the extreme helpfulness of the devs in IRC was I able to get this done. I actually understand next to nothing of what's going on. :P
It works in the SIM for FMRec, H120 and H320. (that's what I tested) and on an actual H120 target (what I have).
Anyways, jdGordon says that all the recording statusbar stuff might break when he commits the new recording menu stuff. At that point, if you feel the need to fix the RSB-encoder/bitrate/samplerate display maybe you could just 'roll-in' the 'SWCODEC gets icons', 'HWCODEC gets sysfont' feature. I plead! :)
Davide-NYC:
OK, I think I fixed it. ;D
PATCH --> See Here.
Please scrutinize carefully and let me know what you think. If it passes muster please commit it.
If I made any whitespace error please let me know.
Mmmm:
Ahh...much better than before...
I'm just going to point out what each "hunk" of your patch does just so you can tell me if it was intentional or not
statusbar.c:
Hunk#1: adds an extra pixel gap between play state and sample rate
Hunk#2: enables the volume display in non swcodec players
Hunk#3: char buffer[4] should be indented 4 spaces,
Hunk#4: quite a few blank lines deleted and re-added
Hunk#5: get width & height indentation right
Hunk#6: display->setfont(FONT_UI) indentation needs fixing
Icons.[c/h]
Looking good!
Some tiny things
look in the patch at lines like this
- }
+ }
and think to yourself why is it replacing this line with itself? Is this necessary, can I stop that?
Mostly just presentation now...good work...
Do you want to make one more tidyup before I actually test it and maybe commit?
Mmmm:
Also, have you tested this on an actual build (ie not the simulator)?
I didn't think so...It won't compile for SPDIF targets AKA H1xx!! Â ::)
You are using an array that you #ifdef'd out. Also you have an unused char which is a waste of memory, "buffer" isn't used in swcodec targets any more!
and you change the font to sysfont but don't change it back to uifont... not disastrous, but sloppy! You don't need to change to sysfont at all for swcodec targets anymore as you aren't printing any characters.
But these are all tiny things (apart from it not compiling ;))... Nice fonts by the way!
Davide-NYC:
Clearly I am getting ahead of myself. I have purchased a book but have read nothing yet (no time)
Please do me the honors of dismantling this disaster and re-implementing this thing in a way that makes some kind of sense. All this is supposed to do is use the bitmaps I specified and implement the following conditional switch:
IF target=HWCODEC use sysfont to display encoder/bitrate and samplerate in the Recording Statusbar
ELSEIF target=SWCODEC use bitmaps to display encoder/bitrate and samplerate in the Recording Statusbar.
That's it. Please, and thank you.
Before you commit could you post a stand-alone patch so that I may peruse it and maybe learn something from it. Thanks.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version