Rockbox.org home
Downloads
Release release
Dev builds dev builds
Extras extras
themes themes
Documentation
Manual manual
Wiki wiki
Device Status device status
Support
Forums forums
Mailing lists mailing lists
IRC IRC
Development
Bugs bugs
Patches patches
Dev Guide dev guide
Search



Donate

Rockbox Technical Forums


Login with username, password and session length
Home Help Search Staff List Login Register
News:

Rockbox Ports are now being developed for various digital audio players!

+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  New patch: Settings Display Within Menus. DONE!
« previous next »
  • Print
Pages: 1 2 3 [4]

Author Topic: New patch: Settings Display Within Menus. DONE!  (Read 26197 times)

Offline baobab68

  • Member
  • *
  • Posts: 77
Re: New patch: Settings Display Within Menus. DONE!
« Reply #45 on: November 04, 2006, 06:31:21 PM »
I was wondering, and not sure if this has been discussed before...

When using the new item lists within menus, would it be possible that you can highlight your selection and just press LEFT and have the selection acted on.

It feels odd to me to have to press NAVI on it to put it into effect. I am forever changing the treble setting and then cancelling it.  :-)

Maybe there's a technical or usability reason why it doesn't work like that?
Logged

Offline Rincewind

  • Member
  • *
  • Posts: 266
Re: New patch: Settings Display Within Menus. DONE!
« Reply #46 on: November 09, 2006, 10:47:58 AM »
It's not a technical reason, it is just a personal preference from the developer who commited the last major change to the menu system.
It used to be that you could press left to apply a setting, now it has changed to right.

So to save yourself a click on NAVI, you can go into the menu, set your setting and leave it again with right (feels like going through the settings screen and when you come to the other end you are mysteriously at the start again with you setting applied...).
It may not be intuitive but it is faster than pressing NAVI.
I liked it with left better (that was the behavior until a few months ago).

There was quite a long discussion on the dev mailing list about how the buttons on the settings screen should be mapped, but I don't remember if it came to a conclusion.
Logged
Iriver H120, Sansa e280

Offline JdGordon

  • Member
  • *
  • Posts: 1817
  • Constantly breaking stuff
Re: New patch: Settings Display Within Menus. DONE!
« Reply #47 on: November 09, 2006, 04:36:45 PM »
iirc, the outcome was that a checkmark would be used for the currently set item, pressing navi/select would move the checkmark. pressing right or left would exit with the current setting, and off would cancel
Logged


Using PMs to annoy devs about bugs/patches is not a good way to have the issue looked at.

Offline Rincewind

  • Member
  • *
  • Posts: 266
Re: New patch: Settings Display Within Menus. DONE!
« Reply #48 on: November 10, 2006, 09:58:09 AM »
Quote from: jdgordon on November 09, 2006, 04:36:45 PM
iirc, the outcome was that a checkmark would be used for the currently set item, pressing navi/select would move the checkmark. pressing right or left would exit with the current setting, and off would cancel

That's great, exactly what I like the best  :)
Logged
Iriver H120, Sansa e280

Offline Febs

  • Member
  • *
  • Posts: 2701
Re: New patch: Settings Display Within Menus. DONE!
« Reply #49 on: November 10, 2006, 10:19:13 AM »
Actually, I thought that the favored proposal was the one that David-NY summarized today on the developer list:

Quote
UP/DOWN selects items in dir
LEFT exists dir no change
RIGHT enters dir or applies setting and exits (up one level)
NAVI makes change but does not exit dir

An indicator of the current setting (like the checkmark) in addition to the
inverted line (or pointer) based on where your current selection is would be
beneficial.

The checkmark should 'jump' to the inverted line and pause for a tiny amount
of time when NAVI (or RIGHT) is pressed.

I favor this approach for two reasons:

First, it is more consistent with the way that the File Browser works.  In the File Browser, LEFT exits the current folder without selecting the current file.  For consistency, LEFT should exit a settings menu without applying the setting under the cursor.

Second, some platforms do not have a STOP button (iPod, H10) or OFF button (iPod).  Those functions are achieved by a long press of another button.  I do not like the idea of having to use a long keypress to a settings screen with my current settings intact.

Logged
Rockbox Forum Guidelines
The Rockbox Manual
How to Ask Questions the Smart Way
Please do not send me support questions via PM.

Offline mightybrick

  • Member
  • *
  • Posts: 223
  • I Administer Radiation
Re: New patch: Settings Display Within Menus. DONE!
« Reply #50 on: November 10, 2006, 10:38:25 AM »
Quote from: Febs on November 10, 2006, 10:19:13 AM
Actually, I thought that the favored proposal was the one that David-NY summarized today on the developer list:

Quote
UP/DOWN selects items in dir
LEFT exists dir no change
RIGHT enters dir or applies setting and exits (up one level)
NAVI makes change but does not exit dir

An indicator of the current setting (like the checkmark) in addition to the
inverted line (or pointer) based on where your current selection is would be
beneficial.

The checkmark should 'jump' to the inverted line and pause for a tiny amount
of time when NAVI (or RIGHT) is pressed.

I favor this approach for two reasons:

First, it is more consistent with the way that the File Browser works.  In the File Browser, LEFT exits the current folder without selecting the current file.  For consistency, LEFT should exit a settings menu without applying the setting under the cursor.

Second, some platforms do not have a STOP button (iPod, H10) or OFF button (iPod).  Those functions are achieved by a long press of another button.  I do not like the idea of having to use a long keypress to a settings screen with my current settings intact.


I agree with your statements above.  With an iPod, and no OFF button, it would be nice to have a button mapping as listed above.
Logged

Offline Rincewind

  • Member
  • *
  • Posts: 266
Re: New patch: Settings Display Within Menus. DONE!
« Reply #51 on: November 10, 2006, 10:39:12 AM »
Quote from: Febs on November 10, 2006, 10:19:13 AM
Second, some platforms do not have a STOP button (iPod, H10) or OFF button (iPod).  Those functions are achieved by a long press of another button.  I do not like the idea of having to use a long keypress to a settings screen with my current settings intact.

On the ipods and H10, maybe the MENU button could be used as cancel?

Anyway, it is not a big deal, as long as there is a short way (be it LEFT or RIGHT, not only SELECT!) to apply a setting imediatly and exit, I'm fine.
Logged
Iriver H120, Sansa e280

Offline dropandhop

  • Member
  • *
  • Posts: 79
    • My Website
Re: New patch: Settings Display Within Menus. DONE!
« Reply #52 on: December 21, 2006, 10:22:14 AM »
Hey guys,

Just wanted to follow up on this great patch and see where it was heading.

Any news?

Thanks!
Aaron
Logged

Offline dropandhop

  • Member
  • *
  • Posts: 79
    • My Website
Re: New patch: Settings Display Within Menus. DONE!
« Reply #53 on: March 17, 2007, 11:33:11 AM »
Just bumping this one up again.  It was a really neat patch and was wondering if anyone was interested in committing it.

Thanks again!
A
Logged

Offline midgey

  • Developer
  • Member
  • *
  • Posts: 50
Re: New patch: Settings Display Within Menus. DONE!
« Reply #54 on: March 17, 2007, 12:06:31 PM »
Recently, there was a redesign of how the menus work. This patch won't even apply since it was written for the old menu system. Basically, the author has to completely rewrite the patch to get this working again.
Logged

  • Print
Pages: 1 2 3 [4]
« previous next »
+  Rockbox Technical Forums
|-+  Support and General Use
| |-+  User Interface and Voice
| | |-+  New patch: Settings Display Within Menus. DONE!
 

  • SMF 2.0.19 | SMF © 2021, Simple Machines
  • Rockbox Privacy Policy
  • XHTML
  • RSS
  • WAP2

Page created in 0.073 seconds with 15 queries.