Support and General Use > User Interface and Voice
New patch: Settings Display Within Menus. DONE!
AM:
Ok, the latest patch now displays >> (couldn't think of anything better) for menu items that perform actions rather than open submenus (>) in the multiline mode.
I did however opt to not add these right-aligned indicators to the single-line modes. And I'll tell you why: it's beyond the scope of what this patch was originally meant for. If I added those arrows to the ends of all lines you would expect to see them in all menus, not just settings menus (which is what I made this patch for). The arrows where really only added in order to eliminate gaps between lines so it's obvious that there isn't something missing when in multiline mode. And if this was done to all menus, in which case BTW I really should have redone the code in menu.[ch] rather than wrapping and extending them using new source files, pretty soon people would expect the arrows to be there also for folders in the file tree (after all, it would make sense for them to be there for anything that opens a sublevel of anything, and now we're talking not only redoing the menu code but also the list and tree code).
I also think I'm going to give the hunt for 1px margins a rest for now. Those are a) font dependant and b) not just an issue with my patch but with all lists in rockbox (as there are fonts that lack margin not only to the right but also to the left).
Right now I'd rather limit this patch to what it was originally intended for, ie simplifying display and modification of settings - and getting it ready for (hopefully) CVS inclusion *crosses fingers*. After that, if anyone wants to take things further with this they are welcome to modify it however they see fit, and I've tried to the code such as to make things as easy as possible for whoever wishes to to do so.
Anyhow, I have now built and successfully tested the functionality of this patch in sims for all targets except the following for which the sim didn't build (I believe all due to reasons other than my patch):
Archos Gmini 120, Archos Gmini SP, iPod 3G, Toshiba Gigabeat F, SanDisk Sansa e200 and iriver H10 5/6Gb. edit: scratch one more from the list
Mr. Brownstone:
--- Quote from: AM on August 20, 2006, 08:13:08 PM ---the latest patch now displays >> (couldn't think of anything better)
--- End quote ---
How about -> ? ;D
Great looking patch by the way, can't wait to try it out! 8)
Rincewind:
--- Quote from: AM on August 20, 2006, 08:13:08 PM ---words
--- End quote ---
I agree with you completely.
Tonight I try this patch on my player. I hope it is working as well as in the sim.
dropandhop:
I gotta bring this thread back to life. Any ideas if we will ever see this patch commited to CVS?
Thanks for all the work! I think it wonderful.
Thanks,
Aaron
Llorean:
Just as a note: The liveliness or death of a thread us usually not relevant to whether or not a feature gets into Rockbox.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version