New patch: Settings Display Within Menus. DONE!

[AM]

Ok, the latest patch now displays >> (couldn't think of anything better) for menu items that perform actions rather than open submenus (>) in the multiline mode.

I did however opt to not add these right-aligned indicators to the single-line modes. And I'll tell you why: it's beyond the scope of what this patch was originally meant for. If I added those arrows to the ends of all lines you would expect to see them in all menus, not just settings menus (which is what I made this patch for). The arrows where really only added in order to eliminate gaps between lines so it's obvious that there isn't something missing when in multiline mode. And if this was done to all menus, in which case BTW I really should have redone the code in menu.[ch] rather than wrapping and extending them using new source files, pretty soon people would expect the arrows to be there also for folders in the file tree (after all, it would make sense for them to be there for anything that opens a sublevel of anything, and now we're talking not only redoing the menu code but also the list and tree code).

I also think I'm going to give the hunt for 1px margins a rest for now. Those are a) font dependant and b) not just an issue with my patch but with all lists in rockbox (as there are fonts that lack margin not only to the right but also to the left).

Right now I'd rather limit this patch to what it was originally intended for, ie simplifying display and modification of settings - and getting it ready for (hopefully) CVS inclusion *crosses fingers*. After that, if anyone wants to take things further with this they are welcome to modify it however they see fit, and I've tried to the code such as to make things as easy as possible for whoever wishes to to do so.

Anyhow, I have now built and successfully tested the functionality of this patch in sims for all targets except the following for which the sim didn't build (I believe all due to reasons other than my patch):
Archos Gmini 120, Archos Gmini SP, iPod 3G, Toshiba Gigabeat F, SanDisk Sansa e200 and iriver H10 5/6Gb. edit: scratch one more from the list

[Mr. Brownstone]

the latest patch now displays >> (couldn't think of anything better)

How about -> ? 

Great looking patch by the way, can't wait to try it out!

[Rincewind]

words

I agree with you completely.
Tonight I try this patch on my player. I hope it is working as well as in the sim.

[dropandhop]

I gotta bring this thread back to life.  Any ideas if we will ever see this patch commited to CVS?

Thanks for all the work!  I think it wonderful.

Thanks,
Aaron

[Llorean]

Just as a note: The liveliness or death of a thread us usually not relevant to whether or not a feature gets into Rockbox.

[psycho_maniac]

I think AM is on vacation. He said on the patch tracker page that he is going to Dublin and thats the last i heard from him on that patch.

[Rincewind]

the patch doesn't work with current cvs anymore, so we just have to wait a little longer until AM is back. This idea isn't dead yet and the chances are quite good, because LinusN likes it  

[AM]

Well, I'm back from my mini-vacation now (it sort of got extended, after the Dublin trip I've been partying all over Sweden for a while).

Anyhow, it appears quite a bit has happened to CVS while I was away so updating to CVS is no longer just a no-brainer. So I've been thinking; is it really worth it constantly keeping this patch up to date? I mean last I heard (which was a while ago) JdGordon was working on redoing the entire menu system and in the meanwhile it seems to me that efforts to keep this up to date are pretty much wasted. *shrugs* Opinions?

[Rincewind]

I would like to use this patch in my personal build, so I would like to have some updates. I don't need an update for every conflict, I can fix small ones myself, but if there is major work on the menu code it would be nice if this patch gets updated accordingly.

But if you don't have the time, it is ok, too.

If you wait to long with updating it can get harder to make it work with cvs again than it would be if you work on your patch constantly.

If jdGordon applies his menu rework to cvs I would wait until his code is stable before working on the patch again.

[bluebrother]

As far as I understood JdGordon on IRC today the menu rework will still need some time. Also, I really liked the idea of your patch and think it makes the menus way better looking. IMO it would be very sad to loose this piece of work -- maybe this can be integrated with the menu rework?
Anyway, I hope this idea gets implemented in Rockbox sometime.

[Kitty]

what happend to this patch? no one fixing it to fit the latest build?

[Mr. Brownstone]

As far as I understood JdGordon on IRC today the menu rework will still need some time. Also, I really liked the idea of your patch and think it makes the menus way better looking. IMO it would be very sad to loose this piece of work -- maybe this can be integrated with the menu rework?
Anyway, I hope this idea gets implemented in Rockbox sometime.

Well said. Kudos to AM and all who have helped with this patch. 8-)

[Kratos]

what happend to this patch? no one fixing it to fit the latest build?

apparently people are working on it

[JdGordon]

JdGordon was working on redoing the entire menu system

I am, but it will be at least another week because I have exams this week, and for some reason my patch has major issues...

that said tho, (and bearing in mind i havnt looked at your path) I dont tinhk it will be difficult to retrofit this onto my patch if/when it is commited.

[dropandhop]

JdGordon, that is great news!

Thanks for working on this helpful patch.

Regarding the other stuff you are working on-

How is the menu re-working comming along.  Do you think we might expect that commited sometime soon?

And how about porting over all the button changes?  (I think we are still in need of the plugins being ported)

Thanks again!
Aaron